Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Collectives location for AHW-next configuration #7975

Open
wants to merge 1 commit into
base: donal-ah-next-westend
Choose a base branch
from

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Mar 19, 2025

<Junctions>.into_location() generates Location { parents: 0, interior: <Junctions> } - parents defaults to 0

@bkontur bkontur requested a review from seadanda March 19, 2025 13:37
@bkontur
Copy link
Contributor Author

bkontur commented Mar 19, 2025

cc: @karolk91

Copy link
Contributor

@seadanda seadanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will change this on AH westend too (it's been like this there since launch I think)

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/13947929540
Failed job name: fmt

@acatangiu
Copy link
Contributor

Parachain(id).into_location() generates Location { parents: 0, interior: self }

this looks wrong/incorrect - at least unexpected

can you also check if it's a bug or intended? if it's intended, make sure to add clear docs/warning to fn into_location() explaining this

@acatangiu
Copy link
Contributor

ah, nevermind, the problem is with the number of parents - you should change PR description as it is confusing

@bkontur bkontur changed the title Fix Collectives location Fix Collectives location for AHW-next configuration Mar 19, 2025
@karolk91
Copy link

Tested with PET on open-web3-stack/polkadot-ecosystem-tests#210

Works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants