perf(db-postgres): simplify db.updateOne to a single DB call with if the passed data doesn't include nested fields
#13060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the passed data doesn't include nested fields
AlessioGr
reviewed
Jul 7, 2025
AlessioGr
previously approved these changes
Jul 7, 2025
sam-gab
reviewed
Jul 8, 2025
|
|
||
| findManyArgs.where = eq(this.tables[tableName].id, idToUpdate) | ||
|
|
||
| const doc = await db.query[tableName].findFirst(findManyArgs) |
There was a problem hiding this comment.
Similar to the issue for which I created a PR here, this will return null in a read-replica setup - most of the time.
Hence, causing the transform function to throw an error.
cc: @AlessioGr
There was a problem hiding this comment.
I reviewed your PR. You can then pull the latest main and copy your changes for that line as well.
There was a problem hiding this comment.
Thanks for reviewing. Sorry, what do you mean by and copy your changes for that line as well? Where should I copy it to?
DanRibbens
reviewed
Jul 8, 2025
| @@ -2809,6 +2807,32 @@ describe('database', () => { | |||
| } | |||
| }) | |||
|
|
|||
| it('should update simple', async () => { | |||
There was a problem hiding this comment.
I would love to see a in our test that an array or another kind of hasMany field has data added in the create and is omitted from the data in updateOne and assert that it is still present.
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case, if
payload.db.updateOnereceived simple data, meaning no:hasMany: truetext / select / number / relationship fieldsrelationToas an arrayThis PR simplifies the logic to a single SQL
setcall. No any extra (useless) steps with rewriting all the arrays / blocks / localized tables even if there were no any changes to them. However, it's good to note thatpayload.update(notpayload.db.updateOne) as for now passes all the previous data as well, so this change won't have any effect unless you're usingpayload.db.updateOnedirectly (or for our internal logic that uses it), in the future a separate PR with optimization forpayload.updateas well may be implemented.