cleaning up the dump command parameters

Author: dbu

README.md

@@ -28,36 +28,35 @@ NOTE: If you are using PHPCR inside of Symfony, the DoctrinePHPCRBundle
 provides the commands inside the normal Symfony console and you don't need to
 prepare anything special.
 
-* ``phpcr:workspace:create <name>``: Create the workspace name in the configured repository
-* ``phpcr:register-node-types --allow-update [cnd-file]``: Register namespaces and node types from a "Compact Node Type Definition" .cnd file
-* ``phpcr:dump [--sys_nodes[="..."]] [--props[="..."]] [path]``: Show the node names
-     under the specified path. If you set sys_nodes=yes you will also see system nodes.
-     If you set props=yes you will additionally see all properties of the dumped nodes.
-* ``phpcr:purge``: Remove all content from the configured repository in the
-     configured workspace
-* ``phpcr:sql2``: Run a query in the JCR SQL2 language against the repository and dump
-     the resulting rows to the console.
-
-**TODO:**
-
-* Implement commands for phpcr:import and phpcr:export to import and export the
-    PHPCR document view and system view XML dumps.
-* Implement a simple .cnd parser in PHP and use it to make register-node-types
-    work with all repositories
-
+To get a list of the available commands, run `bin/phpcr` or set the commands up
+in your application. Running `bin/phpcr help <command-name>` outputs the
+documentation of that command.
 
 ## Helper Classes
 
 The helper classes provide implementations for basic common tasks to help users
-and implementors of PHPCR. They are all in the namespace PHPCR\Util
+and implementers of PHPCR. They are all in the namespace PHPCR\Util
 
+### PathHelper
 
-### TraversingItemVisitor
+Used to manipulate paths. Implementations are recommended to use this, and
+applications also profit from it. Using `dirname` and similar file system
+operations on paths is not compatible with Microsoft Windows systems, thus you
+should always use the methods in PathHelper.
 
-This ``ItemVisitorInterface`` implementation is a basic implementation of crawling
-a PHPCR tree. You can extend it to define what it should do while crawling the
-tree.
+### NodeHelper
+
+This helper has some generally useful methods like one to generate empty
+`nt:unstructured` nodes to make sure a parent path exists. It also provides
+some useful helper methods for implementations.
+
+### UUIDHelper
 
+This little helper is mainly of interest for PHPCR implementers. It generates
+valid *Universally Unique IDs* and can determine whether a given string is a
+valid UUID.
+We recommend all implementations to use this implementation to guarantee
+consistent behaviour.
 
 ### QOM QueryBuilder
 
@@ -66,25 +65,15 @@ The ``QueryBuilder`` is a fluent query builder with method names matching the
 on top of the QOM factory. It is the easiest way to programmatically build a
 PHPCR query.
 
-
 ### Query Object Model Converter
 
 In the PHPCR\Util\QOM namespace we provide, implementation-independant code to
 convert between SQL2 and QOM. ``Sql2ToQomQueryConverter`` parses SQL2 queries
 into QOM . ``QomToSql2QueryConverter`` generates SQL2 out of a QOM.
 
+### TraversingItemVisitor
 
-### UUIDHelper
-
-This little helper is mainly of interest for PHPCR implementors. It generates
-valid *Universally Unique IDs* and can determine wheter a given string is a
-valid UUID.
-We recommend all implementations to use this implementation to guarantee
-constistent behaviour.
-
-
-# TODO
-
-Move tests about the query converter from phpcr-api-tests tests/06_Query/QOM to
-the tests folder. How to do the tests without a QOM factory implementation?
+This ``ItemVisitorInterface`` implementation is a basic implementation of crawling
+a PHPCR tree. You can extend it to define what it should do while crawling the
+tree.
 

src/PHPCR/Util/Console/Command/NodeDumpCommand.php

@@ -21,20 +21,18 @@
 
 namespace PHPCR\Util\Console\Command;
 
-use PHPCR\Util\UUIDHelper;
 use PHPCR\ItemNotFoundException;
 use PHPCR\RepositoryException;
 use PHPCR\PathNotFoundException;
+
+use PHPCR\Util\UUIDHelper;
+use PHPCR\Util\Console\Helper\PhpcrConsoleDumperHelper;
+
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
-use PHPCR\Util\TreeWalker;
-use PHPCR\Util\Console\Helper\TreeDumper\ConsoleDumperNodeVisitor;
-use PHPCR\Util\Console\Helper\TreeDumper\ConsoleDumperPropertyVisitor;
-use PHPCR\Util\Console\Helper\TreeDumper\SystemNodeFilter;
-
 /**
  * Command subtrees under a path to the console
  *
@@ -43,21 +41,14 @@
  */
 class NodeDumpCommand extends BaseCommand
 {
-    /**
-     * Limit after which to cut lines when dumping properties
-     *
-     * @var int
-     */
-    private $dump_max_line_length = 120;
-
     /**
      * {@inheritDoc}
      */
     protected function configure()
     {
         $this
             ->setName('phpcr:node:dump')
-            ->addOption('sys_nodes', null, InputOption::VALUE_NONE, 'Also dump system nodes')
+            ->addOption('sys-nodes', null, InputOption::VALUE_NONE, 'Also dump system nodes (recommended to use with a depth limit)')
             ->addOption('props', null, InputOption::VALUE_NONE, 'Also dump properties of the nodes')
             ->addOption('identifiers', null, InputOption::VALUE_NONE, 'Also output node UUID')
             ->addOption('depth', null, InputOption::VALUE_OPTIONAL, 'Limit how many level of children to show', "-1")
@@ -72,29 +63,20 @@ protected function configure()
 displayed as yaml arrays.
 
 By default the command filters out system nodes and properties (i.e. nodes and
-properties with names starting with 'jcr:'), the <info>sys_nodes</info> option
+properties with names starting with 'jcr:'), the <info>--sys-nodes</info> option
 allows to turn this filter off.
 HERE
             )
         ;
     }
 
-    /**
-     * Change at which length lines in the dump get cut.
-     *
-     * @param int $length maximum line length after which to cut the output.
-     */
-    public function setDumpMaxLineLength($length)
-    {
-        $this->dump_max_line_length = $length;
-    }
-
     /**
      * {@inheritDoc}
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
         $session = $this->getPhpcrSession();
+        /** @var $dumperHelper PhpcrConsoleDumperHelper */
         $dumperHelper = $this->getHelper('phpcr_console_dumper');
 
         // node to dump

src/PHPCR/Util/PathHelper.php

@@ -36,9 +36,11 @@ class PathHelper
     /**
      * Do not create an instance of this class
      */
+    // @codeCoverageIgnoreStart
     private function __construct()
     {
     }
+    // @codeCoverageIgnoreEnd
 
     /**
      * Check whether this is a syntactically valid absolute path.
@@ -141,15 +143,21 @@ public static function assertValidLocalName($name, $throw = true)
     public static function normalizePath($path, $destination = false, $throw = true)
     {
         if (!is_string($path)) {
-            throw new RepositoryException('Expected string but got ' . gettype($path));
-        }
+            if ($throw) {
+                throw new RepositoryException('Expected string but got ' . gettype($path));
+            }
 
+            return false;
+        }
         if (strlen($path) === 0) {
-            throw new RepositoryException('Path must not be of zero length');
+            if ($throw) {
+                throw new RepositoryException('Path must not be of zero length');
+            }
+
+            return false;
         }
 
         if ('/' === $path) {
-
             return '/';
         }
 
@@ -211,9 +219,28 @@ public static function normalizePath($path, $destination = false, $throw = true)
      */
     public static function absolutizePath($path, $context, $destination = false, $throw = true)
     {
-        if (! $path) {
-            throw new RepositoryException('empty path');
+        if (!is_string($path)) {
+            if ($throw) {
+                throw new RepositoryException('Expected string path but got ' . gettype($path));
+            }
+
+            return false;
         }
+        if (!is_string($context)) {
+            if ($throw) {
+                throw new RepositoryException('Expected string context but got ' . gettype($context));
+            }
+
+            return false;
+        }
+        if (strlen($path) === 0) {
+            if ($throw) {
+                throw new RepositoryException('Path must not be of zero length');
+            }
+
+            return false;
+        }
+
         if ('/' !== $path[0]) {
             $path = ('/' === $context) ? "/$path" : "$context/$path";
         }

tests/PHPCR/Tests/Util/Console/Command/NodeDumpCommandTest.php

@@ -2,11 +2,18 @@
 
 namespace PHPCR\Tests\Util\Console\Command;
 
+use PHPCR\ItemNotFoundException;
+use PHPCR\Util\UUIDHelper;
 use Symfony\Component\Console\Application;
+
+use PHPCR\Util\TreeWalker;
 use PHPCR\Util\Console\Command\NodeDumpCommand;
 
 class NodeDumpCommandTest extends BaseCommandTest
 {
+    /** @var TreeWalker|\PHPUnit_Framework_MockObject_MockObject */
+    protected $treeWalker;
+
     public function setUp()
     {
         parent::setUp();
@@ -17,15 +24,78 @@ public function setUp()
 
     public function testCommand()
     {
-        $this->dumperHelper->expects($this->once())
+        $this->dumperHelper
+            ->expects($this->once())
+            ->method('getTreeWalker')
+            ->will($this->returnValue($this->treeWalker))
+        ;
+        $this->session
+            ->expects($this->once())
+            ->method('getNode')
+            ->with('/')
+            ->will($this->returnValue($this->node1))
+        ;
+        $this->treeWalker
+            ->expects($this->once())
+            ->method('traverse')
+            ->with($this->node1)
+        ;
+
+        $this->application->add(new NodeDumpCommand());
+
+        $this->executeCommand('phpcr:node:dump', array());
+    }
+
+    public function testCommandIdentifier()
+    {
+        $uuid = UUIDHelper::generateUUID();
+
+        $this->dumperHelper
+            ->expects($this->once())
             ->method('getTreeWalker')
-            ->will($this->returnValue($this->treeWalker));
-        $this->session->expects($this->once())
+            ->will($this->returnValue($this->treeWalker))
+        ;
+        $this->session
+            ->expects($this->once())
+            ->method('getNodeByIdentifier')
+            ->with($uuid)
+            ->will($this->returnValue($this->node1))
+        ;
+        $this->treeWalker
+            ->expects($this->once())
+            ->method('traverse')
+            ->with($this->node1)
+        ;
+
+        $this->application->add(new NodeDumpCommand());
+
+        $this->executeCommand('phpcr:node:dump', array('identifier' => $uuid));
+    }
+
+    public function testInvalidRefFormat()
+    {
+        $this->application->add(new NodeDumpCommand());
+
+        try {
+            $this->executeCommand('phpcr:node:dump', array('--ref-format' => 'xy'));
+            $this->fail('invalid ref-format did not produce exception');
+        } catch (\Exception $e) {
+            // success
+        }
+    }
+
+    public function testNotFound()
+    {
+        $this->session
+            ->expects($this->once())
             ->method('getNode')
-            ->will($this->returnValue($this->node1));
+            ->with('/')
+            ->will($this->throwException(new ItemNotFoundException()))
+        ;
 
         $this->application->add(new NodeDumpCommand());
 
-        $ct = $this->executeCommand('phpcr:node:dump', array());
+        $ct = $this->executeCommand('phpcr:node:dump', array(), 1);
+        $this->assertContains('does not exist', $ct->getDisplay());
     }
 }