Skip to content

Documentation change to reflect removal of DNS.WATCH (FTL PR #2411) #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rrobgill
Copy link
Contributor

@rrobgill rrobgill commented Apr 3, 2025

What does this PR aim to accomplish?:

Remove documentation reference to DNS.WATCH in line with pi-hole/FTL#2411


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Rob Gill <rrobgill@protonmail.com>
Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 3a7c4ae
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/67ee0c70191ee30008574aae
😎 Deploy Preview https://deploy-preview-1223--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is fine.

Should not be merged before the next FTL version is released to not confuse users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants