Skip to content

Commit 83f6872

Browse files
alan-agius4atscott
authored andcommitted
ci: disable system js tests (angular#49559)
These are currently broken due to the APF v16 changes which dropped support for ES2015. PR Close angular#49559
1 parent 6762f79 commit 83f6872

File tree

4 files changed

+14
-5
lines changed

4 files changed

+14
-5
lines changed

aio/content/examples/upgrade-module/BUILD.bazel

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,9 @@ docs_example(
88
flaky = True, # TODO: figure out why this is flaky or times out
99
# This example downloads and inlines resources
1010
test_exec_properties = ENABLE_NETWORK,
11-
test_tags = ["requires-network"],
11+
test_tags = [
12+
"requires-network",
13+
# This is currently broken due to usage of ESM2022 which does not work out-of-the-box with system.js.
14+
"broken",
15+
],
1216
)

aio/content/examples/upgrade-phonecat-2-hybrid/BUILD.bazel

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,9 @@ docs_example(
88
flaky = True, # TODO: figure out why this is flaky or times out
99
# This example downloads and inlines resources
1010
test_exec_properties = ENABLE_NETWORK,
11-
test_tags = ["requires-network"],
11+
test_tags = [
12+
"requires-network",
13+
# This is currently broken due to usage of ESM2022 which does not work out-of-the-box with system.js.
14+
"broken",
15+
],
1216
)

aio/content/examples/upgrade-phonecat-3-final/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,5 @@ package(default_visibility = ["//visibility:public"])
55
docs_example(
66
name = "upgrade-phonecat-3-final",
77
flaky = True, # TODO: figure out why this is flaky or times out
8+
test_tags = ["broken"], # This is currently broken due to usage of ESM2022 which does not work out-of-the-box with system.js.
89
)

aio/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
"build-prod": "yarn build --config=release",
1313
"build-local": "yarn build --config=aio_local_deps",
1414
"lint": "yarn check-env && yarn docs-lint && ng lint && yarn example-lint && yarn tools-lint && yarn security-lint",
15-
"test": "bazel test //aio:test --test_output=streamed",
16-
"test-and-watch": "ibazel test //aio:test-and-watch --test_output=streamed",
15+
"test": "bazel test //aio:test --test_output=streamed --test_tag_filters=-broken",
16+
"test-and-watch": "ibazel test //aio:test-and-watch --test_output=streamed --test_tag_filters=-broken",
1717
"test-local": "yarn test --config=aio_local_deps",
18-
"test:ci": "bazel test //aio/...",
18+
"test:ci": "bazel test //aio/... --test_tag_filters=-broken",
1919
"test-local:ci": "yarn test:ci --config=aio_local_deps",
2020
"e2e": "bazel test //aio:e2e",
2121
"e2e-local": "yarn e2e --config=aio_local_deps",

0 commit comments

Comments
 (0)