ci: remove browserstack configuration (angular#43881)

Remove browserstack configuration from the repo as it is not used for our CI.

PR Close angular#43881

Author: josephperrott

CONTRIBUTING.md

@@ -259,7 +259,7 @@ The `<type>` and `<summary>` fields are mandatory, the `(<scope>)` field is opti
 Must be one of the following:
 
 * **build**: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
-* **ci**: Changes to our CI configuration files and scripts (example scopes: Circle, BrowserStack, SauceLabs)
+* **ci**: Changes to our CI configuration files and scripts (examples: CircleCi, SauceLabs)
 * **docs**: Documentation only changes
 * **feat**: A new feature
 * **fix**: A bug fix

browser-providers.conf.js

@@ -7,7 +7,6 @@
  */
 
 // Unique place to configure the browsers which are used in the different CI jobs in Sauce Labs (SL)
-// and BrowserStack (BS).
 // If the target is set to null, then the browser is not run anywhere during CI.
 // If a category becomes empty (e.g. BS and required), then the corresponding job must be commented
 // out in the CI configuration.
@@ -120,14 +119,7 @@ var customLaunchers = {
     platform: 'Android',
     version: '10.0',
     device: 'Android GoogleAPI Emulator'
-  },
-  'BS_CHROME': {base: 'BrowserStack', browser: 'chrome', os: 'OS X', os_version: 'Yosemite'},
-  'BS_FIREFOX': {base: 'BrowserStack', browser: 'firefox', os: 'Windows', os_version: '10'},
-  'BS_SAFARI10': {base: 'BrowserStack', browser: 'safari', os: 'OS X', os_version: 'Sierra'},
-  'BS_EDGE': {base: 'BrowserStack', browser: 'edge', os: 'Windows', os_version: '10'},
-  'BS_WINDOWSPHONE':
-      {base: 'BrowserStack', device: 'Nokia Lumia 930', os: 'winphone', os_version: '8.1'},
-  'BS_ANDROID7': {base: 'BrowserStack', device: 'Google Pixel', os: 'android', os_version: '7.1'}
+  }
 };
 
 var sauceAliases = {
@@ -146,27 +138,9 @@ var sauceAliases = {
   'CI_OPTIONAL': buildConfiguration('unitTest', 'SL', false)
 };
 
-var browserstackAliases = {
-  'ALL': Object.keys(customLaunchers).filter(function(item) {
-    return customLaunchers[item].base == 'BrowserStack';
-  }),
-  'DESKTOP': [
-    'BS_CHROME',
-    'BS_FIREFOX',
-    'BS_EDGE',
-  ],
-  'MOBILE': ['BS_ANDROID7', 'BS_WINDOWSPHONE'],
-  'ANDROID': ['BS_ANDROID7'],
-  'IOS': [],
-  'SAFARI': [],
-  'CI_REQUIRED': buildConfiguration('unitTest', 'BS', true),
-  'CI_OPTIONAL': buildConfiguration('unitTest', 'BS', false)
-};
-
 module.exports = {
   customLaunchers: customLaunchers,
   sauceAliases: sauceAliases,
-  browserstackAliases: browserstackAliases
 };
 
 function buildConfiguration(type, target, required) {

karma-js.conf.js

@@ -102,7 +102,6 @@ module.exports = function(config) {
 
     plugins: [
       'karma-jasmine',
-      'karma-browserstack-launcher',
       'karma-sauce-launcher',
       'karma-chrome-launcher',
       'karma-sourcemap-loader',
@@ -134,14 +133,6 @@ module.exports = function(config) {
       maxDuration: 5400,
     },
 
-    browserStack: {
-      project: 'Angular2',
-      startTunnel: false,
-      retryLimit: 3,
-      timeout: 1800,
-      pollingTimeout: 10000,
-    },
-
     // Try "websocket" for a faster transmission first. Fallback to "polling" if necessary.
     transports: ['websocket', 'polling'],
 
@@ -168,11 +159,6 @@ module.exports = function(config) {
     // Setup the Saucelabs plugin so that it can launch browsers using the proper tunnel.
     conf.sauceLabs.build = tunnelIdentifier;
     conf.sauceLabs.tunnelIdentifier = tunnelIdentifier;
-
-    // Setup the Browserstack plugin so that it can launch browsers using the proper tunnel.
-    // TODO: This is currently not used because BS doesn't run on the CI. Consider removing.
-    conf.browserStack.build = tunnelIdentifier;
-    conf.browserStack.tunnelIdentifier = tunnelIdentifier;
   }
 
   // For SauceLabs jobs, we set up a domain which resolves to the machine which launched
@@ -188,8 +174,7 @@ module.exports = function(config) {
   }
 
   if (process.env.KARMA_WEB_TEST_MODE) {
-    // KARMA_WEB_TEST_MODE is used to setup karma to run in
-    // SauceLabs or Browserstack
+    // KARMA_WEB_TEST_MODE is used to setup karma to run in SauceLabs.
     console.log(`KARMA_WEB_TEST_MODE: ${process.env.KARMA_WEB_TEST_MODE}`);
 
     switch (process.env.KARMA_WEB_TEST_MODE) {
@@ -199,12 +184,6 @@ module.exports = function(config) {
       case 'SL_OPTIONAL':
         conf.browsers = browserProvidersConf.sauceAliases.CI_OPTIONAL;
         break;
-      case 'BS_REQUIRED':
-        conf.browsers = browserProvidersConf.browserstackAliases.CI_REQUIRED;
-        break;
-      case 'BS_OPTIONAL':
-        conf.browsers = browserProvidersConf.browserstackAliases.CI_OPTIONAL;
-        break;
       default:
         throw new Error(
             `Unrecognized process.env.KARMA_WEB_TEST_MODE: ${process.env.KARMA_WEB_TEST_MODE}`);

package.json

@@ -169,7 +169,6 @@
     "@types/cldrjs": "^0.4.22",
     "@types/cli-progress": "^3.4.2",
     "@yarnpkg/lockfile": "^1.1.0",
-    "browserstacktunnel-wrapper": "^2.0.4",
     "check-side-effects": "0.0.23",
     "cldr": "7.1.1",
     "cldrjs": "0.5.5",
@@ -180,7 +179,6 @@
     "gulp-conventional-changelog": "^2.0.35",
     "husky": "7.0.2",
     "inquirer": "^8.0.0",
-    "karma-browserstack-launcher": "^1.3.0",
     "karma-sauce-launcher": "^4.3.6",
     "madge": "^5.0.0",
     "sauce-connect": "https://saucelabs.com/downloads/sc-4.6.2-linux.tar.gz",

packages/common/test/i18n/format_date_spec.ts

@@ -345,7 +345,6 @@ describe('Format date', () => {
     // https://github.com/angular/angular/issues/21491
     it('should not assume UTC for iso strings in Safari if the timezone is not defined', () => {
       // this test only works if the timezone is not in UTC
-      // which is the case for BrowserStack when we test Safari
       if (new Date().getTimezoneOffset() !== 0) {
         expect(formatDate('2018-01-11T13:00:00', 'HH', ɵDEFAULT_LOCALE_ID))
             .not.toEqual(formatDate('2018-01-11T13:00:00Z', 'HH', ɵDEFAULT_LOCALE_ID));

packages/router/karma.conf.js

@@ -89,7 +89,6 @@ module.exports = function(config) {
 
     plugins: [
       'karma-jasmine',
-      'karma-browserstack-launcher',
       'karma-sauce-launcher',
       'karma-chrome-launcher',
       'karma-sourcemap-loader',

packages/zone.js/test/karma_test.bzl

@@ -78,7 +78,6 @@ def karma_test(name, env_srcs, env_deps, env_entry_point, test_srcs, test_deps,
             ],
             tags = ["zone_karma_test"],
             runtime_deps = [
-                "@npm//karma-browserstack-launcher",
                 "@npm//karma-sauce-launcher",
             ],
         )
@@ -110,7 +109,6 @@ def karma_test(name, env_srcs, env_deps, env_entry_point, test_srcs, test_deps,
                 # Visible to //:saucelabs_unit_tests_poc target
                 visibility = ["//:__pkg__"],
                 runtime_deps = [
-                    "@npm//karma-browserstack-launcher",
                     "@npm//karma-sauce-launcher",
                 ],
             )

scripts/browserstack/start_tunnel.js

@@ -318,7 +318,6 @@ def karma_web_test_suite(name, **kwargs):
 
     # Add common deps
     deps = kwargs.pop("deps", []) + [
-        "@npm//karma-browserstack-launcher",
         "@npm//karma-sauce-launcher",
         "@npm//:node_modules/tslib/tslib.js",
         "//tools/rxjs:rxjs_umd_modules",