Skip to content

Commit c981006

Browse files
devversionmhevery
authored andcommitted
ci: lock chrome and firefox versions for saucelabs (angular#29529)
With 0f1da49, the Chrome beta job has been disabled because a new Chrome beta has been released, but Saucelabs didn't support a chromedriver that is compatible with that given beta version. Now the topic of pinning these external browsers to a specific version came up. In order to make the build less prone to unexpected new versions, we need to _permanently_ disable the Chrome beta browser. Otherwise pinning `SL_CHROME` to a specific version does not statisfy the requirement of making the CI jobs more deterministic. See original discussion: angular#29518 (comment) Chrome can be pinned to Chrome v73 (latest stable version at time of this commit) Firefox can be pinned to Firefox v65 (latest stable version available in Saucelabs platform) PR Close angular#29529
1 parent 1727fe2 commit c981006

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

browser-providers.conf.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
var CIconfiguration = {
1515
'Chrome': {unitTest: {target: 'SL', required: true}, e2e: {target: null, required: true}},
1616
'Firefox': {unitTest: {target: 'SL', required: true}, e2e: {target: null, required: true}},
17-
// Temporarily disabled because Saucelabs now runs Chrome v74 as beta version. Unfortunately
18-
// Saucelabs doesn't provide a Chromedriver version that works for that beta version though.
19-
// TODO(FW-1205): Re-enable once Saucelabs supports Chromedriver v74.0.3729.6.
17+
// Disabled because using the "beta" channel of Chrome can cause non-deterministic CI results.
18+
// e.g. a new chrome beta version has been released, but the Saucelabs selenium server does
19+
// not provide a chromedriver version that is compatible with the new beta.
2020
'ChromeBeta': {unitTest: {target: 'SL', required: false}, e2e: {target: null, required: false}},
2121
'ChromeDev': {unitTest: {target: 'SL', required: false}, e2e: {target: null, required: true}},
2222
// FirefoxBeta and FirefoxDev should be target:'BS' or target:'SL', and required:true
@@ -46,10 +46,10 @@ var customLaunchers = {
4646
'DartiumWithWebPlatform':
4747
{base: 'Dartium', flags: ['--enable-experimental-web-platform-features']},
4848
'ChromeNoSandbox': {base: 'Chrome', flags: ['--no-sandbox']},
49-
'SL_CHROME': {base: 'SauceLabs', browserName: 'chrome', version: 'latest'},
49+
'SL_CHROME': {base: 'SauceLabs', browserName: 'chrome', version: '73'},
5050
'SL_CHROMEBETA': {base: 'SauceLabs', browserName: 'chrome', version: 'beta'},
5151
'SL_CHROMEDEV': {base: 'SauceLabs', browserName: 'chrome', version: 'dev'},
52-
'SL_FIREFOX': {base: 'SauceLabs', browserName: 'firefox', version: 'latest'},
52+
'SL_FIREFOX': {base: 'SauceLabs', browserName: 'firefox', version: '65'},
5353
'SL_FIREFOXBETA':
5454
{base: 'SauceLabs', platform: 'Windows 10', browserName: 'firefox', version: 'beta'},
5555
'SL_FIREFOXDEV':

0 commit comments

Comments
 (0)