Remove verbose output and stop redirecting output

Prior to this commit, we included --verbose on the vacuumdb
command so that we could see the command was working.  It turns
out that verbose output goes to STDERR and thus can't be
redirected to a file seperate from actual error messages.

After this commit, we no longer try to redirect output to any files.
Instead we remove the verbose output and hope that when an error
occurs it'll actually fire off a cron email.

Author: npwalker

files/vacuum_full_tables.sh

@@ -30,6 +30,6 @@ SQL="SELECT t.relname::varchar AS table_name
 for TABLE in $(su - pe-postgres -s /bin/bash -c "/opt/puppetlabs/server/bin/psql -d pe-puppetdb -c \"$SQL\" --tuples-only")
 do
   #echo $TABLE
-  su - pe-postgres -s /bin/bash -c "/opt/puppetlabs/server/bin/vacuumdb -d pe-puppetdb -t $TABLE --full --verbose"
+  su - pe-postgres -s /bin/bash -c "/opt/puppetlabs/server/bin/vacuumdb -d pe-puppetdb -t $TABLE --full"
   sleep $SLEEP
 done

manifests/maintenance.pp

@@ -32,7 +32,7 @@
     weekday => [2,6],
     hour     => 4,
     minute   => 30,
-    command  => "${vacuum_script_path} facts > ${logging_directory}/facts_output.log 2>| tee ${logging_directory}/facts_error.log",
+    command  => "${vacuum_script_path} facts",
     require  => File[$logging_directory, $script_directory],
   }
 
@@ -42,7 +42,7 @@
     weekday  => [0,4],
     hour     => 4,
     minute   => 30,
-    command  => "${vacuum_script_path} catalogs > ${logging_directory}/catalogs_output.log 2>| tee ${logging_directory}/catalogs_error.log",
+    command  => "${vacuum_script_path} catalogs",
     require  => File[$logging_directory, $script_directory],
   }
 
@@ -52,7 +52,7 @@
     monthday => 20,
     hour     => 5,
     minute   => 30,
-    command  => "${vacuum_script_path} other > ${logging_directory}/other_output.log 2>| tee ${logging_directory}/other_error.log",
+    command  => "${vacuum_script_path} other",
     require  => File[$logging_directory, $script_directory],
   }