Make a defined type for setting table attributes

Prior to this commit, there was a psql command to change a table
attribute.  This was difficult when trying to point people to an
example that would allow them to do the same for a different table

After this commit, the psql command has been abstracted into a
defined type that makes it easier to set arbitrary table attributes.
A new defined type has been made for the specific case of setting
autovacuum_cost_delay=0

Author: npwalker

manifests/postgresql_settings.pp

@@ -93,13 +93,6 @@
   }
 
   if $manage_fact_values_autovacuum_cost_delay {
-    postgresql_psql { 'Set autovacuum_cost_delay=0 for fact_values' :
-      command    => 'ALTER TABLE fact_values SET ( autovacuum_vacuum_cost_delay = 0 )',
-      unless     => 'SELECT reloptions FROM pg_class WHERE relname = \'fact_values\' AND CAST(reloptions as text) LIKE \'%autovacuum_vacuum_cost_delay=0%\'',
-      db         => 'pe-puppetdb',
-      psql_user  => 'pe-postgres',
-      psql_group => 'pe-postgres',
-      psql_path  => '/opt/puppetlabs/server/bin/psql',
-    }
+    pe_databases::set_puppetdb_table_autovacuum_cost_delay_zero { 'fact_values' : }
   }
 }

manifests/set_puppetdb_table_autovacuum_cost_delay_zero.pp

@@ -0,0 +1,11 @@
+define pe_databases::set_puppetdb_table_autovacuum_cost_delay_zero (
+  String $table_name = $title,
+) {
+
+  pe_databases::set_table_attribute { "Set autovacuum_cost_delay=0 for ${table_name}" :
+    db                    => 'pe-puppetdb',
+    table_name            => $table_name,
+    table_attribute       => 'autovacuum_vacuum_cost_delay',
+    table_attribute_value => '0',
+  }
+}

manifests/set_table_attribute.pp

@@ -0,0 +1,16 @@
+define pe_databases::set_table_attribute (
+  String $db,
+  String $table_name,
+  String $table_attribute,
+  String $table_attribute_value,
+) {
+
+  postgresql_psql { "Set ${table_attribute}=${table_attribute_value} for ${table_name}" :
+      command    => "ALTER TABLE ${table_name} SET ( ${table_attribute} = 0 )",
+      unless     => "SELECT reloptions FROM pg_class WHERE relname = '${table_name}' AND CAST(reloptions as text) LIKE '%${table_attribute}=${table_attribute_value}%'",
+      db         => $db,
+      psql_user  => 'pe-postgres',
+      psql_group => 'pe-postgres',
+      psql_path  => '/opt/puppetlabs/server/bin/psql',
+    }
+}