Only ignore non-present fields if they're not required

Author: henryk

fints/parser.py

@@ -120,7 +120,8 @@ def parse_segment(self, segment):
             try:
                 val = next(data)
             except StopIteration:
-                pass
+                if field.required:
+                    raise ValueError("Required field {}.{} was not present".format(clazz.__name__, name))
             else:
                 deg = self.parse_n_deg(field, val)
                 setattr(seg, name, deg)

fints/segments/__init__.py

@@ -66,7 +66,7 @@ class HNVSK3(FinTS3Segment):
     encryption_algorithm = DataElementGroupField(type=EncryptionAlgorithm)
     key_name = DataElementGroupField(type=KeyName)
     compression_function = DataElementField(type='code', max_length=3)
-    certificate = DataElementGroupField(type=Certificate)
+    certificate = DataElementGroupField(type=Certificate, required=False)
 
 class HNSHK4(FinTS3Segment):
     security_profile = DataElementGroupField(type=SecurityProfile)
@@ -80,7 +80,7 @@ class HNSHK4(FinTS3Segment):
     hash_algorithm = DataElementGroupField(type=HashAlgorithm)
     signature_algorithm = DataElementGroupField(type=SignatureAlgorithm)
     key_name = DataElementGroupField(type=KeyName)
-    certificate = DataElementGroupField(type=Certificate)
+    certificate = DataElementGroupField(type=Certificate, required=False)
 
 
 

tests/test_message_parser.py

@@ -55,3 +55,8 @@ def test_invalid():
 
     with pytest.raises(ValueError):
         FinTS3Parser.explode_segments(message5)
+
+    message6 = rb"""HNHBS:5:1'"""
+    with pytest.raises(ValueError, match='^Required field'):
+        m = FinTS3Parser().parse_message(message6)
+