New Architecture Known Issues & Troubleshooting #237
Replies: 3 comments 10 replies
-
|
Can you please check this |
Beta Was this translation helpful? Give feedback.
-
|
Does this mean |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for the explanation! Is there documentation on how to make it work through the C++ layer? I'm playing around with the community RN slider package and I also see It's obvious that I'm misunderstanding something, so any clarifications would be very appreciated! |
Beta Was this translation helpful? Give feedback.
-
|
Also thank you for such a quick response! That is much appreciated!
Reading this, I thought that meant that if the Interop layer is on, then the measurements won't work. But if it's off, measuring would continue to work. I also thought the interop layer only turns on when a component does not support the new architecture. My intention is to create a component that only supports the new architecture, so the interop layer should be off. |
Beta Was this translation helpful? Give feedback.
-
|
I just found this PR that shows how the slider uses C++ to measure! |
Beta Was this translation helpful? Give feedback.
-
|
Since Fabric is the future, documentation on how to implement these shadow modes and measurements, and how to connect it with the library would be immensely helpful! I'm almost tempted to only use the old architecture for now because it's very difficult to determine what the right steps are. Regardless, this is all very exciting stuff! |
Beta Was this translation helpful? Give feedback.
-
|
Nope we don't have custom C++ documentation at the moment as that's sort of an advanced topic. Documentation is extremely costly to write and can get stale really easy so we focused on the most common scenarios first. As a remediation, you can check how the core components like We hope to have capacity to add further New Architecture documentation in the near future |
Beta Was this translation helpful? Give feedback.
-
|
Hi @cipolleschi and @cortinico, It has been quite a while since we've been trying to figure out the issue with redux-persist specially with persistStore. Interestingly, when we run the application in debug mode during development, we never encounter the issue. However, after providing the build to QA following the RN migration, we are experiencing crashes on iOS without any logs. Here is the store file that we are using in our application: import { configureStore } from '@reduxjs/toolkit'; import { Store } from 'redux'; let store: Store; const enhancers = (getDefaultEnhancers: any) => { export const generateStore = (secretKey: string | null) => { persistor = persistStore(store); => WE NOTICED A CRASH ON THIS LINE POST MULTIPLE TRIALS AND ERRORS. sagaMiddleware.run(rootSaga); return store; export { store, persistor }; Below are the package details that we are using related to redux and react native version: "dependencies": { "devDependencies": { We appreciate any support from the community to help fix this issue. |
Beta Was this translation helpful? Give feedback.
-
How are we supposed to help you without reproducers and logs? |
Beta Was this translation helpful? Give feedback.
-
|
Hi @cortinico Thanks for your response... Here is the stack trace, please check. libc++abi: terminating due to uncaught exception of type facebook::jsi::JSError: Exception in HostFunction: -[NSNull stringByTrimmingCharactersInSet:]: unrecognized selector sent to instance 0x20b71b910 Error: Exception in HostFunction: -[NSNull stringByTrimmingCharactersInSet:]: unrecognized selector sent to instance 0x20b71b910
|
Beta Was this translation helpful? Give feedback.
-
|
Here is stack trace from Crashlytics. |
Beta Was this translation helpful? Give feedback.
-
|
Can we get a reproducer by any chance? |
Beta Was this translation helpful? Give feedback.
-
tl;dr: This post collects all the known issues with related resolutions to help users migrate the the New Architecture
Hi all,
With React Native 0.76 approaching, we want to collect in a single place all the known issues and troubleshooting we collected from the previous months of experimentation with the New Architecture.
This is a living document and we’ll be updating this document as we get more bug reports. If you encounter any issues migrating to the New Architecture, please open a new issue using this template.
Modules Known Issues
Unable to use
Object.keyson NativeModulesAnswer: This is by design. We designed the TurboModule system with the goal of lazy loading, so we don’t have to load all the modules in memory when the app is launched. This should let your app start faster.
One of the trade-offs of this solution is that you cannot call
Object.keyson a native module right away, because not all the keys might be available immediately.Instead, you can read them by leveraging the inheritance. You can call
Object.keyson the native module prototype and the result should be the same as before.** [iOS] Cannot access
CallInvokerfromRCTCxxBridge.callInvokerAnswer: In bridgeless mode, the bridge is not initialized anymore. So, if you were retrieving the
jsCallInvokerinstance from the[RCTBridge currentBridge]invocation, that might not work well anymore.If you need this functionality, the best approach is to implement a pure C++ TurboModule which receives the callInvoker as a parameter when it is initialized.
This will also help you write more encapsulated code.
Components Known Issues
** Components with custom Shadow Nodes and measurement are not working with the Interop Layer.
Answer: This is by design because the New Architecture stores the shadow node and layout information in the C++ layer. If your custom component/library is providing a custom shadow node implementation you won’t be able to use it via the Interop Layer (this is a known limitation of the Interop Layer).
Specifically on Android, if your
ViewManagerclass is implementing any of those methods:createShadowNodeInstance()(reference)createShadowNodeInstance(ReactApplication)(reference)createShadowNodeClass()(reference)measure(Context,ReadableMap,ReadableMap,ReadableMap,float,YogaMeasureMode, float, YogaMeasureMode heightMode, float[])(reference)Your component won’t be working with the Interop Layer and will require an implementation with the new Renderer.
Beta Was this translation helpful? Give feedback.
All reactions