Skip to content

Commit 821d01a

Browse files
committed
refactor(benchpress): export webdriver adapters in benchpress/benchpress
Also adds default bindings for protractor. Also removes sync web driver adapter for Dart as we don’t have tests for it yet.
1 parent f783841 commit 821d01a

19 files changed

+25
-60
lines changed

Diff for: modules/benchpress/benchpress.dart

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
export './common.dart';
2+
export './src/webdriver/async_webdriver_adapter.dart' show AsyncWebDriverAdapter;

Diff for: modules/benchpress/benchpress.es6

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
export * from './common';
2+
export { SeleniumWebDriverAdapter } from './src/webdriver/selenium_webdriver_adapter';
File renamed without changes.

Diff for: modules/benchpress/src/webdriver/async_webdriver_adapter.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ class AsyncWebDriverAdapter extends WebDriverAdapter {
1616
return _driver.execute(script, const[]);
1717
}
1818

19-
Map capabilities() {
20-
return _driver.capabilities;
19+
Future<Map> capabilities() {
20+
return new Future.value(_driver.capabilities);
2121
}
2222

2323
Future<List<Map>> logs(String type) {

Diff for: modules/benchpress/src/webdriver/selenium_webdriver_adapter.es6

+7
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ import webdriver from 'selenium-webdriver';
88
* Adapter for the selenium-webdriver.
99
*/
1010
export class SeleniumWebDriverAdapter extends WebDriverAdapter {
11+
// TODO(tbosch): use static values when our transpiler supports them
12+
static get PROTRACTOR_BINDINGS() { return _PROTRACTOR_BINDINGS; }
13+
1114
_driver:any;
1215

1316
constructor(driver) {
@@ -59,3 +62,7 @@ function convertToLocalProcess(data) {
5962
}
6063
return JSON.parse(serialized);
6164
}
65+
66+
var _PROTRACTOR_BINDINGS = [
67+
bind(WebDriverAdapter).toFactory( () => new SeleniumWebDriverAdapter(global.browser), [])
68+
];

Diff for: modules/benchpress/src/webdriver/sync_webdriver_adapter.dart

-41
This file was deleted.

Diff for: modules/benchpress/test/metric/multi_metric_spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import {ddescribe, describe, it, iit, xit, expect, beforeEach, afterEach} from '
33
import { List, ListWrapper, StringMap } from 'angular2/src/facade/collection';
44
import { PromiseWrapper, Promise } from 'angular2/src/facade/async';
55

6-
import { Metric, MultiMetric, bind, Injector } from 'benchpress/benchpress';
6+
import { Metric, MultiMetric, bind, Injector } from 'benchpress/common';
77

88
export function main() {
99
function createMetric(ids) {

Diff for: modules/benchpress/test/metric/perflog_metric_spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import {ddescribe, describe, it, iit, xit, expect, beforeEach, afterEach} from '
33
import { List, ListWrapper } from 'angular2/src/facade/collection';
44
import { PromiseWrapper, Promise } from 'angular2/src/facade/async';
55

6-
import { Metric, PerflogMetric, WebDriverExtension, bind, Injector } from 'benchpress/benchpress';
6+
import { Metric, PerflogMetric, WebDriverExtension, bind, Injector } from 'benchpress/common';
77

88
import { TraceEventFactory } from '../trace_event_factory';
99

Diff for: modules/benchpress/test/reporter/console_reporter_spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { List, ListWrapper } from 'angular2/src/facade/collection';
66
import {
77
SampleState, Reporter, bind, Injector,
88
ConsoleReporter, SampleDescription, MeasureValues
9-
} from 'benchpress/benchpress';
9+
} from 'benchpress/common';
1010

1111
export function main() {
1212
describe('console reporter', () => {

Diff for: modules/benchpress/test/reporter/multi_reporter_spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { List, ListWrapper, StringMap } from 'angular2/src/facade/collection';
44
import { PromiseWrapper, Promise } from 'angular2/src/facade/async';
55
import { DateWrapper } from 'angular2/src/facade/lang';
66

7-
import { Reporter, MultiReporter, bind, Injector, MeasureValues } from 'benchpress/benchpress';
7+
import { Reporter, MultiReporter, bind, Injector, MeasureValues } from 'benchpress/common';
88

99
export function main() {
1010
function createReporters(ids) {

Diff for: modules/benchpress/test/runner_spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import {
33
Runner, Sampler, SampleDescription,
44
Validator, bind, Injector, Metric,
55
Options, WebDriverAdapter
6-
} from 'benchpress/benchpress';
6+
} from 'benchpress/common';
77
import { isBlank } from 'angular2/src/facade/lang';
88
import { Promise, PromiseWrapper } from 'angular2/src/facade/async';
99

Diff for: modules/benchpress/test/sampler_spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
Sampler, WebDriverAdapter, WebDriverExtension,
99
Validator, Metric, Reporter, Browser,
1010
bind, Injector, Options, MeasureValues
11-
} from 'benchpress/benchpress';
11+
} from 'benchpress/common';
1212

1313
export function main() {
1414
var EMPTY_EXECUTE = () => {};

Diff for: modules/benchpress/test/validator/regression_slope_validator_spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { ListWrapper } from 'angular2/src/facade/collection';
44

55
import {
66
Validator, RegressionSlopeValidator, Injector, bind, MeasureValues
7-
} from 'benchpress/benchpress';
7+
} from 'benchpress/common';
88

99
export function main() {
1010
describe('regression slope validator', () => {

Diff for: modules/benchpress/test/validator/size_validator_spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { ListWrapper } from 'angular2/src/facade/collection';
44

55
import {
66
Validator, SizeValidator, Injector, bind, MeasureValues
7-
} from 'benchpress/benchpress';
7+
} from 'benchpress/common';
88

99
export function main() {
1010
describe('size validator', () => {

Diff for: modules/benchpress/test/web_driver_extension_spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { StringMap, ListWrapper } from 'angular2/src/facade/collection';
44
import { isPresent, StringWrapper } from 'angular2/src/facade/lang';
55
import { PromiseWrapper } from 'angular2/src/facade/async';
66

7-
import { WebDriverExtension, bind, Injector, Options } from 'benchpress/benchpress';
7+
import { WebDriverExtension, bind, Injector, Options } from 'benchpress/common';
88

99
export function main() {
1010
function createExtension(ids, caps) {

Diff for: modules/benchpress/test/webdriver/chrome_driver_extension_spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { Json, isBlank } from 'angular2/src/facade/lang';
77
import {
88
WebDriverExtension, ChromeDriverExtension,
99
WebDriverAdapter, Injector, bind
10-
} from 'benchpress/benchpress';
10+
} from 'benchpress/common';
1111

1212
import { TraceEventFactory } from '../trace_event_factory';
1313

Diff for: modules/benchpress/test/webdriver/ios_driver_extension_spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { Json, isBlank, isPresent } from 'angular2/src/facade/lang';
77
import {
88
WebDriverExtension, IOsDriverExtension,
99
WebDriverAdapter, Injector, bind
10-
} from 'benchpress/benchpress';
10+
} from 'benchpress/common';
1111

1212
import { TraceEventFactory } from '../trace_event_factory';
1313

Diff for: modules/examples/test/benchpress/webdriver_async.server.spec.dart

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import 'dart:async';
22
import 'dart:io' show Platform;
33
import 'package:guinness/guinness.dart';
44
import 'package:benchpress/benchpress.dart';
5-
import 'package:benchpress/src/webdriver/async_webdriver_adapter.dart';
65
import 'package:webdriver/webdriver.dart' show WebDriver, Capabilities, LogType, LogLevel, By;
76

87
main() {

Diff for: protractor-shared.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,6 @@ var config = exports.config = {
169169
exports.createBenchpressRunner = function(options) {
170170
var nodeUuid = require('node-uuid');
171171
var benchpress = require('./dist/js/cjs/benchpress/benchpress');
172-
var SeleniumWebDriverAdapter =
173-
require('./dist/js/cjs/benchpress/src/webdriver/selenium_webdriver_adapter').SeleniumWebDriverAdapter;
174172

175173
// TODO(tbosch): add cloud reporter again (only when !options.test)
176174
// var cloudReporterConfig;
@@ -189,9 +187,7 @@ exports.createBenchpressRunner = function(options) {
189187
runId = process.env.GIT_SHA + ' ' + runId;
190188
}
191189
var bindings = [
192-
benchpress.bind(benchpress.WebDriverAdapter).toFactory(
193-
function() { return new SeleniumWebDriverAdapter(global.browser); }, []
194-
),
190+
benchpress.SeleniumWebDriverAdapter.PROTRACTOR_BINDINGS,
195191
benchpress.bind(benchpress.Options.FORCE_GC).toValue(argv['force-gc']),
196192
benchpress.bind(benchpress.Options.DEFAULT_DESCRIPTION).toValue({
197193
'lang': options.lang,

0 commit comments

Comments
 (0)