fix(platform-browser): remove testing_e2e target (angular#10029)

juliemr · web-flow · commit 4a965052f9a1 · 2016-07-13T10:10:02.000-07:00
The testing_e2e util does not belong in platform-browser and was never intended to be a public API. Move it out of that whole tree. BREAKING CHANGE: The following API was never intended to be public and is removed: ```js import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e'; ``` Consider using Protractor's console plugin: https://github.com/angular/protractor-console-plugin
diff --git a/gulpfile.js b/gulpfile.js
@@ -39,7 +39,6 @@ const entrypoints = [
   'dist/packages-dist/upgrade/index.d.ts',
   'dist/packages-dist/platform-browser/index.d.ts',
   'dist/packages-dist/platform-browser/testing.d.ts',
-  'dist/packages-dist/platform-browser/testing_e2e.d.ts',
   'dist/packages-dist/platform-browser-dynamic/index.d.ts',
   'dist/packages-dist/platform-browser-dynamic/testing.d.ts',
   'dist/packages-dist/platform-server/index.d.ts',
diff --git a/modules/@angular/examples/router_deprecated/ts/can_activate/can_activate_spec.ts b/modules/@angular/examples/router_deprecated/ts/can_activate/can_activate_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 function waitForElement(selector: string) {
   var EC = (<any>protractor).ExpectedConditions;
diff --git a/modules/@angular/examples/router_deprecated/ts/can_deactivate/can_deactivate_spec.ts b/modules/@angular/examples/router_deprecated/ts/can_deactivate/can_deactivate_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 function waitForElement(selector: string) {
   var EC = (<any>protractor).ExpectedConditions;
diff --git a/modules/@angular/examples/router_deprecated/ts/on_deactivate/on_deactivate_spec.ts b/modules/@angular/examples/router_deprecated/ts/on_deactivate/on_deactivate_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 function waitForElement(selector: string) {
   var EC = (<any>protractor).ExpectedConditions;
diff --git a/modules/@angular/examples/router_deprecated/ts/reuse/reuse_spec.ts b/modules/@angular/examples/router_deprecated/ts/reuse/reuse_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 function waitForElement(selector: string) {
   var EC = (<any>protractor).ExpectedConditions;
diff --git a/modules/@angular/platform-browser/testing_e2e.ts b/modules/@angular/platform-browser/testing_e2e.ts
diff --git a/modules/@angular/platform-browser/tsconfig-es2015.json b/modules/@angular/platform-browser/tsconfig-es2015.json
@@ -25,7 +25,6 @@
   "files": [
     "index.ts",
     "testing.ts",
-    "testing_e2e.ts",
     "../../../node_modules/@types/hammerjs/index.d.ts",
     "../../../node_modules/@types/jasmine/index.d.ts",
     "../../../node_modules/@types/protractor/index.d.ts",
diff --git a/modules/@angular/platform-browser/tsconfig-es5.json b/modules/@angular/platform-browser/tsconfig-es5.json
@@ -26,7 +26,6 @@
   "files": [
     "index.ts",
     "testing.ts",
-    "testing_e2e.ts",
     "../../../node_modules/@types/hammerjs/index.d.ts",
     "../../../node_modules/@types/jasmine/index.d.ts",
     "../../../node_modules/@types/protractor/index.d.ts",
diff --git a/modules/e2e_util/e2e_util.ts b/modules/e2e_util/e2e_util.ts
diff --git a/modules/e2e_util/perf_util.ts b/modules/e2e_util/perf_util.ts
diff --git a/modules/playground/e2e_test/async/async_spec.ts b/modules/playground/e2e_test/async/async_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 describe('async', () => {
   var URL = 'all/playground/src/async/index.html';
diff --git a/modules/playground/e2e_test/hash_routing/hash_location_spec.ts b/modules/playground/e2e_test/hash_routing/hash_location_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 function waitForElement(selector: any /** TODO #9100 */) {
   var EC = (<any>protractor).ExpectedConditions;
diff --git a/modules/playground/e2e_test/hello_world/hello_world_spec.ts b/modules/playground/e2e_test/hello_world/hello_world_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 describe('hello world', function() {
 
diff --git a/modules/playground/e2e_test/http/http_spec.ts b/modules/playground/e2e_test/http/http_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 describe('http', function() {
 
diff --git a/modules/playground/e2e_test/jsonp/jsonp_spec.ts b/modules/playground/e2e_test/jsonp/jsonp_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 describe('jsonp', function() {
 
diff --git a/modules/playground/e2e_test/key_events/key_events_spec.ts b/modules/playground/e2e_test/key_events/key_events_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing/e2e_util';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 describe('key_events', function() {
 
diff --git a/modules/playground/e2e_test/model_driven_forms/model_driven_forms_spec.ts b/modules/playground/e2e_test/model_driven_forms/model_driven_forms_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 describe('Model-Driven Forms', function() {
 
diff --git a/modules/playground/e2e_test/order_management/order_management_spec.ts b/modules/playground/e2e_test/order_management/order_management_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 describe('Order Management CRUD', function() {
   var URL = 'all/playground/src/order_management/index.html';
diff --git a/modules/playground/e2e_test/person_management/person_management_spec.ts b/modules/playground/e2e_test/person_management/person_management_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 describe('Person Management CRUD', function() {
   var URL = 'all/playground/src/person_management/index.html';
diff --git a/modules/playground/e2e_test/relative_assets/assets_spec.ts b/modules/playground/e2e_test/relative_assets/assets_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 function waitForElement(selector: any /** TODO #9100 */) {
   var EC = (<any>protractor).ExpectedConditions;
diff --git a/modules/playground/e2e_test/routing/routing_spec.ts b/modules/playground/e2e_test/routing/routing_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 function waitForElement(selector: any /** TODO #9100 */) {
   var EC = (<any>protractor).ExpectedConditions;
diff --git a/modules/playground/e2e_test/routing_deprecated/routing_deprecated_spec.ts b/modules/playground/e2e_test/routing_deprecated/routing_deprecated_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 function waitForElement(selector: any /** TODO #9100 */) {
   var EC = (<any>protractor).ExpectedConditions;
diff --git a/modules/playground/e2e_test/sourcemap/sourcemap_spec.ts b/modules/playground/e2e_test/sourcemap/sourcemap_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import * as testUtil from '@angular/platform-browser/testing_e2e';
+import * as testUtil from 'e2e_util/e2e_util';
 
 var fs = require('fs');
 var sourceMap = require('source-map');
diff --git a/modules/playground/e2e_test/svg/svg_spec.ts b/modules/playground/e2e_test/svg/svg_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 describe('SVG', function() {
 
diff --git a/modules/playground/e2e_test/template_driven_forms/template_driven_forms_spec.ts b/modules/playground/e2e_test/template_driven_forms/template_driven_forms_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 describe('Template-Driven Forms', function() {
 
diff --git a/modules/playground/e2e_test/upgrade/upgrade_spec.ts b/modules/playground/e2e_test/upgrade/upgrade_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from "@angular/platform-browser/testing_e2e";
+import {verifyNoBrowserErrors} from "e2e_util/e2e_util";
 
 // TODO(i): reenable once we fix issue with exposing testability to protractor when using ngUpgrade
 // https://github.com/angular/angular/issues/9407
diff --git a/modules/playground/e2e_test/web_workers/input/input_spec.ts b/modules/playground/e2e_test/web_workers/input/input_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 describe('WebWorkers Input', function() {
   afterEach(() => {
diff --git a/modules/playground/e2e_test/web_workers/kitchen_sink/kitchen_sink_spec.ts b/modules/playground/e2e_test/web_workers/kitchen_sink/kitchen_sink_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 describe('WebWorkers Kitchen Sink', function() {
   afterEach(() => {
diff --git a/modules/playground/e2e_test/web_workers/message_broker/message_broker_spec.ts b/modules/playground/e2e_test/web_workers/message_broker/message_broker_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 var URL = 'all/playground/src/web_workers/message_broker/index.html';
 
diff --git a/modules/playground/e2e_test/web_workers/router/router_spec.ts b/modules/playground/e2e_test/web_workers/router/router_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 describe("WebWorker Router", () => {
   beforeEach(() => {
diff --git a/modules/playground/e2e_test/web_workers/todo/todo_spec.ts b/modules/playground/e2e_test/web_workers/todo/todo_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 describe('WebWorkers Todo', function() {
   afterEach(() => {
diff --git a/modules/playground/e2e_test/zippy_component/zippy_spec.ts b/modules/playground/e2e_test/zippy_component/zippy_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {verifyNoBrowserErrors} from '@angular/platform-browser/testing_e2e';
+import {verifyNoBrowserErrors} from 'e2e_util/e2e_util';
 
 describe('Zippy Component', function() {
 
diff --git a/tools/public_api_guard/platform-browser/testing_e2e.d.ts b/tools/public_api_guard/platform-browser/testing_e2e.d.ts
