Skip to content

Commit 211bdb0

Browse files
authored
Merge pull request RustPython#4453 from yt2b/fix_error_message
Fix error message
2 parents c3709e8 + e4102aa commit 211bdb0

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

Lib/test/test_float.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,6 @@ def test_float_memoryview(self):
128128
self.assertEqual(float(memoryview(b'12.3A')[1:4]), 2.3)
129129
self.assertEqual(float(memoryview(b'12.34')[1:4]), 2.3)
130130

131-
# TODO: RUSTPYTHON
132-
@unittest.expectedFailure
133131
def test_error_message(self):
134132
def check(s):
135133
with self.assertRaises(ValueError, msg='float(%r)' % (s,)) as cm:

vm/src/builtins/float.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ fn float_from_string(val: PyObjectRef, vm: &VirtualMachine) -> PyResult<f64> {
180180
};
181181
float_ops::parse_bytes(b).ok_or_else(|| {
182182
val.repr(vm)
183-
.map(|repr| vm.new_value_error(format!("could not convert string to float: '{repr}'")))
183+
.map(|repr| vm.new_value_error(format!("could not convert string to float: {repr}")))
184184
.unwrap_or_else(|e| e)
185185
})
186186
}

0 commit comments

Comments
 (0)