Skip to content

Commit 75390dd

Browse files
committed
Fix test.support imports
1 parent 92ab0a4 commit 75390dd

12 files changed

+112
-96
lines changed

Lib/test/ssl_servers.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@
99
SimpleHTTPRequestHandler, BaseHTTPRequestHandler)
1010

1111
from test import support
12+
from test.support import socket_helper
1213

1314
here = os.path.dirname(__file__)
1415

15-
HOST = support.HOST
16+
HOST = socket_helper.HOST
1617
CERTFILE = os.path.join(here, 'keycert.pem')
1718

1819
# This one's based on HTTPServer, which is based on socketserver
@@ -49,7 +50,7 @@ class RootedHTTPRequestHandler(SimpleHTTPRequestHandler):
4950
server_version = "TestHTTPS/1.0"
5051
root = here
5152
# Avoid hanging when a request gets interrupted by the client
52-
timeout = 5
53+
timeout = support.LOOPBACK_TIMEOUT
5354

5455
def translate_path(self, path):
5556
"""Translate a /-separated PATH to the local filename syntax.

Lib/test/test_asynchat.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# test asynchat
22

33
from test import support
4+
from test.support import socket_helper
5+
46

57
import asynchat
68
import asyncore
@@ -12,7 +14,7 @@
1214
import unittest
1315
import unittest.mock
1416

15-
HOST = support.HOST
17+
HOST = socket_helper.HOST
1618
SERVER_QUIT = b'QUIT\n'
1719
TIMEOUT = 3.0
1820

@@ -26,7 +28,7 @@ def __init__(self, event):
2628
threading.Thread.__init__(self)
2729
self.event = event
2830
self.sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
29-
self.port = support.bind_port(self.sock)
31+
self.port = socket_helper.bind_port(self.sock)
3032
# This will be set if the client wants us to wait before echoing
3133
# data back.
3234
self.start_resend_event = None

Lib/test/test_asyncore.py

+7-6
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
from test import support
1313
from test.support import os_helper
14+
from test.support import socket_helper
1415
from io import BytesIO
1516

1617
if support.PGO:
@@ -93,7 +94,7 @@ def bind_af_aware(sock, addr):
9394
if HAS_UNIX_SOCKETS and sock.family == socket.AF_UNIX:
9495
# Make sure the path doesn't exist.
9596
os_helper.unlink(addr)
96-
support.bind_unix_socket(sock, addr)
97+
socket_helper.bind_unix_socket(sock, addr)
9798
else:
9899
sock.bind(addr)
99100

@@ -329,7 +330,7 @@ def test_send(self):
329330
evt = threading.Event()
330331
sock = socket.socket()
331332
sock.settimeout(3)
332-
port = support.bind_port(sock)
333+
port = socket_helper.bind_port(sock)
333334

334335
cap = BytesIO()
335336
args = (evt, cap, sock)
@@ -343,7 +344,7 @@ def test_send(self):
343344
data = b"Suppose there isn't a 16-ton weight?"
344345
d = dispatcherwithsend_noread()
345346
d.create_socket()
346-
d.connect((support.HOST, port))
347+
d.connect((socket_helper.HOST, port))
347348

348349
# give time for socket to connect
349350
time.sleep(0.1)
@@ -793,12 +794,12 @@ def test_quick_connect(self):
793794

794795
class TestAPI_UseIPv4Sockets(BaseTestAPI):
795796
family = socket.AF_INET
796-
addr = (support.HOST, 0)
797+
addr = (socket_helper.HOST, 0)
797798

798-
@unittest.skipUnless(support.IPV6_ENABLED, 'IPv6 support required')
799+
@unittest.skipUnless(socket_helper.IPV6_ENABLED, 'IPv6 support required')
799800
class TestAPI_UseIPv6Sockets(BaseTestAPI):
800801
family = socket.AF_INET6
801-
addr = (support.HOSTv6, 0)
802+
addr = (socket_helper.HOSTv6, 0)
802803

803804
@unittest.skipUnless(HAS_UNIX_SOCKETS, 'Unix sockets required')
804805
class TestAPI_UseUnixSockets(BaseTestAPI):

Lib/test/test_ftplib.py

+8-6
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,17 @@
2020

2121
from unittest import TestCase, skipUnless
2222
from test import support
23-
from test.support import HOST, HOSTv6
23+
from test.support import socket_helper
24+
from test.support.socket_helper import HOST, HOSTv6
2425

2526
import sys
2627
if sys.platform == 'win32':
2728
raise unittest.SkipTest("test_ftplib not working on windows")
2829
if getattr(sys, '_rustpython_debugbuild', False):
2930
raise unittest.SkipTest("something's weird on debug builds")
3031

31-
TIMEOUT = 3
32+
33+
TIMEOUT = support.LOOPBACK_TIMEOUT
3234
# the dummy data returned by server over the data channel when
3335
# RETR, LIST, NLST, MLSD commands are issued
3436
RETR_DATA = 'abcde12345\r\n' * 1000
@@ -750,7 +752,7 @@ def is_client_connected():
750752

751753
def test_source_address(self):
752754
self.client.quit()
753-
port = support.find_unused_port()
755+
port = socket_helper.find_unused_port()
754756
try:
755757
self.client.connect(self.server.host, self.server.port,
756758
source_address=(HOST, port))
@@ -762,7 +764,7 @@ def test_source_address(self):
762764
raise
763765

764766
def test_source_address_passive_connection(self):
765-
port = support.find_unused_port()
767+
port = socket_helper.find_unused_port()
766768
self.client.source_address = (HOST, port)
767769
try:
768770
with self.client.transfercmd('list') as sock:
@@ -799,7 +801,7 @@ def test_storlines_too_long(self):
799801
self.assertRaises(ftplib.Error, self.client.storlines, 'stor', f)
800802

801803

802-
@skipUnless(support.IPV6_ENABLED, "IPv6 not enabled")
804+
@skipUnless(socket_helper.IPV6_ENABLED, "IPv6 not enabled")
803805
class TestIPv6Environment(TestCase):
804806

805807
def setUp(self):
@@ -987,7 +989,7 @@ def setUp(self):
987989
self.evt = threading.Event()
988990
self.sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
989991
self.sock.settimeout(20)
990-
self.port = support.bind_port(self.sock)
992+
self.port = socket_helper.bind_port(self.sock)
991993
self.server_thread = threading.Thread(target=self.server)
992994
self.server_thread.daemon = True
993995
self.server_thread.start()

Lib/test/test_httplib.py

+10-9
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
from test import support
1616
from test.support import os_helper
17+
from test.support import socket_helper
1718

1819
here = os.path.dirname(__file__)
1920
# Self-signed cert file for 'localhost'
@@ -43,7 +44,7 @@
4344
trailers = "X-Dummy: foo\r\nX-Dumm2: bar\r\n"
4445
chunked_end = "\r\n"
4546

46-
HOST = support.HOST
47+
HOST = socket_helper.HOST
4748

4849
class FakeSocket:
4950
def __init__(self, text, fileclass=io.BytesIO, host=None, port=None):
@@ -1499,8 +1500,8 @@ def test_client_constants(self):
14991500
class SourceAddressTest(TestCase):
15001501
def setUp(self):
15011502
self.serv = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
1502-
self.port = support.bind_port(self.serv)
1503-
self.source_port = support.find_unused_port()
1503+
self.port = socket_helper.bind_port(self.serv)
1504+
self.source_port = socket_helper.find_unused_port()
15041505
self.serv.listen()
15051506
self.conn = None
15061507

@@ -1532,7 +1533,7 @@ class TimeoutTest(TestCase):
15321533

15331534
def setUp(self):
15341535
self.serv = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
1535-
TimeoutTest.PORT = support.bind_port(self.serv)
1536+
TimeoutTest.PORT = socket_helper.bind_port(self.serv)
15361537
self.serv.listen()
15371538

15381539
def tearDown(self):
@@ -1665,7 +1666,7 @@ def test_networked(self):
16651666
# Default settings: requires a valid cert from a trusted CA
16661667
import ssl
16671668
support.requires('network')
1668-
with support.transient_internet('self-signed.pythontest.net'):
1669+
with socket_helper.transient_internet('self-signed.pythontest.net'):
16691670
h = client.HTTPSConnection('self-signed.pythontest.net', 443)
16701671
with self.assertRaises(ssl.SSLError) as exc_info:
16711672
h.request('GET', '/')
@@ -1675,7 +1676,7 @@ def test_networked_noverification(self):
16751676
# Switch off cert verification
16761677
import ssl
16771678
support.requires('network')
1678-
with support.transient_internet('self-signed.pythontest.net'):
1679+
with socket_helper.transient_internet('self-signed.pythontest.net'):
16791680
context = ssl._create_unverified_context()
16801681
h = client.HTTPSConnection('self-signed.pythontest.net', 443,
16811682
context=context)
@@ -1689,7 +1690,7 @@ def test_networked_noverification(self):
16891690
def test_networked_trusted_by_default_cert(self):
16901691
# Default settings: requires a valid cert from a trusted CA
16911692
support.requires('network')
1692-
with support.transient_internet('www.python.org'):
1693+
with socket_helper.transient_internet('www.python.org'):
16931694
h = client.HTTPSConnection('www.python.org', 443)
16941695
h.request('GET', '/')
16951696
resp = h.getresponse()
@@ -1703,7 +1704,7 @@ def test_networked_good_cert(self):
17031704
import ssl
17041705
support.requires('network')
17051706
selfsigned_pythontestdotnet = 'self-signed.pythontest.net'
1706-
with support.transient_internet(selfsigned_pythontestdotnet):
1707+
with socket_helper.transient_internet(selfsigned_pythontestdotnet):
17071708
context = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT)
17081709
self.assertEqual(context.verify_mode, ssl.CERT_REQUIRED)
17091710
self.assertEqual(context.check_hostname, True)
@@ -1735,7 +1736,7 @@ def test_networked_bad_cert(self):
17351736
# We feed a "CA" cert that is unrelated to the server's cert
17361737
import ssl
17371738
support.requires('network')
1738-
with support.transient_internet('self-signed.pythontest.net'):
1739+
with socket_helper.transient_internet('self-signed.pythontest.net'):
17391740
context = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT)
17401741
context.load_verify_locations(CERT_localhost)
17411742
h = client.HTTPSConnection('self-signed.pythontest.net', 443, context=context)

Lib/test/test_os.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@
3333
from test import support
3434
from test.support import import_helper
3535
from test.support import os_helper
36+
from test.support import socket_helper
3637
# TODO: RUSTPYTHON
37-
# from test.support import socket_helper
3838
# from test.support import threading_helper
3939
# from test.support import warnings_helper
4040
from platform import win32_is_iot
@@ -3352,7 +3352,7 @@ def tearDownClass(cls):
33523352
os_helper.unlink(os_helper.TESTFN)
33533353

33543354
def setUp(self):
3355-
self.server = SendfileTestServer((support.HOST, 0))
3355+
self.server = SendfileTestServer((socket_helper.HOST, 0))
33563356
self.server.start()
33573357
self.client = socket.socket()
33583358
self.client.connect((self.server.host, self.server.port))

Lib/test/test_robotparser.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import unittest
55
import urllib.robotparser
66
from test import support
7+
from test.support import socket_helper
78
from http.server import BaseHTTPRequestHandler, HTTPServer
89

910

@@ -309,7 +310,7 @@ def log_message(self, format, *args):
309310
class PasswordProtectedSiteTestCase(unittest.TestCase):
310311

311312
def setUp(self):
312-
self.server = HTTPServer((support.HOST, 0), RobotHandler)
313+
self.server = HTTPServer((socket_helper.HOST, 0), RobotHandler)
313314

314315
self.t = threading.Thread(
315316
name='HTTPServer serving',
@@ -329,7 +330,7 @@ def tearDown(self):
329330
@support.reap_threads
330331
def testPasswordProtectedSite(self):
331332
addr = self.server.server_address
332-
url = 'http://' + support.HOST + ':' + str(addr[1])
333+
url = 'http://' + socket_helper.HOST + ':' + str(addr[1])
333334
robots_url = url + "/robots.txt"
334335
parser = urllib.robotparser.RobotFileParser()
335336
parser.set_url(url)
@@ -345,7 +346,7 @@ class NetworkTestCase(unittest.TestCase):
345346
@classmethod
346347
def setUpClass(cls):
347348
support.requires('network')
348-
with support.transient_internet(cls.base_url):
349+
with socket_helper.transient_internet(cls.base_url):
349350
cls.parser = urllib.robotparser.RobotFileParser(cls.robots_txt)
350351
cls.parser.read()
351352

0 commit comments

Comments
 (0)