Skip to content

Commit 105da76

Browse files
committed
fix!: Rename Snippet to Message
1 parent bbf9c5f commit 105da76

23 files changed

+100
-100
lines changed

benches/simple.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ extern crate criterion;
44

55
use criterion::{black_box, Criterion};
66

7-
use annotate_snippets::{Label, Renderer, Slice, Snippet};
7+
use annotate_snippets::{Label, Message, Renderer, Slice};
88

99
fn create_snippet(renderer: Renderer) {
1010
let source = r#") -> Option<String> {
@@ -29,7 +29,7 @@ fn create_snippet(renderer: Renderer) {
2929
_ => continue,
3030
}
3131
}"#;
32-
let snippet = Snippet::error("mismatched types").id("E0308").slice(
32+
let message = Message::error("mismatched types").id("E0308").slice(
3333
Slice::new(source, 51)
3434
.origin("src/format.rs")
3535
.annotation(
@@ -38,7 +38,7 @@ fn create_snippet(renderer: Renderer) {
3838
.annotation(Label::error("expected enum `std::option::Option`").span(26..724)),
3939
);
4040

41-
let _result = renderer.render(snippet).to_string();
41+
let _result = renderer.render(message).to_string();
4242
}
4343

4444
pub fn criterion_benchmark(c: &mut Criterion) {

examples/expected_type.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
use annotate_snippets::{Label, Renderer, Slice, Snippet};
1+
use annotate_snippets::{Label, Message, Renderer, Slice};
22

33
fn main() {
44
let source = r#" annotations: vec![SourceAnnotation {
55
label: "expected struct `annotate_snippets::snippet::Slice`, found reference"
66
,
77
range: <22, 25>,"#;
8-
let snippet = Snippet::error("expected type, found `22`").slice(
8+
let message = Message::error("expected type, found `22`").slice(
99
Slice::new(source, 26)
1010
.origin("examples/footer.rs")
1111
.fold(true)
@@ -19,5 +19,5 @@ fn main() {
1919
);
2020

2121
let renderer = Renderer::styled();
22-
anstream::println!("{}", renderer.render(snippet));
22+
anstream::println!("{}", renderer.render(message));
2323
}

examples/footer.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
use annotate_snippets::{Label, Renderer, Slice, Snippet};
1+
use annotate_snippets::{Label, Message, Renderer, Slice};
22

33
fn main() {
4-
let snippet = Snippet::error("mismatched types")
4+
let message = Message::error("mismatched types")
55
.id("E0308")
66
.slice(
77
Slice::new(" slices: vec![\"A\",", 13)
@@ -18,5 +18,5 @@ fn main() {
1818
));
1919

2020
let renderer = Renderer::styled();
21-
anstream::println!("{}", renderer.render(snippet));
21+
anstream::println!("{}", renderer.render(message));
2222
}

examples/format.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use annotate_snippets::{Label, Renderer, Slice, Snippet};
1+
use annotate_snippets::{Label, Message, Renderer, Slice};
22

33
fn main() {
44
let source = r#") -> Option<String> {
@@ -23,7 +23,7 @@ fn main() {
2323
_ => continue,
2424
}
2525
}"#;
26-
let snippet = Snippet::error("mismatched types").id("E0308").slice(
26+
let message = Message::error("mismatched types").id("E0308").slice(
2727
Slice::new(source, 51)
2828
.origin("src/format.rs")
2929
.annotation(
@@ -33,5 +33,5 @@ fn main() {
3333
);
3434

3535
let renderer = Renderer::styled();
36-
anstream::println!("{}", renderer.render(snippet));
36+
anstream::println!("{}", renderer.render(message));
3737
}

examples/multislice.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
use annotate_snippets::{Renderer, Slice, Snippet};
1+
use annotate_snippets::{Message, Renderer, Slice};
22

33
fn main() {
4-
let snippet = Snippet::error("mismatched types")
4+
let message = Message::error("mismatched types")
55
.slice(Slice::new("Foo", 51).origin("src/format.rs"))
66
.slice(Slice::new("Faa", 129).origin("src/display.rs"));
77

88
let renderer = Renderer::styled();
9-
anstream::println!("{}", renderer.render(snippet));
9+
anstream::println!("{}", renderer.render(message));
1010
}

src/lib.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@
1616
//! The crate uses a three stage process with two conversions between states:
1717
//!
1818
//! ```text
19-
//! Snippet --> Renderer --> impl Display
19+
//! Message --> Renderer --> impl Display
2020
//! ```
2121
//!
22-
//! The input type - [Snippet] is a structure designed
22+
//! The input type - [Message] is a structure designed
2323
//! to align with likely output from any parser whose code snippet is to be
2424
//! annotated.
2525
//!

src/renderer/display_list.rs

+9-9
Original file line numberDiff line numberDiff line change
@@ -106,12 +106,12 @@ impl<'a> DisplayList<'a> {
106106
const WARNING_TXT: &'static str = "warning";
107107

108108
pub(crate) fn new(
109-
snippet::Snippet {
109+
snippet::Message {
110110
title,
111111
id,
112112
footer,
113113
slices,
114-
}: snippet::Snippet<'a>,
114+
}: snippet::Message<'a>,
115115
stylesheet: &'a Stylesheet,
116116
anonymized_line_numbers: bool,
117117
margin: Option<Margin>,
@@ -1206,7 +1206,7 @@ mod tests {
12061206

12071207
#[test]
12081208
fn test_format_title() {
1209-
let input = snippet::Snippet::error("This is a title").id("E0001");
1209+
let input = snippet::Message::error("This is a title").id("E0001");
12101210
let output = from_display_lines(vec![DisplayLine::Raw(DisplayRawLine::Annotation {
12111211
annotation: Annotation {
12121212
annotation_type: DisplayAnnotationType::Error,
@@ -1227,7 +1227,7 @@ mod tests {
12271227
let line_1 = "This is line 1";
12281228
let line_2 = "This is line 2";
12291229
let source = [line_1, line_2].join("\n");
1230-
let input = snippet::Snippet::error("").slice(snippet::Slice::new(&source, 5402));
1230+
let input = snippet::Message::error("").slice(snippet::Slice::new(&source, 5402));
12311231
let output = from_display_lines(vec![
12321232
DisplayLine::Raw(DisplayRawLine::Annotation {
12331233
annotation: Annotation {
@@ -1277,7 +1277,7 @@ mod tests {
12771277
let src_0_len = src_0.len();
12781278
let src_1 = "This is slice 2";
12791279
let src_1_len = src_1.len();
1280-
let input = snippet::Snippet::error("")
1280+
let input = snippet::Message::error("")
12811281
.slice(snippet::Slice::new(src_0, 5402).origin("file1.rs"))
12821282
.slice(snippet::Slice::new(src_1, 2).origin("file2.rs"));
12831283
let output = from_display_lines(vec![
@@ -1350,7 +1350,7 @@ mod tests {
13501350
let source = [line_1, line_2].join("\n");
13511351
// In line 2
13521352
let range = 22..24;
1353-
let input = snippet::Snippet::error("").slice(
1353+
let input = snippet::Message::error("").slice(
13541354
snippet::Slice::new(&source, 5402)
13551355
.annotation(snippet::Label::info("Test annotation").span(range.clone())),
13561356
);
@@ -1420,7 +1420,7 @@ mod tests {
14201420
#[test]
14211421
fn test_format_label() {
14221422
let input =
1423-
snippet::Snippet::error("").footer(snippet::Label::error("This __is__ a title"));
1423+
snippet::Message::error("").footer(snippet::Label::error("This __is__ a title"));
14241424
let output = from_display_lines(vec![
14251425
DisplayLine::Raw(DisplayRawLine::Annotation {
14261426
annotation: Annotation {
@@ -1455,7 +1455,7 @@ mod tests {
14551455
fn test_i26() {
14561456
let source = "short";
14571457
let label = "label";
1458-
let input = snippet::Snippet::error("").slice(
1458+
let input = snippet::Message::error("").slice(
14591459
snippet::Slice::new(source, 0)
14601460
.annotation(snippet::Label::error(label).span(0..source.len() + 2)),
14611461
);
@@ -1464,7 +1464,7 @@ mod tests {
14641464

14651465
#[test]
14661466
fn test_i_29() {
1467-
let snippets = snippet::Snippet::error("oops").slice(
1467+
let snippets = snippet::Message::error("oops").slice(
14681468
snippet::Slice::new("First line\r\nSecond oops line", 1)
14691469
.origin("<current file>")
14701470
.fold(true)

src/renderer/mod.rs

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
//! The renderer for [`Snippet`]s
1+
//! The renderer for [`Message`]s
22
//!
33
//! # Example
44
//! ```
5-
//! use annotate_snippets::{Renderer, Slice, Snippet};
6-
//! let snippet = Snippet::error("mismatched types")
5+
//! use annotate_snippets::{Renderer, Slice, Message};
6+
//! let snippet = Message::error("mismatched types")
77
//! .slice(Slice::new("Foo", 51).origin("src/format.rs"))
88
//! .slice(Slice::new("Faa", 129).origin("src/display.rs"));
99
//!
@@ -14,14 +14,14 @@ mod display_list;
1414
mod margin;
1515
pub(crate) mod stylesheet;
1616

17-
use crate::snippet::Snippet;
17+
use crate::snippet::Message;
1818
pub use anstyle::*;
1919
use display_list::DisplayList;
2020
pub use margin::Margin;
2121
use std::fmt::Display;
2222
use stylesheet::Stylesheet;
2323

24-
/// A renderer for [`Snippet`]s
24+
/// A renderer for [`Message`]s
2525
#[derive(Clone)]
2626
pub struct Renderer {
2727
anonymized_line_numbers: bool,
@@ -165,9 +165,9 @@ impl Renderer {
165165
}
166166

167167
/// Render a snippet into a `Display`able object
168-
pub fn render<'a>(&'a self, snippet: Snippet<'a>) -> impl Display + 'a {
168+
pub fn render<'a>(&'a self, msg: Message<'a>) -> impl Display + 'a {
169169
DisplayList::new(
170-
snippet,
170+
msg,
171171
&self.stylesheet,
172172
self.anonymized_line_numbers,
173173
self.margin,

src/snippet.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,22 @@
55
//! ```
66
//! use annotate_snippets::*;
77
//!
8-
//! Snippet::error("mismatched types")
8+
//! Message::error("mismatched types")
99
//! .slice(Slice::new("Foo", 51).origin("src/format.rs"))
1010
//! .slice(Slice::new("Faa", 129).origin("src/display.rs"));
1111
//! ```
1212
1313
use std::ops::Range;
1414

1515
/// Primary structure provided for formatting
16-
pub struct Snippet<'a> {
16+
pub struct Message<'a> {
1717
pub(crate) title: Label<'a>,
1818
pub(crate) id: Option<&'a str>,
1919
pub(crate) slices: Vec<Slice<'a>>,
2020
pub(crate) footer: Vec<Label<'a>>,
2121
}
2222

23-
impl<'a> Snippet<'a> {
23+
impl<'a> Message<'a> {
2424
pub fn title(title: Label<'a>) -> Self {
2525
Self {
2626
title,

tests/fixtures/deserialize.rs

+13-13
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
use serde::{Deserialize, Deserializer, Serialize};
22
use std::ops::Range;
33

4-
use annotate_snippets::{renderer::Margin, Annotation, Label, Level, Renderer, Slice, Snippet};
4+
use annotate_snippets::{renderer::Margin, Annotation, Label, Level, Message, Renderer, Slice};
55

66
#[derive(Deserialize)]
77
pub struct Fixture<'a> {
88
#[serde(default)]
99
pub renderer: RendererDef,
1010
#[serde(borrow)]
11-
pub snippet: SnippetDef<'a>,
11+
pub message: MessageDef<'a>,
1212
}
1313

1414
#[derive(Deserialize)]
15-
pub struct SnippetDef<'a> {
15+
pub struct MessageDef<'a> {
1616
#[serde(deserialize_with = "deserialize_label")]
1717
#[serde(borrow)]
1818
pub title: Label<'a>,
@@ -28,25 +28,25 @@ pub struct SnippetDef<'a> {
2828
pub slices: Vec<Slice<'a>>,
2929
}
3030

31-
impl<'a> From<SnippetDef<'a>> for Snippet<'a> {
32-
fn from(val: SnippetDef<'a>) -> Self {
33-
let SnippetDef {
31+
impl<'a> From<MessageDef<'a>> for Message<'a> {
32+
fn from(val: MessageDef<'a>) -> Self {
33+
let MessageDef {
3434
title,
3535
id,
3636
footer,
3737
slices,
3838
} = val;
39-
let mut snippet = Snippet::title(title);
39+
let mut message = Message::title(title);
4040
if let Some(id) = id {
41-
snippet = snippet.id(id);
41+
message = message.id(id);
4242
}
43-
snippet = slices
43+
message = slices
4444
.into_iter()
45-
.fold(snippet, |snippet, slice| snippet.slice(slice));
46-
snippet = footer
45+
.fold(message, |message, slice| message.slice(slice));
46+
message = footer
4747
.into_iter()
48-
.fold(snippet, |snippet, label| snippet.footer(label));
49-
snippet
48+
.fold(message, |message, label| message.footer(label));
49+
message
5050
}
5151
}
5252

tests/fixtures/main.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
mod deserialize;
22

33
use crate::deserialize::Fixture;
4-
use annotate_snippets::{Renderer, Snippet};
4+
use annotate_snippets::{Message, Renderer};
55
use snapbox::data::DataFormat;
66
use snapbox::Data;
77
use std::error::Error;
@@ -26,8 +26,8 @@ fn setup(input_path: std::path::PathBuf) -> snapbox::harness::Case {
2626

2727
fn test(input_path: &std::path::Path) -> Result<Data, Box<dyn Error>> {
2828
let src = std::fs::read_to_string(input_path)?;
29-
let (renderer, snippet): (Renderer, Snippet<'_>) =
30-
toml::from_str(&src).map(|a: Fixture| (a.renderer.into(), a.snippet.into()))?;
31-
let actual = renderer.render(snippet).to_string();
29+
let (renderer, message): (Renderer, Message<'_>) =
30+
toml::from_str(&src).map(|a: Fixture| (a.renderer.into(), a.message.into()))?;
31+
let actual = renderer.render(message).to_string();
3232
Ok(Data::from(actual).coerce_to(DataFormat::TermSvg))
3333
}

tests/fixtures/no-color/issue_52.toml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
[snippet.title]
1+
[message.title]
22
level = "Error"
33
label = ""
44

5-
[[snippet.slices]]
5+
[[message.slices]]
66
source = """
77
88
@@ -11,7 +11,7 @@ invalid syntax
1111
line_start = 1
1212
origin = "path/to/error.rs"
1313
fold = true
14-
[[snippet.slices.annotations]]
14+
[[message.slices.annotations]]
1515
label = "error here"
1616
level = "Warning"
1717
range = [2,16]

tests/fixtures/no-color/issue_9.toml

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,28 @@
1-
[snippet.title]
1+
[message.title]
22
label = "expected one of `.`, `;`, `?`, or an operator, found `for`"
33
level = "Error"
44

5-
[[snippet.slices]]
5+
[[message.slices]]
66
source = "let x = vec![1];"
77
line_start = 4
88
origin = "/code/rust/src/test/ui/annotate-snippet/suggestion.rs"
9-
[[snippet.slices.annotations]]
9+
[[message.slices.annotations]]
1010
label = "move occurs because `x` has type `std::vec::Vec<i32>`, which does not implement the `Copy` trait"
1111
level = "Warning"
1212
range = [4, 5]
1313

14-
[[snippet.slices]]
14+
[[message.slices]]
1515
source = "let y = x;"
1616
line_start = 7
17-
[[snippet.slices.annotations]]
17+
[[message.slices.annotations]]
1818
label = "value moved here"
1919
level = "Warning"
2020
range = [8, 9]
2121

22-
[[snippet.slices]]
22+
[[message.slices]]
2323
source = "x;"
2424
line_start = 9
25-
[[snippet.slices.annotations]]
25+
[[message.slices.annotations]]
2626
label = "value used here after move"
2727
level = "Error"
2828
range = [0, 1]

0 commit comments

Comments
 (0)