Skip to content

Renderer::line_no is a confusing name #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
epage opened this issue Jan 9, 2025 · 1 comment · Fixed by #198
Closed

Renderer::line_no is a confusing name #175

epage opened this issue Jan 9, 2025 · 1 comment · Fixed by #198
Labels
C-bug Category: bug M-breaking-change Meta: Implementing or merging this will introduce a breaking change

Comments

@epage
Copy link
Contributor

epage commented Jan 9, 2025

What is no, nomber?

Is line_num / line_number the best name? I feel like this is the gutter style but its also used for .... Unsure what to call that.

We should probably change this to something else. If we want, we can smooth out the upgrade path by offering the name in a current version, deprecating the old name, and then removing the old name in a new version.

@epage epage added C-bug Category: bug M-breaking-change Meta: Implementing or merging this will introduce a breaking change labels Jan 9, 2025
@DaniPopes
Copy link

😄 It stands for numero (N°) but yes num or number is a better name in general

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug M-breaking-change Meta: Implementing or merging this will introduce a breaking change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants