Print infix operations in infix form #22854
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbovel
commented
Mar 21, 2025
mbovel
force-pushed
the
mb/print-infix-ops
branch
from
c216dd2 to
2feab11
Compare
bishabosha
reviewed
Mar 22, 2025
| val v2: Int = 1 + (2 + 3) | ||
| val v3: Int = 1 + 2 * 3 | ||
| val v4: Int = (1 + 2) * 3 | ||
| val v5: Int = 1 + 2:Int |
There was a problem hiding this comment.
aren't the parentheses important to preserve here? (1 + 2):Int
There was a problem hiding this comment.
No, because + has a higher precedence than :, so 1 + 2 : Int is the same as (1 + 2) : Int:
ValDef(v5, TypeTree(),
Typed(Apply(Select(Literal(1), +), List(Literal(2))), Ident(Int))),
ValDef(v6, TypeTree(),
Typed(Apply(Select(Literal(1), +), List(Literal(2))), Ident(Int)))
However it definitely seems confusing to me as well, so maybe we could print Typed with a higher precedence even if it's not required for correctness. I pushed a commit that does that.
This comment has been minimized.
This comment has been minimized.
mbovel
force-pushed
the
mb/print-infix-ops
branch
from
a5ea8a1 to
7d97b83
Compare
mbovel
force-pushed
the
mb/print-infix-ops
branch
from
7d97b83 to
66094a1
Compare
|
As you already had a look (thanks!), would you be available to review this PR @bishabosha? :) |
mbovel
commented
Mar 24, 2025
| def isOperatorName: Boolean = name match | ||
| case name: SimpleName => name.exists(isOperatorPart) | ||
| case _ => false | ||
| /** Does this name match `[{letter | digit} '_'] op`? |
There was a problem hiding this comment.
Note: letter, digit and op are defined in https://scala-lang.org/files/archive/spec/3.4/01-lexical-syntax.html.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.