Mix in the productPrefix hash statically in case class hashCode
#22865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 2.13, case class `hashCode` mixes in the hash code of the `productPrefix` string. This is inconsistent with the `equals` method, subclasses of case classes that override `productPrefix` compare equal but have a different `hashCode`. This commit changes `hashCode` to mix in the `productPrefix.hashCode` statically instead of invoking `productPrefix` at runtime. For case classes without primitive fields, the synthetic `hashCode` invokes `ScalaRunTime._hashCode`, which mixes in the result of `productPrefix`. To fix that, the synthetic hashCode is changed to invoke `MurmurHash3.productHash` directly and mix in the name to the seed statically.
sjrd
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 2.13, case class
hashCodemixes in the hash code of theproductPrefixstring. This is inconsistent with theequalsmethod, subclasses of case classes that overrideproductPrefixcompare equal but have a differenthashCode(scala/bug#13033).This commit changes
hashCodeto mix in theproductPrefix.hashCodestatically instead of invokingproductPrefixat runtime.For case classes without primitive fields, the synthetic
hashCodeinvokesScalaRunTime._hashCode, which mixes in the result ofproductPrefix. To fix that, the synthetic hashCode is changed to invokeMurmurHash3.productHashdirectly and mix in the name to the seed statically.Scala 3 forward port of scala/scala#11023