Skip to content

Commit 3a48a28

Browse files
committed
Always use mixins! as a prefix.
This is safe and it's needed for anything that uses mixins.
1 parent be955ac commit 3a48a28

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

RequireJsLoaderPlugin.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,10 @@ function gatherRequireJsImports(modules) {
99
let needsImport = [];
1010
for (let module of modules) {
1111
// If the requirejs-loader was used, then we need to wrap and import this module.
12+
// It's safe to use mixins! in all cases, and necessary for anything where require('mixins').hasMixins(module) is true.
1213
// TODO: Clean up this check.
13-
if (module.request && String(module.request).indexOf('jquery.js') !== -1) {
14+
if (module.request && module.request.indexOf('requirejs-loader') !== -1) {
1415
needsImport.push('mixins!' + module.rawRequest);
15-
} else if (module.request && module.request.indexOf('requirejs-loader') !== -1) {
16-
needsImport.push(module.rawRequest);
1716
}
1817
}
1918

index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ module.exports.pitch = function (remainingRequest) {
1010
this.cacheable && this.cacheable();
1111

1212
// Route through window.require.
13+
// It's safe to use mixins! in all cases, and necessary for anything where require('mixins').hasMixins(module) is true.
1314
// TODO: We use rawRequest to grab the original request (including text! or etc.)
14-
const prefix = (this._module.rawRequest == 'jquery') ? 'mixins!' : '';
15-
const jsonName = JSON.stringify(prefix + this._module.rawRequest);
15+
const jsonName = JSON.stringify('mixins!' + this._module.rawRequest);
1616
return `module.exports = window.require(${jsonName});`;
1717
};
1818

0 commit comments

Comments
 (0)