Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace map() with forEach() for better clarity #967

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0xkazak
Copy link

@0xkazak 0xkazak commented Mar 9, 2025

Description

map() was being used to iterate over arrays, but the result of the map call was never used.
this is inefficient because map() is designed to create a new array, which is unnecessary in this case.
i’ve replaced it with forEach() to make the code more clear and performant, as we only need to iterate over the array and don't require the resulting array.

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant