Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Optionally disable rebuilding python packages #142

Closed
carlkibler opened this issue Feb 27, 2018 · 4 comments
Closed

Feature Request: Optionally disable rebuilding python packages #142

carlkibler opened this issue Feb 27, 2018 · 4 comments

Comments

@carlkibler
Copy link

I would love speed up re-packaging of my project's python requirements by explicitly telling this plugin not to run sometimes.

Example: When I'm on a slow internet connection I can avoid network requests. When I'm on battery can avoid the Docker invocation. Or just when reqs haven't changed.

As an example, would like to:
sls package --skip-python-requirements
sls deploy --skip-python-requirements
(or however params to plugin execution can be passed)

@dschep
Copy link
Contributor

dschep commented Feb 27, 2018

This would best be implemented as skipping the pip install step (rather disabling the plugin entirely) and still linking/unlinking from .serverless/requirements

@AndrewFarley
Copy link
Contributor

Attempted to implement in #162 but it could use a flag and a lot of love. Input invited. :)

@AndrewFarley
Copy link
Contributor

Some notes from my implementation, however, is that the .serverless folder is completely destroyed before passing context into this plugin. So we can't use the previous data in .serverless/requirements. At least, not to my knowledge. See my comments on that PR for more details...

@pgrzesik
Copy link
Contributor

Hey 👋 I'm closing this ticket as it looks like it's heavily outdated, we can of course reopen it if needed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants