Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to used private repos in requirements #121

Merged
merged 2 commits into from
Jan 8, 2018

Conversation

cgrimal
Copy link

@cgrimal cgrimal commented Jan 8, 2018

Add a dockerSshSymlink option which is a path to your .ssh folder containing your keys.
If the passphrase is empty, you will be able to package your private repos from the docker container.
Solves #69 ?

@cgrimal cgrimal changed the title Add dockerSshSymlink option to used private repos in requirements Add option to used private repos in requirements Jan 8, 2018
@cgrimal
Copy link
Author

cgrimal commented Jan 8, 2018

Also works with a non-empty passphrase now, by using the ssh authentication socket (thanks @dschep)!

@dschep
Copy link
Contributor

dschep commented Jan 8, 2018

Awesome! Thanks so much @cgrimal. Glad the ssh-agent solution worked too. I'll check it out and make a new release when I get home from work today.

@dschep dschep merged commit cf4b1dc into serverless:master Jan 8, 2018
@cgrimal
Copy link
Author

cgrimal commented Jan 10, 2018

Hi Daniel,
I'm afraid it doesn't work as expected... There is a conflict with the -u option because the pip install command is not run as root, and the ssh keys are not used. It worked when I tested it because I was running everything as root and I did not pay attention to that, my bad. 😞
I am working on a workaround though, I'm hoping to have a solution today, I'll update the pull request.
Clément

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants