Support serverless.yml and serverless.yaml in getBindPath() #213
Conversation
This should fix the issue reported by @mrpgraae in serverless#210. I've also added support for `SLS_DEBUG` so we can more easily get some information on future errors.
| return 'serverless.yml'; | ||
| } | ||
| if (fse.pathExistsSync(path.join(servicePath, 'serverless.yaml'))) { | ||
| return 'serverless.yaml'; |
There was a problem hiding this comment.
Did serverless drop support for serverless.json?
There was a problem hiding this comment.
I was not aware that's an option. Let me add that.
lib/docker.js
Outdated
| ]; | ||
| try { | ||
| const ps = dockerCommand(options); | ||
| return ps.stdout.trim() === '/test/serverless.yml'; | ||
| if (process.env.SLS_DEBUG) { | ||
| console.log(`Trying bindPath ${bindPath} (${options})`) |
There was a problem hiding this comment.
Could you use the serverless logging facility instead of console.log?
There was a problem hiding this comment.
I can get to it later this week. We should consider passing this as the second argument to .map() in installAllRequirements() to make this simpler and so we don't have to pass this.serverless around.
There was a problem hiding this comment.
I like that idea! Get to it when you get to it 👍
There was a problem hiding this comment.
It ended up being a bigger surgery than I expected as we don't always call these functions with .map() and so this in that case is the global context. We might have to create a class to make this make sense there.
use `X.map(..., this)` to reduce passing around of `this`
|
I suggest this is squash merged since I had to go back and forth between solutions. |
This should fix the issue reported by @mrpgraae in #210.
I've also added support for
SLS_DEBUGso we can more easily get some information on future errors.