Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend no deploy #339

Closed
wants to merge 2 commits into from
Closed

Extend no deploy #339

wants to merge 2 commits into from

Conversation

ysgit
Copy link

@ysgit ysgit commented Mar 25, 2019

No description provided.

@ysgit
Copy link
Author

ysgit commented Mar 25, 2019

@dschep please consider this PR, it does two things:

  1. Make layer functionality consistent i.e. filter items on noDeploy list etc.
  2. Allow option to extend noDeploy for those who want to add to the list rather than overwrite

Copy link
Contributor

@dschep dschep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add test coverage too? How does this compare to #354

@@ -219,6 +219,9 @@ the following packages are omitted as they are already installed on Lambda:
* s3transfer
* setuptools
* six

Alternatively the `extendNoDeploy` option allows you to omit additional packages
as well as those on teh default list.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
as well as those on teh default list.
as well as those on the default list.

@jdufresne
Copy link
Contributor

How does this square with #312? If the new default of noDeploy will be empty, an "extend" feature may not be necessary.

@dschep
Copy link
Contributor

dschep commented May 24, 2019

Closed in favor of #312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants