Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added feature to use the default noDeploy list with custom list #354

Closed
wants to merge 4 commits into from
Closed

Added feature to use the default noDeploy list with custom list #354

wants to merge 4 commits into from

Conversation

blackmamo
Copy link
Contributor

Added addDefaultNoDeploys flag

@blackmamo blackmamo mentioned this pull request Apr 25, 2019
Closed
dschep
dschep suggested changes May 1, 2019
View reviewed changes
Copy link
Contributor

@dschep dschep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, could you add test coverage? Thanks.

@jdufresne
Copy link
Contributor

How does this fit with #312? If the new default of noDeploy will be empty, an addDefaultNoDeploys feature may not be necessary.

@blackmamo
Copy link
Contributor Author

I wondered this myself with #304 and #312. To be honest I don't have the time available at present to add test cases and have taken another approach on the project I am working on. This PR should probably be closed.

@dschep
Copy link
Contributor

dschep commented May 24, 2019

Closed in favor of #312

@dschep dschep closed this May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschep dschep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blackmamo @jdufresne @dschep