-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix poetry with git dependencies #362
Conversation
The tests break because they try to clone the public repository using ssh and there is no key there. |
@jaysonsantos any reason to not clone the public repository via https? |
@dschep There is when the bug happens, which is a common way when using private repositories to avoid having passwords on the lock. |
@jaysonsantos This also fails if you connect over https as @dschep suggests, and wouldn't require an SSH key to be set up. What do you think of using this instead?
Looking at the I would very much like to see this PR merged, it's very annoying to try to use poetry and this plugin with any private or GitHub-hosted packages currently. |
could you also resolve the conflicts please? This seems like a good PR to merge before i release next week :) |
@dschep @jaysonsantos If it's ok with you I'd be happy to make the requested changes and fix the merge conflict today. I just need to be granted contributor access. |
@tpansino, that actually won't do it since this PR is from a fork. I can't actually commit my suggestions either. Feel free to make a new PR that's based on this one instead. |
52b8980
to
29cab16
Compare
Co-Authored-By: Daniel Schep <dschep@gmail.com>
29cab16
to
6631248
Compare
Closing this as #390 got merged |
Hey there, this PR is to fix problems when you use poetry and git dependencies.
By default, poetry will generate a
requirements.txt
with-e
/--editable
flag which does not work well with-t
(--target
). This PR will read that file and rewrite the lines to make sure pip won't try to install in a wrong way.