Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor option supports common code inclusion when packaging individually #643

Closed

Conversation

nexeh
Copy link

@nexeh nexeh commented Nov 18, 2021

Vendor option can now be used for common code inclusion when lambdas are being packaged individually. This prevents the step of copying vendor from being skipped because of caching. Enabling normal development workflow.

This will help with the following ticket where developers are already using the vendor option for common code inclusion but need to disable caching: #435

…are being packaged individually. This prevents this step from being skipped becuase of caching enabling normal development workflows.
@nexeh
Copy link
Author

nexeh commented Dec 11, 2021

@medikoo I saw that your reviewed another PR. Think you could take a look at this one? I'm curious your thoughts.

@medikoo medikoo requested a review from pgrzesik December 13, 2021 11:26
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nexeh - could you please cover the newly introduced logic with test cases? Also, it looks like the Pr branch needs to be rebased due to conflicts

@pgrzesik
Copy link
Contributor

Hey @nexeh - it's been a long time since this PR was proposed. I'm going to close it, if you feel like the issue is valid, please open a new issue or a new PR against the latest main branch. Thanks 🙇

@pgrzesik pgrzesik closed this Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants