Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document cleanCache in README #794

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Conversation

darthwalsh
Copy link
Contributor

The cleanCache command should be documented in README, see #437 (comment)

This doesn't fix issue #437 -- but it makes the workaround more visible.

Move commands from inline code markdown to code blocks to make them more visible.

The cleanCache command should be documented in README, see
serverless#437 (comment)

This doesn't fix issue serverless#437 -- but it makes the workaround more visible.

Move commands from inline code markdown to code blocks to make them more visible.
@darthwalsh
Copy link
Contributor Author

(I think there's a bug where the python version should be included in the hash in the cache, but I'm not familiar enough with the caching mechanism to be sure.)

@darthwalsh
Copy link
Contributor Author

@dschep are you still a good person to ask for PR review? #165 added the cleanCache command but it's not listed in the README documentation yet.

@dschep
Copy link
Contributor

dschep commented Dec 22, 2023

Nope. From the commit history it looks like you want @pgrzesik

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @darthwalsh, looks good 👍

@pgrzesik
Copy link
Contributor

pgrzesik commented Jan 1, 2024

Thanks @dschep for the ping, I'm trying to keep the lights on whenever I have a little bit of free time, which is not easy lately 😅

@pgrzesik pgrzesik merged commit 16c0e68 into serverless:master Jan 1, 2024
@darthwalsh darthwalsh deleted the patch-1 branch February 11, 2024 15:21
naoyasugita pushed a commit to naoyasugita/serverless-python-requirements that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants