refactor(core): remove duplicated code in change_detection_util (angular#45599)

Removes duplicated code in change_detection_util and reorganizes imports to use utils module.

PR Close angular#45599

Author: mmaterowski

packages/core/src/change_detection/change_detection.ts

@@ -12,7 +12,7 @@ import {IterableDifferFactory, IterableDiffers} from './differs/iterable_differs
 import {KeyValueDifferFactory, KeyValueDiffers} from './differs/keyvalue_differs';
 
 export {SimpleChange, SimpleChanges} from '../interface/simple_change';
-export {devModeEqual} from './change_detection_util';
+export {devModeEqual} from '../util/comparison';
 export {ChangeDetectorRef} from './change_detector_ref';
 export {ChangeDetectionStrategy, ChangeDetectorStatus, isDefaultChangeDetectionStrategy} from './constants';
 export {DefaultIterableDiffer, DefaultIterableDifferFactory} from './differs/default_iterable_differ';

packages/core/src/change_detection/change_detection_util.ts

@@ -7,8 +7,8 @@
  */
 
 import {RuntimeError, RuntimeErrorCode} from '../../errors';
+import {isListLikeIterable, iterateListLike} from '../../util/iterable';
 import {stringify} from '../../util/stringify';
-import {isListLikeIterable, iterateListLike} from '../change_detection_util';
 
 import {IterableChangeRecord, IterableChanges, IterableDiffer, IterableDifferFactory, NgIterable, TrackByFunction} from './iterable_differs';
 

packages/core/src/change_detection/differs/default_iterable_differ.ts

@@ -7,8 +7,8 @@
  */
 
 import {RuntimeError, RuntimeErrorCode} from '../../errors';
+import {isJsObject} from '../../util/iterable';
 import {stringify} from '../../util/stringify';
-import {isJsObject} from '../change_detection_util';
 
 import {KeyValueChangeRecord, KeyValueChanges, KeyValueDiffer, KeyValueDifferFactory} from './keyvalue_differs';
 

packages/core/src/change_detection/differs/default_keyvalue_differ.ts

@@ -9,7 +9,6 @@
 export {ALLOW_MULTIPLE_PLATFORMS as ɵALLOW_MULTIPLE_PLATFORMS} from './application_ref';
 export {APP_ID_RANDOM_PROVIDER as ɵAPP_ID_RANDOM_PROVIDER} from './application_tokens';
 export {defaultIterableDiffers as ɵdefaultIterableDiffers, defaultKeyValueDiffers as ɵdefaultKeyValueDiffers} from './change_detection/change_detection';
-export {devModeEqual as ɵdevModeEqual, isListLikeIterable as ɵisListLikeIterable} from './change_detection/change_detection_util';
 export {ChangeDetectorStatus as ɵChangeDetectorStatus, isDefaultChangeDetectionStrategy as ɵisDefaultChangeDetectionStrategy} from './change_detection/constants';
 export {Console as ɵConsole} from './console';
 export {getDebugNodeR2 as ɵgetDebugNodeR2} from './debug/debug_node';
@@ -26,8 +25,10 @@ export {allowSanitizationBypassAndThrow as ɵallowSanitizationBypassAndThrow, By
 export {_sanitizeHtml as ɵ_sanitizeHtml} from './sanitization/html_sanitizer';
 export {_sanitizeUrl as ɵ_sanitizeUrl} from './sanitization/url_sanitizer';
 export {coerceToBoolean as ɵcoerceToBoolean} from './util/coercion';
+export {devModeEqual as ɵdevModeEqual} from './util/comparison';
 export {makeDecorator as ɵmakeDecorator} from './util/decorators';
 export {global as ɵglobal} from './util/global';
+export {isListLikeIterable as ɵisListLikeIterable} from './util/iterable';
 export {isObservable as ɵisObservable, isPromise as ɵisPromise, isSubscribable as ɵisSubscribable} from './util/lang';
 export {stringify as ɵstringify} from './util/stringify';
 export {NOT_FOUND_CHECK_ONLY_ELEMENT_INJECTOR as ɵNOT_FOUND_CHECK_ONLY_ELEMENT_INJECTOR} from './view/provider_flags';

packages/core/src/core_private_export.ts

@@ -6,8 +6,8 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {devModeEqual} from '../change_detection/change_detection_util';
 import {assertIndexInRange, assertLessThan, assertNotSame} from '../util/assert';
+import {devModeEqual} from '../util/comparison';
 
 import {getExpressionChangedErrorDetails, throwErrorIfNoChangesMode} from './errors';
 import {LView} from './interfaces/view';

packages/core/src/render3/bindings.ts

@@ -8,8 +8,8 @@
 
 import {DefaultIterableDiffer, DefaultIterableDifferFactory} from '@angular/core/src/change_detection/differs/default_iterable_differ';
 
-import {TestIterable} from '../../change_detection/iterable';
-import {iterableChangesAsString, iterableDifferToString} from '../../change_detection/util';
+import {TestIterable} from '../../util/iterable';
+import {iterableChangesAsString, iterableDifferToString} from '../util';
 
 class ItemWithId {
   constructor(private id: string) {}

packages/core/test/change_detection/differs/default_iterable_differ_spec.ts

@@ -8,7 +8,7 @@
 
 import {DefaultKeyValueDiffer, DefaultKeyValueDifferFactory} from '@angular/core/src/change_detection/differs/default_keyvalue_differ';
 
-import {kvChangesAsString, testChangesAsString} from '../../change_detection/util';
+import {kvChangesAsString, testChangesAsString} from '../util';
 
 
 // TODO(vicb): Update the code & tests for object equality

packages/core/test/change_detection/differs/default_keyvalue_differ_spec.ts

@@ -7,8 +7,8 @@
  */
 
 import {ɵgetDOM as getDOM} from '@angular/common';
-import {iterateListLike} from '@angular/core/src/change_detection/change_detection_util';
 import {QueryList} from '@angular/core/src/linker/query_list';
+import {iterateListLike} from '@angular/core/src/util/iterable';
 import {fakeAsync, tick} from '@angular/core/testing';
 
 {

packages/core/test/linker/query_list_spec.ts

@@ -6,10 +6,10 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {devModeEqual} from '@angular/core/src/change_detection/change_detection_util';
+import {devModeEqual} from '@angular/core/src/util/comparison';
 
 {
-  describe('ChangeDetectionUtil', () => {
+  describe('Comparison util', () => {
     describe('devModeEqual', () => {
       it('should do the deep comparison of iterables', () => {
         expect(devModeEqual([['one']], [['one']])).toBe(true);