fix(ivy): *Def types are private (ɵ) symbols (angular#24738)

On accident a few of the definition types were emitted as public API
symbols. Much of the Ivy API surface is still prefixed with ɵ,
indicating it's a private API. The definition types should be private
for now.

PR Close angular#24738

Author: alxhub

packages/compiler-cli/src/ngtsc/transform/src/translator.ts

@@ -35,8 +35,8 @@ const CORE_SUPPORTED_SYMBOLS = new Set<string>([
   'ɵdefineNgModule',
   'inject',
   'InjectableDef',
-  'InjectorDef',
-  'NgModuleDef',
+  'ɵInjectorDef',
+  'ɵNgModuleDef',
 ]);
 
 export class ImportManager {

packages/compiler-cli/test/ngtsc/ngtsc_spec.ts

@@ -144,7 +144,7 @@ describe('ngtsc behavioral tests', () => {
     expect(jsContents).not.toContain('__decorate');
 
     const dtsContents = getContents('test.d.ts');
-    expect(dtsContents).toContain('static ngComponentDef: i0.ComponentDef<TestCmp, \'test-cmp\'>');
+    expect(dtsContents).toContain('static ngComponentDef: i0.ɵComponentDef<TestCmp, \'test-cmp\'>');
   });
 
   it('should compile Components without errors', () => {
@@ -196,9 +196,9 @@ describe('ngtsc behavioral tests', () => {
             'declarations: [TestCmp], imports: [], exports: [] })');
 
     const dtsContents = getContents('test.d.ts');
-    expect(dtsContents).toContain('static ngComponentDef: i0.ComponentDef<TestCmp, \'test-cmp\'>');
+    expect(dtsContents).toContain('static ngComponentDef: i0.ɵComponentDef<TestCmp, \'test-cmp\'>');
     expect(dtsContents)
-        .toContain('static ngModuleDef: i0.NgModuleDef<TestModule, [TestCmp], [], []>');
+        .toContain('static ngModuleDef: i0.ɵNgModuleDef<TestModule, [TestCmp], [], []>');
     expect(dtsContents).not.toContain('__decorate');
   });
 
@@ -240,8 +240,8 @@ describe('ngtsc behavioral tests', () => {
 
     const dtsContents = getContents('test.d.ts');
     expect(dtsContents)
-        .toContain('static ngModuleDef: i0.NgModuleDef<TestModule, [TestCmp], [OtherModule], []>');
-    expect(dtsContents).toContain('static ngInjectorDef: i0.InjectorDef');
+        .toContain('static ngModuleDef: i0.ɵNgModuleDef<TestModule, [TestCmp], [OtherModule], []>');
+    expect(dtsContents).toContain('static ngInjectorDef: i0.ɵInjectorDef');
   });
 
   it('should compile Pipes without errors', () => {
@@ -342,6 +342,6 @@ describe('ngtsc behavioral tests', () => {
     expect(jsContents).toContain('pipes: [TestPipe]');
 
     const dtsContents = getContents('test.d.ts');
-    expect(dtsContents).toContain('i0.NgModuleDef<TestModule, [TestPipe,TestCmp], [], []>');
+    expect(dtsContents).toContain('i0.ɵNgModuleDef<TestModule, [TestPipe,TestCmp], [], []>');
   });
 });

packages/compiler/src/render3/r3_identifiers.ts

@@ -104,7 +104,7 @@ export class Identifiers {
   static defineComponent: o.ExternalReference = {name: 'ɵdefineComponent', moduleName: CORE};
 
   static ComponentDef: o.ExternalReference = {
-    name: 'ComponentDef',
+    name: 'ɵComponentDef',
     moduleName: CORE,
   };
 
@@ -114,12 +114,12 @@ export class Identifiers {
   };
 
   static DirectiveDef: o.ExternalReference = {
-    name: 'DirectiveDef',
+    name: 'ɵDirectiveDef',
     moduleName: CORE,
   };
 
   static InjectorDef: o.ExternalReference = {
-    name: 'InjectorDef',
+    name: 'ɵInjectorDef',
     moduleName: CORE,
   };
 
@@ -129,7 +129,7 @@ export class Identifiers {
   };
 
   static NgModuleDef: o.ExternalReference = {
-    name: 'NgModuleDef',
+    name: 'ɵNgModuleDef',
     moduleName: CORE,
   };
 

packages/core/src/di.ts

@@ -13,7 +13,7 @@
  */
 
 export * from './di/metadata';
-export {InjectableType, InjectorType, defineInjectable, defineInjector} from './di/defs';
+export {InjectableType, InjectorDef, InjectorType, defineInjectable, defineInjector} from './di/defs';
 export {forwardRef, resolveForwardRef, ForwardRefFn} from './di/forward_ref';
 export {Injectable, InjectableDecorator, InjectableProvider} from './di/injectable';
 export {inject, InjectFlags, INJECTOR, Injector} from './di/injector';

packages/core/src/r3_symbols.ts

@@ -19,9 +19,9 @@
  * The below symbols are used for @Injectable and @NgModule compilation.
  */
 
-export {InjectableDef, InjectorDef, defineInjectable, defineInjector} from './di/defs';
+export {InjectableDef, InjectorDef as ɵInjectorDef, defineInjectable, defineInjector} from './di/defs';
 export {inject} from './di/injector';
-export {NgModuleDef} from './metadata/ng_module';
+export {NgModuleDef as ɵNgModuleDef} from './metadata/ng_module';
 export {defineNgModule as ɵdefineNgModule} from './render3/definition';
 
 

packages/core/test/render3/jit_environment_spec.ts

@@ -12,10 +12,10 @@ import {Identifiers} from '@angular/compiler/src/render3/r3_identifiers';
 import {angularCoreEnv} from '../../src/render3/jit/environment';
 
 const INTERFACE_EXCEPTIONS = new Set<string>([
-  'ComponentDef',
-  'DirectiveDef',
-  'InjectorDef',
-  'NgModuleDef',
+  'ɵComponentDef',
+  'ɵDirectiveDef',
+  'ɵInjectorDef',
+  'ɵNgModuleDef',
   'ɵPipeDef',
 ]);