Skip to content

Commit b858776

Browse files
committed
reduce visibility of several methods in solver-specific numeral formula managers.
1 parent 70a3cfc commit b858776

File tree

4 files changed

+45
-45
lines changed

4 files changed

+45
-45
lines changed

src/org/sosy_lab/java_smt/solvers/cvc4/CVC4NumeralFormulaManager.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ abstract class CVC4NumeralFormulaManager<
7171
protected abstract Type getNumeralType();
7272

7373
@Override
74-
public boolean isNumeral(Expr pVal) {
74+
protected boolean isNumeral(Expr pVal) {
7575
return (pVal.getType().isInteger() || pVal.getType().isReal()) && pVal.isConst();
7676
}
7777

@@ -134,7 +134,7 @@ protected Expr makeVariableImpl(String varName) {
134134
}
135135

136136
@Override
137-
public Expr multiply(Expr pParam1, Expr pParam2) {
137+
protected Expr multiply(Expr pParam1, Expr pParam2) {
138138
if (consistsOfNumerals(pParam1) || consistsOfNumerals(pParam2)) {
139139
return exprManager.mkExpr(Kind.MULT, pParam1, pParam2);
140140
} else {
@@ -143,47 +143,47 @@ public Expr multiply(Expr pParam1, Expr pParam2) {
143143
}
144144

145145
@Override
146-
public Expr modulo(Expr pParam1, Expr pParam2) {
146+
protected Expr modulo(Expr pParam1, Expr pParam2) {
147147
return exprManager.mkExpr(Kind.INTS_MODULUS, pParam1, pParam2);
148148
}
149149

150150
@Override
151-
public Expr negate(Expr pParam1) {
151+
protected Expr negate(Expr pParam1) {
152152
return exprManager.mkExpr(Kind.UMINUS, pParam1);
153153
}
154154

155155
@Override
156-
public Expr add(Expr pParam1, Expr pParam2) {
156+
protected Expr add(Expr pParam1, Expr pParam2) {
157157
return exprManager.mkExpr(Kind.PLUS, pParam1, pParam2);
158158
}
159159

160160
@Override
161-
public Expr subtract(Expr pParam1, Expr pParam2) {
161+
protected Expr subtract(Expr pParam1, Expr pParam2) {
162162
return exprManager.mkExpr(Kind.MINUS, pParam1, pParam2);
163163
}
164164

165165
@Override
166-
public Expr equal(Expr pParam1, Expr pParam2) {
166+
protected Expr equal(Expr pParam1, Expr pParam2) {
167167
return exprManager.mkExpr(Kind.EQUAL, pParam1, pParam2);
168168
}
169169

170170
@Override
171-
public Expr greaterThan(Expr pParam1, Expr pParam2) {
171+
protected Expr greaterThan(Expr pParam1, Expr pParam2) {
172172
return exprManager.mkExpr(Kind.GT, pParam1, pParam2);
173173
}
174174

175175
@Override
176-
public Expr greaterOrEquals(Expr pParam1, Expr pParam2) {
176+
protected Expr greaterOrEquals(Expr pParam1, Expr pParam2) {
177177
return exprManager.mkExpr(Kind.GEQ, pParam1, pParam2);
178178
}
179179

180180
@Override
181-
public Expr lessThan(Expr pParam1, Expr pParam2) {
181+
protected Expr lessThan(Expr pParam1, Expr pParam2) {
182182
return exprManager.mkExpr(Kind.LT, pParam1, pParam2);
183183
}
184184

185185
@Override
186-
public Expr lessOrEquals(Expr pParam1, Expr pParam2) {
186+
protected Expr lessOrEquals(Expr pParam1, Expr pParam2) {
187187
return exprManager.mkExpr(Kind.LEQ, pParam1, pParam2);
188188
}
189189

src/org/sosy_lab/java_smt/solvers/mathsat5/Mathsat5NumeralFormulaManager.java

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ protected boolean isNumeral(Long val) {
5555
}
5656

5757
@Override
58-
public Long makeNumberImpl(long pNumber) {
58+
protected Long makeNumberImpl(long pNumber) {
5959
int i = (int) pNumber;
6060
if (i == pNumber) { // fits in an int
6161
return msat_make_int_number(mathsatEnv, i);
@@ -64,49 +64,49 @@ public Long makeNumberImpl(long pNumber) {
6464
}
6565

6666
@Override
67-
public Long makeNumberImpl(BigInteger pI) {
67+
protected Long makeNumberImpl(BigInteger pI) {
6868
return msat_make_number(mathsatEnv, pI.toString());
6969
}
7070

7171
@Override
72-
public Long makeNumberImpl(String pI) {
72+
protected Long makeNumberImpl(String pI) {
7373
return msat_make_number(mathsatEnv, pI);
7474
}
7575

7676
protected abstract long getNumeralType();
7777

7878
@Override
79-
public Long makeVariableImpl(String var) {
79+
protected Long makeVariableImpl(String var) {
8080
return getFormulaCreator().makeVariable(getNumeralType(), var);
8181
}
8282

8383
@Override
84-
public Long negate(Long pNumber) {
84+
protected Long negate(Long pNumber) {
8585
return msat_make_times(mathsatEnv, pNumber, msat_make_number(mathsatEnv, "-1"));
8686
}
8787

8888
@Override
89-
public Long add(Long pNumber1, Long pNumber2) {
89+
protected Long add(Long pNumber1, Long pNumber2) {
9090
return msat_make_plus(mathsatEnv, pNumber1, pNumber2);
9191
}
9292

9393
@Override
94-
public Long subtract(Long pNumber1, Long pNumber2) {
94+
protected Long subtract(Long pNumber1, Long pNumber2) {
9595
return msat_make_plus(mathsatEnv, pNumber1, negate(pNumber2));
9696
}
9797

9898
@Override
99-
public Long multiply(Long pNumber1, Long pNumber2) {
99+
protected Long multiply(Long pNumber1, Long pNumber2) {
100100
return msat_make_times(mathsatEnv, pNumber1, pNumber2);
101101
}
102102

103103
@Override
104-
public Long equal(Long pNumber1, Long pNumber2) {
104+
protected Long equal(Long pNumber1, Long pNumber2) {
105105
return msat_make_equal(mathsatEnv, pNumber1, pNumber2);
106106
}
107107

108108
@Override
109-
public Long distinctImpl(List<Long> pNumbers) {
109+
protected Long distinctImpl(List<Long> pNumbers) {
110110
// MathSat does not directly support this method, we need to build the whole term.
111111
long r = msat_make_true(mathsatEnv);
112112
for (int i = 0; i < pNumbers.size(); i++) {
@@ -118,12 +118,12 @@ public Long distinctImpl(List<Long> pNumbers) {
118118
}
119119

120120
@Override
121-
public Long greaterThan(Long pNumber1, Long pNumber2) {
121+
protected Long greaterThan(Long pNumber1, Long pNumber2) {
122122
return makeNot(lessOrEquals(pNumber1, pNumber2));
123123
}
124124

125125
@Override
126-
public Long greaterOrEquals(Long pNumber1, Long pNumber2) {
126+
protected Long greaterOrEquals(Long pNumber1, Long pNumber2) {
127127
return lessOrEquals(pNumber2, pNumber1);
128128
}
129129

@@ -132,12 +132,12 @@ private long makeNot(long n) {
132132
}
133133

134134
@Override
135-
public Long lessThan(Long pNumber1, Long pNumber2) {
135+
protected Long lessThan(Long pNumber1, Long pNumber2) {
136136
return makeNot(lessOrEquals(pNumber2, pNumber1));
137137
}
138138

139139
@Override
140-
public Long lessOrEquals(Long pNumber1, Long pNumber2) {
140+
protected Long lessOrEquals(Long pNumber1, Long pNumber2) {
141141
return msat_make_leq(mathsatEnv, pNumber1, pNumber2);
142142
}
143143

src/org/sosy_lab/java_smt/solvers/princess/PrincessNumeralFormulaManager.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,22 +46,22 @@ abstract class PrincessNumeralFormulaManager<
4646
}
4747

4848
@Override
49-
public ITerm negate(IExpression pNumber) {
49+
protected ITerm negate(IExpression pNumber) {
5050
return ((ITerm) pNumber).unary_$minus();
5151
}
5252

5353
@Override
54-
public ITerm add(IExpression pNumber1, IExpression pNumber2) {
54+
protected ITerm add(IExpression pNumber1, IExpression pNumber2) {
5555
return ((ITerm) pNumber1).$plus((ITerm) pNumber2);
5656
}
5757

5858
@Override
59-
public ITerm subtract(IExpression pNumber1, IExpression pNumber2) {
59+
protected ITerm subtract(IExpression pNumber1, IExpression pNumber2) {
6060
return ((ITerm) pNumber1).$minus((ITerm) pNumber2);
6161
}
6262

6363
@Override
64-
public IFormula equal(IExpression pNumber1, IExpression pNumber2) {
64+
protected IFormula equal(IExpression pNumber1, IExpression pNumber2) {
6565
return ((ITerm) pNumber1).$eq$eq$eq((ITerm) pNumber2);
6666
}
6767

@@ -71,22 +71,22 @@ protected IExpression distinctImpl(List<IExpression> pNumbers) {
7171
}
7272

7373
@Override
74-
public IFormula greaterThan(IExpression pNumber1, IExpression pNumber2) {
74+
protected IFormula greaterThan(IExpression pNumber1, IExpression pNumber2) {
7575
return ((ITerm) pNumber1).$greater((ITerm) pNumber2);
7676
}
7777

7878
@Override
79-
public IFormula greaterOrEquals(IExpression pNumber1, IExpression pNumber2) {
79+
protected IFormula greaterOrEquals(IExpression pNumber1, IExpression pNumber2) {
8080
return ((ITerm) pNumber1).$greater$eq((ITerm) pNumber2);
8181
}
8282

8383
@Override
84-
public IFormula lessThan(IExpression pNumber1, IExpression pNumber2) {
84+
protected IFormula lessThan(IExpression pNumber1, IExpression pNumber2) {
8585
return ((ITerm) pNumber1).$less((ITerm) pNumber2);
8686
}
8787

8888
@Override
89-
public IFormula lessOrEquals(IExpression pNumber1, IExpression pNumber2) {
89+
protected IFormula lessOrEquals(IExpression pNumber1, IExpression pNumber2) {
9090
return ((ITerm) pNumber1).$less$eq((ITerm) pNumber2);
9191
}
9292
}

src/org/sosy_lab/java_smt/solvers/z3/Z3NumeralFormulaManager.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -69,64 +69,64 @@ protected Long makeVariableImpl(String varName) {
6969
}
7070

7171
@Override
72-
public Long negate(Long pNumber) {
72+
protected Long negate(Long pNumber) {
7373
long sort = Native.getSort(z3context, pNumber);
7474
long minusOne = Native.mkInt(z3context, -1, sort);
7575
return Native.mkMul(z3context, 2, new long[] {minusOne, pNumber});
7676
}
7777

7878
@Override
79-
public Long add(Long pNumber1, Long pNumber2) {
79+
protected Long add(Long pNumber1, Long pNumber2) {
8080
return Native.mkAdd(z3context, 2, new long[] {pNumber1, pNumber2});
8181
}
8282

8383
@Override
84-
public Long sumImpl(List<Long> operands) {
84+
protected Long sumImpl(List<Long> operands) {
8585
return Native.mkAdd(z3context, operands.size(), Longs.toArray(operands));
8686
}
8787

8888
@Override
89-
public Long subtract(Long pNumber1, Long pNumber2) {
89+
protected Long subtract(Long pNumber1, Long pNumber2) {
9090
return Native.mkSub(z3context, 2, new long[] {pNumber1, pNumber2});
9191
}
9292

9393
@Override
94-
public Long divide(Long pNumber1, Long pNumber2) {
94+
protected Long divide(Long pNumber1, Long pNumber2) {
9595
return Native.mkDiv(z3context, pNumber1, pNumber2);
9696
}
9797

9898
@Override
99-
public Long multiply(Long pNumber1, Long pNumber2) {
99+
protected Long multiply(Long pNumber1, Long pNumber2) {
100100
return Native.mkMul(z3context, 2, new long[] {pNumber1, pNumber2});
101101
}
102102

103103
@Override
104-
public Long equal(Long pNumber1, Long pNumber2) {
104+
protected Long equal(Long pNumber1, Long pNumber2) {
105105
return Native.mkEq(z3context, pNumber1, pNumber2);
106106
}
107107

108108
@Override
109-
public Long distinctImpl(List<Long> pNumbers) {
109+
protected Long distinctImpl(List<Long> pNumbers) {
110110
return Native.mkDistinct(z3context, pNumbers.size(), Longs.toArray(pNumbers));
111111
}
112112

113113
@Override
114-
public Long greaterThan(Long pNumber1, Long pNumber2) {
114+
protected Long greaterThan(Long pNumber1, Long pNumber2) {
115115
return Native.mkGt(z3context, pNumber1, pNumber2);
116116
}
117117

118118
@Override
119-
public Long greaterOrEquals(Long pNumber1, Long pNumber2) {
119+
protected Long greaterOrEquals(Long pNumber1, Long pNumber2) {
120120
return Native.mkGe(z3context, pNumber1, pNumber2);
121121
}
122122

123123
@Override
124-
public Long lessThan(Long pNumber1, Long pNumber2) {
124+
protected Long lessThan(Long pNumber1, Long pNumber2) {
125125
return Native.mkLt(z3context, pNumber1, pNumber2);
126126
}
127127

128128
@Override
129-
public Long lessOrEquals(Long pNumber1, Long pNumber2) {
129+
protected Long lessOrEquals(Long pNumber1, Long pNumber2) {
130130
return Native.mkLe(z3context, pNumber1, pNumber2);
131131
}
132132
}

0 commit comments

Comments
 (0)