Skip to content

Commit 0c2bf70

Browse files
olamysnicoll
authored andcommitted
Use the container IP address for tests using TestContainer
See gh-21480
1 parent afcb5d5 commit 0c2bf70

File tree

5 files changed

+13
-6
lines changed

5 files changed

+13
-6
lines changed

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/couchbase/CouchbaseAutoConfigurationIntegrationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ static void createBucket() {
7474
void setUp() {
7575
this.context = new AnnotationConfigApplicationContext();
7676
this.context.register(CouchbaseAutoConfiguration.class);
77-
TestPropertyValues.of("spring.couchbase.bootstrap-hosts=localhost",
77+
TestPropertyValues.of("spring.couchbase.bootstrap-hosts=" + couchbase.getContainerIpAddress(),
7878
"spring.couchbase.env.bootstrap.http-direct-port:" + couchbase.getMappedPort(8091),
7979
"spring.couchbase.username:spring", "spring.couchbase.password:password",
8080
"spring.couchbase.bucket.name:default").applyTo(this.context.getEnvironment());

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/data/cassandra/CassandraDataAutoConfigurationIntegrationTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ class CassandraDataAutoConfigurationIntegrationTests {
5656
void setUp() {
5757
this.context = new AnnotationConfigApplicationContext();
5858
TestPropertyValues
59-
.of("spring.data.cassandra.port=" + cassandra.getFirstMappedPort(),
59+
.of("spring.data.cassandra.contact-points=" + cassandra.getContainerIpAddress(),
60+
"spring.data.cassandra.port=" + cassandra.getFirstMappedPort(),
6061
"spring.data.cassandra.read-timeout=24000", "spring.data.cassandra.connect-timeout=10000")
6162
.applyTo(this.context.getEnvironment());
6263
}

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/session/SessionAutoConfigurationRedisTests.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,8 @@ class SessionAutoConfigurationRedisTests extends AbstractSessionAutoConfiguratio
6363

6464
@Test
6565
void defaultConfig() {
66-
this.contextRunner
67-
.withPropertyValues("spring.session.store-type=redis",
68-
"spring.redis.port=" + redis.getFirstMappedPort())
66+
this.contextRunner.withPropertyValues("spring.session.store-type=redis",
67+
"spring.redis.host=" + redis.getContainerIpAddress(), "spring.redis.port=" + redis.getFirstMappedPort())
6968
.withConfiguration(AutoConfigurations.of(RedisAutoConfiguration.class))
7069
.run(validateSpringSessionUsesRedis("spring:session:event:0:created:", FlushMode.ON_SAVE,
7170
SaveMode.ON_SET_ATTRIBUTE, "0 * * * * *"));
@@ -77,7 +76,8 @@ void defaultConfigWithUniqueStoreImplementation() {
7776
.withClassLoader(new FilteredClassLoader(HazelcastIndexedSessionRepository.class,
7877
JdbcIndexedSessionRepository.class, MongoIndexedSessionRepository.class))
7978
.withConfiguration(AutoConfigurations.of(RedisAutoConfiguration.class))
80-
.withPropertyValues("spring.redis.port=" + redis.getFirstMappedPort())
79+
.withPropertyValues("spring.redis.host=" + redis.getContainerIpAddress(),
80+
"spring.redis.port=" + redis.getFirstMappedPort())
8181
.run(validateSpringSessionUsesRedis("spring:session:event:0:created:", FlushMode.ON_SAVE,
8282
SaveMode.ON_SET_ATTRIBUTE, "0 * * * * *"));
8383
}
@@ -88,6 +88,7 @@ void redisSessionStoreWithCustomizations() {
8888
.withPropertyValues("spring.session.store-type=redis", "spring.session.redis.namespace=foo",
8989
"spring.session.redis.flush-mode=immediate", "spring.session.redis.save-mode=on-get-attribute",
9090
"spring.session.redis.cleanup-cron=0 0 12 * * *",
91+
"spring.redis.host=" + redis.getContainerIpAddress(),
9192
"spring.redis.port=" + redis.getFirstMappedPort())
9293
.run(validateSpringSessionUsesRedis("foo:event:0:created:", FlushMode.IMMEDIATE,
9394
SaveMode.ON_GET_ATTRIBUTE, "0 0 12 * * *"));
@@ -97,6 +98,7 @@ void redisSessionStoreWithCustomizations() {
9798
void redisSessionWithConfigureActionNone() {
9899
this.contextRunner.withConfiguration(AutoConfigurations.of(RedisAutoConfiguration.class))
99100
.withPropertyValues("spring.session.store-type=redis", "spring.session.redis.configure-action=none",
101+
"spring.redis.host=" + redis.getContainerIpAddress(),
100102
"spring.redis.port=" + redis.getFirstMappedPort())
101103
.run(validateStrategy(ConfigureRedisAction.NO_OP.getClass()));
102104
}
@@ -105,6 +107,7 @@ void redisSessionWithConfigureActionNone() {
105107
void redisSessionWithDefaultConfigureActionNone() {
106108
this.contextRunner.withConfiguration(AutoConfigurations.of(RedisAutoConfiguration.class))
107109
.withPropertyValues("spring.session.store-type=redis",
110+
"spring.redis.host=" + redis.getContainerIpAddress(),
108111
"spring.redis.port=" + redis.getFirstMappedPort())
109112
.run(validateStrategy(ConfigureNotifyKeyspaceEventsAction.class,
110113
entry("notify-keyspace-events", "gxE")));
@@ -115,6 +118,7 @@ void redisSessionWithCustomConfigureRedisActionBean() {
115118
this.contextRunner.withConfiguration(AutoConfigurations.of(RedisAutoConfiguration.class))
116119
.withUserConfiguration(MaxEntriesRedisAction.class)
117120
.withPropertyValues("spring.session.store-type=redis",
121+
"spring.redis.host=" + redis.getContainerIpAddress(),
118122
"spring.redis.port=" + redis.getFirstMappedPort())
119123
.run(validateStrategy(MaxEntriesRedisAction.class, entry("set-max-intset-entries", "1024")));
120124

spring-boot-project/spring-boot-test-autoconfigure/src/test/java/org/springframework/boot/test/autoconfigure/data/redis/DataRedisTestIntegrationTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ class DataRedisTestIntegrationTests {
6161
@DynamicPropertySource
6262
static void redisProperties(DynamicPropertyRegistry registry) {
6363
registry.add("spring.redis.port", redis::getFirstMappedPort);
64+
registry.add("spring.redis.host", redis::getContainerIpAddress);
6465
}
6566

6667
@Test

spring-boot-project/spring-boot-test-autoconfigure/src/test/java/org/springframework/boot/test/autoconfigure/data/redis/DataRedisTestWithIncludeFilterIntegrationTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ class DataRedisTestWithIncludeFilterIntegrationTests {
5050
@DynamicPropertySource
5151
static void redisProperties(DynamicPropertyRegistry registry) {
5252
registry.add("spring.redis.port", redis::getFirstMappedPort);
53+
registry.add("spring.redis.host", redis::getContainerIpAddress);
5354
}
5455

5556
@Test

0 commit comments

Comments
 (0)