Skip to content

Commit 84a12c8

Browse files
committed
Upgrade to Testcontainers 1.14.3
Closes gh-23122
1 parent 0032ab6 commit 84a12c8

File tree

2 files changed

+8
-21
lines changed

2 files changed

+8
-21
lines changed

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/couchbase/CouchbaseAutoConfigurationIntegrationTests.java

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -17,23 +17,16 @@
1717
package org.springframework.boot.autoconfigure.couchbase;
1818

1919
import java.time.Duration;
20-
import java.util.Collections;
21-
import java.util.List;
2220

2321
import com.couchbase.client.java.Bucket;
2422
import com.couchbase.client.java.Cluster;
2523
import com.couchbase.client.java.CouchbaseBucket;
26-
import com.couchbase.client.java.bucket.BucketType;
27-
import com.couchbase.client.java.cluster.BucketSettings;
2824
import com.couchbase.client.java.cluster.ClusterInfo;
29-
import com.couchbase.client.java.cluster.DefaultBucketSettings;
30-
import com.couchbase.client.java.cluster.UserRole;
31-
import com.couchbase.client.java.cluster.UserSettings;
3225
import com.couchbase.client.java.env.CouchbaseEnvironment;
3326
import org.junit.jupiter.api.AfterEach;
34-
import org.junit.jupiter.api.BeforeAll;
3527
import org.junit.jupiter.api.BeforeEach;
3628
import org.junit.jupiter.api.Test;
29+
import org.testcontainers.couchbase.BucketDefinition;
3730
import org.testcontainers.couchbase.CouchbaseContainer;
3831
import org.testcontainers.junit.jupiter.Container;
3932
import org.testcontainers.junit.jupiter.Testcontainers;
@@ -55,29 +48,23 @@
5548
@Testcontainers(disabledWithoutDocker = true)
5649
class CouchbaseAutoConfigurationIntegrationTests {
5750

51+
private static final String BUCKET_NAME = "cbbucket";
52+
5853
@Container
59-
static final CouchbaseContainer couchbase = new CouchbaseContainer().withClusterAdmin("spring", "password")
60-
.withStartupAttempts(5).withStartupTimeout(Duration.ofMinutes(10));
54+
static final CouchbaseContainer couchbase = new CouchbaseContainer().withCredentials("spring", "password")
55+
.withStartupAttempts(5).withStartupTimeout(Duration.ofMinutes(10))
56+
.withBucket(new BucketDefinition(BUCKET_NAME).withPrimaryIndex(false));
6157

6258
private AnnotationConfigApplicationContext context;
6359

64-
@BeforeAll
65-
static void createBucket() {
66-
BucketSettings bucketSettings = DefaultBucketSettings.builder().enableFlush(true).name("default")
67-
.password("password").quota(100).replicas(0).type(BucketType.COUCHBASE).build();
68-
List<UserRole> userSettings = Collections.singletonList(new UserRole("admin"));
69-
couchbase.createBucket(bucketSettings,
70-
UserSettings.build().password(bucketSettings.password()).roles(userSettings), true);
71-
}
72-
7360
@BeforeEach
7461
void setUp() {
7562
this.context = new AnnotationConfigApplicationContext();
7663
this.context.register(CouchbaseAutoConfiguration.class);
7764
TestPropertyValues.of("spring.couchbase.bootstrap-hosts=" + couchbase.getContainerIpAddress(),
7865
"spring.couchbase.env.bootstrap.http-direct-port:" + couchbase.getMappedPort(8091),
7966
"spring.couchbase.username:spring", "spring.couchbase.password:password",
80-
"spring.couchbase.bucket.name:default").applyTo(this.context.getEnvironment());
67+
"spring.couchbase.bucket.name:" + BUCKET_NAME).applyTo(this.context.getEnvironment());
8168
}
8269

8370
@AfterEach

spring-boot-project/spring-boot-parent/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
<spring-asciidoctor-extensions.version>0.4.0.RELEASE</spring-asciidoctor-extensions.version>
3333
<spring-doc-resources.version>0.1.3.RELEASE</spring-doc-resources.version>
3434
<spring-doc-resources.url>https://repo.spring.io/release/io/spring/docresources/spring-doc-resources/${spring-doc-resources.version}/spring-doc-resources-${spring-doc-resources.version}.zip</spring-doc-resources.url>
35-
<testcontainers.version>1.12.5</testcontainers.version>
35+
<testcontainers.version>1.14.3</testcontainers.version>
3636
<testng.version>6.14.3</testng.version>
3737
</properties>
3838
<scm>

0 commit comments

Comments
 (0)