OAuth2ClientProperties not available when using a custom ClientRegistrationRepository

[jharnack1]

Not 100% sure if this is a bug or intended behaviour, so please close if it's not a bug.

In Spring Boot 3.4.x this would work:

@Bean
@ConditionalOnMissingBean({ClientRegistrationRepository.class})
InMemoryClientRegistrationRepository clientRegistrationRepository(
    OAuth2ClientProperties properties) {

    List<ClientRegistration> registrations = new OAuth2ClientPropertiesMapper(properties).asClientRegistrations().values().stream().toList();
    return new InMemoryClientRegistrationRepository(registrations);
}

(the actual use case is the workaround described in spring-projects/spring-security#7695 (comment))

With Spring Boot 3.5.0 I get this error:

***************************
APPLICATION FAILED TO START
***************************

Description:

Parameter 0 of method clientRegistrationRepository in xxx.ClientRegistrationConfig required a bean of type 'org.springframework.boot.autoconfigure.security.oauth2.client.OAuth2ClientProperties' that could not be found.


Action:

Consider defining a bean of type 'org.springframework.boot.autoconfigure.security.oauth2.client.OAuth2ClientProperties' in your configuration.

I need to add @EnableConfigurationProperties({OAuth2ClientProperties.class}) in my app for this to still work. I think in spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/security/oauth2/client/OAuth2ClientConfigurations.java the OAuth2ClientProperties are only created when there is no custom ClientRegistrationRepository

I would expect OAuth2ClientProperties to exist if they are configured in application.yaml, even when I create a custom client registration repository.

[snicoll]

I need to add @EnableConfigurationProperties({OAuth2ClientProperties.class}) in my app for this to still work.

You shouldn't expect Oauth2ClientProperties to magically appear in the bean factory. If your custom auto-configuration is using it, then it should explicitly ask for binding. Based on the code snippet above I'd argue that the code was wrong in 3.4.x and was working by accident (or rather, by the fact you were expecting that bean to be created).

Also, that custom auto-configuration of yours must run before OAuth2ClientConfigurations so that it can replace the InMemoryClientRegistrationRepository that Spring Boot otherwise would configure. From that perspective, expecting a Oauth2ClientProperties to be created is inaccurate.