Mismatch junit-jupiter version with maven-surefire-plugin&maven-failsafe-plugin

[feddevanderlist]

When using springboot-starter-parent 3.4.5 or 3.4.6 the versions of junit-jupiter 5.11.4 and the junit-jupiter version of maven-surfire-plugin (5.12.2) mismatch.

This can create issues because in the update to junit-jupiter 5.12.x they introduced a new class. See stacktrace below.

Steps to guarantee reproduction:
Include springboot-starter-parent 3.4.5 or 3.4.6
In your maven-failsafe-plugin or maven-surfire-plugin depend on

<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-surefire-plugin</artifactId>
   <dependencies>
      <dependency>
          <groupId>org.junit.jupiter</groupId>
          <artifactId>junit-jupiter-engine</artifactId>
          <version>${junit-jupiter.version}</version>
      </dependency>
  </dependencies>
</plugin>

Possible solutions

• Pin maven-surfire-plugin and maven-failsafe-plugin to version 3.5.2
• Update junit-jupiter to 5.12.x

org/junit/platform/engine/reporting/OutputDirectoryProvider
java.lang.NoClassDefFoundError: org/junit/platform/engine/reporting/OutputDirectoryProvider
	at org.apache.maven.surefire.junitplatform.TestPlanScannerFilter.accept(TestPlanScannerFilter.java:47)
	at org.apache.maven.surefire.api.util.DefaultScanResult.applyFilter(DefaultScanResult.java:87)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.scanClasspath(JUnitPlatformProvider.java:144)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:124)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495)
Caused by: java.lang.ClassNotFoundException: org.junit.platform.engine.reporting.OutputDirectoryProvider

[wilkinsona]

Why have you declared the junit-jupiter-engine dependency? As far as I know, there is no need to do so.

[feddevanderlist]

Why have you declared the junit-jupiter-engine dependency? As far as I know, there is no need to do so.

Because unfortunately junit-4 is still on our classpath and will be picked up as default engine.
Point still stands that it's not 100% compatible version wise.

[wilkinsona]

Unfortunately, it's only incompatible due to your additional configuration that isn't typically necessary.

maven-surfire-plugin and maven-failsafe-plugin to version 3.5.2

We won't do that as we don't want to get stuck on an old 3.5.x release. It's also not clear to me why this would help. I can't see a change between 3.5.2 and 3.5.3 that would result in JUnit Jupiter 5.12 being required.

Update junit-jupiter to 5.12.x

We won't do that as we don't want to upgrade to a new minor of JUnit Jupiter in a maintenance release of Spring Boot. You can, however, choose to opt in to such an upgrade by setting the junit-jupiter.version property.

[feddevanderlist]

Unfortunately, it's only incompatible due to your additional configuration that isn't typically necessary.

maven-surfire-plugin and maven-failsafe-plugin to version 3.5.2

We won't do that as we don't want to get stuck on an old 3.5.x release. It's also not clear to me why this would help. I can't see a change between 3.5.2 and 3.5.3 that would result in JUnit Jupiter 5.12 being required.

Update junit-jupiter to 5.12.x

We won't do that as we don't want to upgrade to a new minor of JUnit Jupiter in a maintenance release of Spring Boot. You can, however, choose to opt in to such an upgrade by setting the junit-jupiter.version property.

I have found why it changed. They updated the maven parent from 43 to 44 in their last release. The parent depends on junit5 version 5.12.1 therefore all sup dependencies were also updated. Which in turn results in the version being resolved to 5.12.1 and because this version is not compatible with the junit5 version 5.11.4 it goes wrong.

[wilkinsona]

Thanks for tracking it down. You may want to report that to the maintainers of Surefire. Looking at apache/maven-surefire#817, it's not clear that the side-effect that you're observing was intentional.

I'm going to close this one as I don't think there's anything that we could/should do on the Spring Boot side of things.