editor: inline tags #7751
Open
editor: inline tags #7751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
* handle backspace and click * improve styling Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
* And minor styling change Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
thecodrr
requested changes
Apr 7, 2025
There was a problem hiding this comment.
This is cool but radically different from what we need:
- Typing
#in the editor should open a menu with a list of recent tags. - Typing after the
#should filter the tags in the opened menu - We can get rid of the
addTagandremoveTagfunctions and instead handle the tags addition/removal in core during the parse phase when saving a note. Just like attachments, note links etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 01zulfi 85733202+01zulfi@users.noreply.github.com
Closes #1387