-
-
Notifications
You must be signed in to change notification settings - Fork 789
web: add editor line height setting #8284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
01zulfi
wants to merge
211
commits into
streetwriters:beta
Choose a base branch
from
01zulfi:web/editor-line-height-setting
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
web: add editor line height setting #8284
01zulfi
wants to merge
211
commits into
streetwriters:beta
from
01zulfi:web/editor-line-height-setting
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* web: archive notes Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com> * global: arhives -> archived Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
* web: make part of nav menu header draggable Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com> * Update apps/web/src/app.css Signed-off-by: Abdullah Atta <thecodrr@protonmail.com> * Update apps/web/src/components/navigation-menu/index.tsx Signed-off-by: Abdullah Atta <thecodrr@protonmail.com> --------- Signed-off-by: Abdullah Atta <thecodrr@protonmail.com> Co-authored-by: Abdullah Atta <thecodrr@protonmail.com>
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
* move it down so it doesn't block the link Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
…writers#8037) Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
this commit also properly fixes search queries containing words less than 3 characters in length
* web: fix archived notes showing in search results Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com> * core: make notes param required in lookup.notesWithHighlighting Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
01zulfi
commented
Jun 30, 2025
@@ -23,3 +23,9 @@ export const EDITOR_ZOOM = { | |||
MIN: 30, | |||
STEP: 10 | |||
}; | |||
|
|||
export const EDITOR_LINE_HEIGHT = { | |||
DEFAULT: 1.2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ammarahm-ed you'll need to add this on your end as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 01zulfi 85733202+01zulfi@users.noreply.github.com