Skip to content

Commit 4a93149

Browse files
Make tests support phpunit 8
1 parent a622dbc commit 4a93149

8 files changed

+34
-8
lines changed

Tests/Store/CombinedStoreTest.php

+3-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
namespace Symfony\Component\Lock\Tests\Store;
1313

14+
use Symfony\Bridge\PhpUnit\ForwardCompatTestTrait;
1415
use Symfony\Component\Lock\Exception\LockConflictedException;
1516
use Symfony\Component\Lock\Key;
1617
use Symfony\Component\Lock\Store\CombinedStore;
@@ -24,6 +25,7 @@
2425
*/
2526
class CombinedStoreTest extends AbstractStoreTest
2627
{
28+
use ForwardCompatTestTrait;
2729
use ExpiringStoreTestTrait;
2830

2931
/**
@@ -58,7 +60,7 @@ public function getStore()
5860
/** @var CombinedStore */
5961
private $store;
6062

61-
protected function setUp()
63+
private function doSetUp()
6264
{
6365
$this->strategy = $this->getMockBuilder(StrategyInterface::class)->getMock();
6466
$this->store1 = $this->getMockBuilder(StoreInterface::class)->getMock();

Tests/Store/MemcachedStoreTest.php

+3-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
namespace Symfony\Component\Lock\Tests\Store;
1313

14+
use Symfony\Bridge\PhpUnit\ForwardCompatTestTrait;
1415
use Symfony\Component\Lock\Store\MemcachedStore;
1516

1617
/**
@@ -20,9 +21,10 @@
2021
*/
2122
class MemcachedStoreTest extends AbstractStoreTest
2223
{
24+
use ForwardCompatTestTrait;
2325
use ExpiringStoreTestTrait;
2426

25-
public static function setupBeforeClass()
27+
private static function doSetUpBeforeClass()
2628
{
2729
$memcached = new \Memcached();
2830
$memcached->addServer(getenv('MEMCACHED_HOST'), 11211);

Tests/Store/PredisStoreTest.php

+5-1
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,16 @@
1111

1212
namespace Symfony\Component\Lock\Tests\Store;
1313

14+
use Symfony\Bridge\PhpUnit\ForwardCompatTestTrait;
15+
1416
/**
1517
* @author Jérémy Derussé <jeremy@derusse.com>
1618
*/
1719
class PredisStoreTest extends AbstractRedisStoreTest
1820
{
19-
public static function setupBeforeClass()
21+
use ForwardCompatTestTrait;
22+
23+
private static function doSetUpBeforeClass()
2024
{
2125
$redis = new \Predis\Client('tcp://'.getenv('REDIS_HOST').':6379');
2226
try {

Tests/Store/RedisArrayStoreTest.php

+5-1
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,18 @@
1111

1212
namespace Symfony\Component\Lock\Tests\Store;
1313

14+
use Symfony\Bridge\PhpUnit\ForwardCompatTestTrait;
15+
1416
/**
1517
* @author Jérémy Derussé <jeremy@derusse.com>
1618
*
1719
* @requires extension redis
1820
*/
1921
class RedisArrayStoreTest extends AbstractRedisStoreTest
2022
{
21-
public static function setupBeforeClass()
23+
use ForwardCompatTestTrait;
24+
25+
private static function doSetUpBeforeClass()
2226
{
2327
if (!class_exists('RedisArray')) {
2428
self::markTestSkipped('The RedisArray class is required.');

Tests/Store/RedisClusterStoreTest.php

+5-1
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,18 @@
1111

1212
namespace Symfony\Component\Lock\Tests\Store;
1313

14+
use Symfony\Bridge\PhpUnit\ForwardCompatTestTrait;
15+
1416
/**
1517
* @author Jérémy Derussé <jeremy@derusse.com>
1618
*
1719
* @requires extension redis
1820
*/
1921
class RedisClusterStoreTest extends AbstractRedisStoreTest
2022
{
21-
public static function setupBeforeClass()
23+
use ForwardCompatTestTrait;
24+
25+
private static function doSetUpBeforeClass()
2226
{
2327
if (!class_exists('RedisCluster')) {
2428
self::markTestSkipped('The RedisCluster class is required.');

Tests/Store/RedisStoreTest.php

+5-1
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,18 @@
1111

1212
namespace Symfony\Component\Lock\Tests\Store;
1313

14+
use Symfony\Bridge\PhpUnit\ForwardCompatTestTrait;
15+
1416
/**
1517
* @author Jérémy Derussé <jeremy@derusse.com>
1618
*
1719
* @requires extension redis
1820
*/
1921
class RedisStoreTest extends AbstractRedisStoreTest
2022
{
21-
public static function setupBeforeClass()
23+
use ForwardCompatTestTrait;
24+
25+
private static function doSetUpBeforeClass()
2226
{
2327
if (!@((new \Redis())->connect(getenv('REDIS_HOST')))) {
2428
$e = error_get_last();

Tests/Strategy/ConsensusStrategyTest.php

+4-1
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,20 @@
1212
namespace Symfony\Component\Lock\Tests\Strategy;
1313

1414
use PHPUnit\Framework\TestCase;
15+
use Symfony\Bridge\PhpUnit\ForwardCompatTestTrait;
1516
use Symfony\Component\Lock\Strategy\ConsensusStrategy;
1617

1718
/**
1819
* @author Jérémy Derussé <jeremy@derusse.com>
1920
*/
2021
class ConsensusStrategyTest extends TestCase
2122
{
23+
use ForwardCompatTestTrait;
24+
2225
/** @var ConsensusStrategy */
2326
private $strategy;
2427

25-
protected function setUp()
28+
private function doSetUp()
2629
{
2730
$this->strategy = new ConsensusStrategy();
2831
}

Tests/Strategy/UnanimousStrategyTest.php

+4-1
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,20 @@
1212
namespace Symfony\Component\Lock\Tests\Strategy;
1313

1414
use PHPUnit\Framework\TestCase;
15+
use Symfony\Bridge\PhpUnit\ForwardCompatTestTrait;
1516
use Symfony\Component\Lock\Strategy\UnanimousStrategy;
1617

1718
/**
1819
* @author Jérémy Derussé <jeremy@derusse.com>
1920
*/
2021
class UnanimousStrategyTest extends TestCase
2122
{
23+
use ForwardCompatTestTrait;
24+
2225
/** @var UnanimousStrategy */
2326
private $strategy;
2427

25-
protected function setUp()
28+
private function doSetUp()
2629
{
2730
$this->strategy = new UnanimousStrategy();
2831
}

0 commit comments

Comments
 (0)