Skip to content

Commit 4e4cc2c

Browse files
Merge branch '4.4' into 5.0
* 4.4: Allows RedisClusterProxy instance in Lock RedisStore
2 parents f571ad4 + 26e443c commit 4e4cc2c

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

Store/RedisStore.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@ class RedisStore implements PersistingStoreInterface
3232
private $initialTtl;
3333

3434
/**
35-
* @param \Redis|\RedisArray|\RedisCluster|\Predis\ClientInterface $redisClient
36-
* @param float $initialTtl the expiration delay of locks in seconds
35+
* @param \Redis|\RedisArray|\RedisCluster|RedisProxy|RedisClusterProxy\Predis\ClientInterface $redisClient
36+
* @param float $initialTtl the expiration delay of locks in seconds
3737
*/
3838
public function __construct($redisClient, float $initialTtl = 300.0)
3939
{
40-
if (!$redisClient instanceof \Redis && !$redisClient instanceof \RedisArray && !$redisClient instanceof \RedisCluster && !$redisClient instanceof \Predis\ClientInterface && !$redisClient instanceof RedisProxy) {
41-
throw new InvalidArgumentException(sprintf('"%s()" expects parameter 1 to be Redis, RedisArray, RedisCluster or Predis\ClientInterface, "%s" given.', __METHOD__, \is_object($redisClient) ? \get_class($redisClient) : \gettype($redisClient)));
40+
if (!$redisClient instanceof \Redis && !$redisClient instanceof \RedisArray && !$redisClient instanceof \RedisCluster && !$redisClient instanceof \Predis\ClientInterface && !$redisClient instanceof RedisProxy && !$redisClient instanceof RedisClusterProxy) {
41+
throw new InvalidArgumentException(sprintf('"%s()" expects parameter 1 to be Redis, RedisArray, RedisCluster, RedisProxy, RedisClusterProxy or Predis\ClientInterface, "%s" given.', __METHOD__, \is_object($redisClient) ? \get_class($redisClient) : \gettype($redisClient)));
4242
}
4343

4444
if ($initialTtl <= 0) {

Tests/Store/StoreFactoryTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,9 @@ public function validConnections()
6161
}
6262
if (class_exists(\Redis::class) && class_exists(AbstractAdapter::class)) {
6363
yield ['redis://localhost', RedisStore::class];
64+
yield ['redis://localhost?lazy=1', RedisStore::class];
65+
yield ['redis://localhost?redis_cluster=1', RedisStore::class];
66+
yield ['redis://localhost?redis_cluster=1&lazy=1', RedisStore::class];
6467
}
6568
if (class_exists(\PDO::class)) {
6669
yield ['sqlite:/tmp/sqlite.db', PdoStore::class];

0 commit comments

Comments
 (0)