Skip to content

Commit b3afc1d

Browse files
committed
minor #59898 replace assertEmpty() with stricter assertions (xabbuh)
This PR was merged into the 7.3 branch. Discussion ---------- replace `assertEmpty()` with stricter assertions | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT In the code we are strict about not using `empty()`. In my opinion it makes sense to be equally strict with our assertions. But I'd like to gather some feedback first before updating all places. Commits ------- 6550cb815e3 replace assertEmpty() with stricter assertions
2 parents 0bd2dac + 791bbf8 commit b3afc1d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Tests/Store/DoctrineDbalStoreTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,6 @@ public function testConfigureSchemaTableExists()
300300
$someFunction = fn () => true;
301301
$dbalStore->configureSchema($schema, $someFunction);
302302
$table = $schema->getTable('lock_keys');
303-
$this->assertEmpty($table->getColumns(), 'The table was not overwritten');
303+
$this->assertSame([], $table->getColumns(), 'The table was not overwritten');
304304
}
305305
}

0 commit comments

Comments
 (0)