Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build with unoptimized shaders for testing #1050

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brakhane
Copy link
Collaborator

Provide a Linux build where shaders have been compiled without optimization. This can be used by testers to rule out problems caused by those.

I don't think it makes sense to provide these for "official" releases, we can always tell people to download the latest nightly build if needed.

@turanszkij
Copy link
Owner

turanszkij commented Jan 31, 2025

This should be PR only, then they can still download them. We can also make temporary shader modifications here if needed for testing.

@brakhane
Copy link
Collaborator Author

I'm not sure I understand correctly. Do you want the changes to be in build-pr, so that every PR in the future will have two builds, or do you want to keep this specific PR unmerged and as a "testing ground" so to speak?

@brakhane brakhane force-pushed the unoptimized-build branch 3 times, most recently from d2fb757 to 7aaf149 Compare January 31, 2025 13:45
@brakhane
Copy link
Collaborator Author

brakhane commented Jan 31, 2025

i've changed it so that it's now in build-pr

@turanszkij
Copy link
Owner

I meant to just keep this pr open as a testing ground. Thanks.

@brakhane brakhane changed the title nightly build: add unoptimized shaders linux build github actions: provide unoptimized shaders in PR builds Jan 31, 2025
Provide a Linux build where shaders have been compiled without
optimization. This can be used by testers to rule out problems caused
by those.
@brakhane brakhane changed the title github actions: provide unoptimized shaders in PR builds build with unoptimized shaders for testing Jan 31, 2025
@brakhane brakhane marked this pull request as draft January 31, 2025 14:20
@brakhane
Copy link
Collaborator Author

OK, I've marked it as draft so as not to confuse people

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants