feat: support rspack native fs watcher #10658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
github-actions
bot
added
the
release: feature
- Updated `Cargo.toml` to include the "time" feature for Tokio. - Refactored `WatcherDirectoriesAnalyzer` to use `WatchTarget` instead of `WatchInfo`. - Introduced `Executor` struct to manage file system event handling and aggregation. - Removed the old `WatcherExecutor` implementation and replaced it with the new `Executor`. - Improved `DiskWatcher` to manage watched paths more effectively. - Enhanced `Trigger` to facilitate dependency resolution for file system events. - Updated the `FsWatcher` struct to integrate the new `Executor` and streamline event processing. - Added detailed documentation for new and modified structs and methods.
GiveMe-A-Name
force-pushed
the
feat/native-watcher
branch
from
9a5391a to
dc9aea0
Compare
- Removed the PathRegister and its associated logic, replacing it with PathManager to manage paths, directories, and missing paths. - Introduced PathAccessor for accessing registered paths. - Updated Analyzer trait to work with the new PathAccessor. - Modified DiskWatcher to handle WatchPattern instead of raw paths. - Enhanced Executor to manage event execution with aggregate handling. - Updated NativeWatchFileSystem to include pause functionality and improved callback handling. - Added tests for PathManager and related structures to ensure correct functionality.
2 tasks
…and add native watcher support in test tools
GiveMe-A-Name
commented
Jun 26, 2025
CodSpeed Performance ReportMerging #10658 will improve performances by 21.32%Comparing 🎉 Hooray!
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ⚡ | js@is css mod |
112.3 µs | 92.6 µs | +21.32% |
Testing in local, notify dependency will increment 200kb size on binary size |
stormslowly
reviewed
Jul 10, 2025
I do a watch diff in my local.
|
stormslowly
previously approved these changes
Jul 11, 2025
GiveMe-A-Name
commented
Jul 11, 2025
hardfist
reviewed
Jul 14, 2025
…tails for `inlineConst` feature
hardfist
reviewed
Jul 14, 2025
hardfist
reviewed
Jul 14, 2025
hardfist
reviewed
Jul 14, 2025
… with added and removed properties
… instead of removedMissingDependencies
hardfist
approved these changes
Jul 15, 2025
hardfist
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivartion
This PR introduces a native file system watcher (NativeWatchFileSystem) to replace NodeWatchFileSystem when enabled via experiments.nativeWatcher: true. The goal is to:
Improve performance during mass file changes (fixing #7490).
Reduce Rspack’s JS/Rust boundary overhead by moving file watching to Rust.
Key Changes
Performance Benefits
Solves watchpack lag when handling large-scale file changes (e.g., git checkout, mass updates).
Rust-native efficiency: Leverages notify for low-overchange detection.
Usage
Enable in rspack.config.js:
Checklist