Skip to content

feat: initialize Rslib built-in plugin #10735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

feat: initialize Rslib built-in plugin #10735

merged 1 commit into from
Jun 24, 2025

Conversation

fi3ework
Copy link
Member

Summary

Initialize Rslib built-in plugin, to fix #10607 as of now.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Jun 19, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 5252cd5
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/685a4bb84b7edb00083a9d82

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Jun 19, 2025
@fi3ework fi3ework mentioned this pull request Jun 19, 2025
Merged
2 tasks
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 19, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10735 will not alter performance

Comparing ww/rslib-plugin (5252cd5) with main (781e5b5)

Summary

✅ 16 untouched benchmarks

@fi3ework fi3ework requested a review from JSerFeng June 19, 2025 15:30
@JSerFeng
Copy link
Contributor

Should we implement this based on ModernModuleLibraryPlugin instead 🤔

@fi3ework
Copy link
Member Author

Should we implement this based on ModernModuleLibraryPlugin instead 🤔

But modern-module will only works with ESM format, require.cache is a CJS method, IMO, it will mostly used in CJS format.

@fi3ework fi3ework force-pushed the ww/rslib-plugin branch 2 times, most recently from df8b4ee to 496ea28 Compare June 23, 2025 03:59
@fi3ework
Copy link
Member Author

Moved Rslib plugin to experiments field to prevent from used by others.

@JSerFeng JSerFeng merged commit 953438b into main Jun 24, 2025
38 checks passed
@JSerFeng JSerFeng deleted the ww/rslib-plugin branch June 24, 2025 08:07
@Timeless0911 Timeless0911 mentioned this pull request Jun 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSerFeng JSerFeng

Assignees
No one assigned
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Generated wrong esm asset
2 participants
@fi3ework @JSerFeng