Skip to content

fix: loaderContext.importModule should return error #10750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025

Conversation

colinaaa
Copy link
Collaborator

Summary

close: #8536

Related links

Fix the wrong test case introduced by #8590

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Jun 20, 2025
Copy link

netlify bot commented Jun 20, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 7f0636e
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68556059d05a530008494a9d

Copy link

codspeed-hq bot commented Jun 20, 2025

CodSpeed Performance Report

Merging #10750 will not alter performance

Comparing colinaaa:colin/0620/import-module (7f0636e) with main (ee7d9bc)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 16 untouched benchmarks

@colinaaa colinaaa marked this pull request as ready for review June 20, 2025 14:10
@chenjiahan chenjiahan requested a review from jerrykingxyz June 23, 2025 02:44
@jerrykingxyz jerrykingxyz merged commit acedc98 into web-infra-dev:main Jun 23, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: loaderContext.importModule does not return error
2 participants