Proposal for better Exceptions #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me. However your previous pull request already added |
|
Will do! |
|
@xPaw Conflict solved! |
|
Hmm, your commit adds same stuff that appeared in previous commits; could you please do a clean force push, so that it doesn't mess with the history? |
|
@xPaw What do you mean? I merged my branch with your upstream/master so the only changes now should be the actual exception changes? |
|
You did merge it, but that created an additional commit with same changes that are already in master branch. This should help: https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request |
|
Fixed |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for better exceptions.
The new exception system will allow extending and derivative software to easily build cases on different exceptions without having to parse the string output of an exceptions.
This change is backwards compatible: applications can still catch for the SourceQueryException, however they can also choose to be more specific and catch specific exceptions instead.
Not that the SourceQueryException has been turned into an abstract class so it cannot be used directly.