Return topic desctuctors #576

vgvoleg · 2025-04-03T16:21:55Z

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Copilot

Pull Request Overview

This PR addresses improper resource cleanup by ensuring that topic writers and readers are properly closed during object finalization. The changes add del methods to both synchronous and asynchronous topic classes and a GRPC helper to invoke proper cleanup routines.

Updated destructors (del) in both sync and asyncio classes to call close(flush=False)
Introduced safeguards in asyncio classes to schedule asynchronous cleanup tasks
Added a del method in a GRPC utility class to clean up executors

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
ydb/_topic_writer/topic_writer_sync.py	Calls close() in del to ensure proper cleanup
ydb/_topic_writer/topic_writer_asyncio.py	Checks loop state and schedules an asynchronous close() call in del
ydb/_topic_reader/topic_reader_sync.py	Calls close() in del for reader cleanup consistency
ydb/_topic_reader/topic_reader_asyncio.py	Schedules an asynchronous close() via create_task() in del and names the task
ydb/_grpc/grpcwrapper/common_utils.py	Adds a del method to clean executors on object deletion

Comments suppressed due to low confidence (2)

ydb/_topic_writer/topic_writer_asyncio.py:87

Scheduling close() using call_soon in a del method without try/except wrapping could lead to unobserved exceptions if the event loop state changes unexpectedly. Consider adding error handling around this call.

self._loop.call_soon(functools.partial(self.close, flush=False))

ydb/_topic_reader/topic_reader_asyncio.py:99

Before scheduling self.close(flush=False) as an asynchronous task, consider checking whether the event loop is still running to prevent potential exceptions if it has already been closed.

task = self._loop.create_task(self.close(flush=False))

ydb/_topic_writer/topic_writer_sync.py

ydb/_topic_reader/topic_reader_sync.py

github-actions · 2025-04-03T16:40:55Z

🌋 Here are results of SLO test for sync-table:

Operation Success Rate

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=read"
    x-axis "Time, m" 0 --> 10
    y-axis "Success Rate, %" 89 --> 111
    line [100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,99.993,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100]

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=write"
    x-axis "	Time, m" 0 --> 10
    y-axis "Success Rate, %" 89 --> 111
    line [100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100]

Operations Per Second

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=read"
    x-axis "Time, m" 0 --> 10
    y-axis "Operations" 817 --> 1096
    line [907.94,940.228,985.172,985.276,982.862,979.241,979,978.138,976.655,981.034,980.517,980.414,980.724,979.379,980.69,979.207,980.862,979.172,980,959.31,961,961.828,960.517,961.31,962.414,962.897,961.483,962.552,961.897,959.862,960.966,960.759,960.655,962.724,967,966.931,969,970.414,969.793,967.724,967.897,966.793,965.069,960.586,963.172,963.862,965.034,964.586,983.931,984.586,982.897,985.448,982.483,982.897,982,983.138,983.793,983.966,985.828,985.862,983.517,982.276,982.655,982.276,981.552,980.966,982.69,981.586,982.966,983.379,984.414,984.69,989.241,989.586,989.897,989.586,989.552,990.448,989.897,989.138,987.172,989.586,987.828,988.483,988.207,988.862,988.621,987.793,987.31,988.862,988.414,987.241,987.586,988.276,989.241,986.897,987.103,987.724,987.724,987.621,989.138,989.034,988.931,989.345,989.517,988.862,988.552,987.828,989.103,987.828,986.759,988.138,988.138,989.207,987.966,988.207,987.862,988.552,989.552,991.207,991.241,989.931,990.103,989.724,987.759,987.586,987.448,986.931,987.207,988.103,988.31,986.828,986.862,985.897,987.448,984.207,984.448,984.966,986.517,984.414,949.828,950.517,946.828,948.379,947.069,946.793,948.276,948.103,947.724,949.966,948.276,948,947.931,950.931,951.103,948.241,948.931,948.759,947.103,946.931,944.966,943.897,944.655,944.069,947.655,947.31,947.483,940.034,941.379,976.897,976.655,978.966,977.828,978.345,979.31,978.724,978.862,978.897,977.828,980.586,981.103,979.448,978.069,976.586,978.862,978.724,977.552,978.172,977.931,981.586,982.034,982.379,981.241,981.655,982.655,982.724,990.31,991.241,990.379,987.69,987.862,988.448,989.276,989.828,988.621,988.448,988.862,988.793,988.414,988.345,991.172,992.448,994.138,994.793,994.69,996.172,994.724,995.069,994.931,991.552,991.276,986.103,986.448,985.966,984.621,984.483,986.345,985.966,987.828,988.103,987.172,987.483,986.517,987.241,985.966,985.448,985.759,985.483,984.793,984.379,984.862,982.897,984.517,983.345,983.241,984.586,984.448,983.793,987.655,987.345,992.103,990.207,984.621,986.379,986.414,985.241,985.379,986.103,986.31,987.034,986.759,987.69,986.931,988.276,988.793,984.207,983.552,984.276,976.448,976.103,978.207,976.621,977.862,977.793,977.862,977.828,978.345,977.897,977.448,979.172,967.207,973.172,971.621,971.966,972.138,971.69,971.793,971.241,971.103,970.483,969.897,970.241,968.966,967.655,972,972.828,972.241,978.69,978.724,977.862,975.966,975.759,975.31,975.034,974.276,974.379,974.655,976,974.379,987.897,986.379,986.241,985.897,985.724,986.034,984.138,983.621,983.172,983.276,983.517,982.966,983.517,984.793,983.517,984.586,984.448,987.241,986,985,987.655,986.931,983.931,982.138,983.759,983.276,983.172,982.379,981.207,980.655,981.345,982.517,981.862,980.69,980.103,981.414,981.828,983.207,983.241,983.828,982.552,983.241,983,984.724,982.966,983.759,981.724,982.069,979.655,978.897,979.828,983.172,985.276,984.483,984.862,985.034,985.483,987.172,986.621,987.517,986.724,988.034,989.483,989.966,990.621,988.414,987.793,987.69,987.517,988.069,988.31,988.69,987.759,988.69,988.621,989.138,990.69,994.345,993.241,993.241,990.931,990.172,989.586,989.276,989.414,987.655,988.517,988,988.31,988.724,988.483,987.379,987.724,987.862,990.207,988.759,989.345,989.966,990.207,989.69,990.586,987.862,987.517,986.931,986.655,985.793,985.966,988.172,986.345,988.862,989.379,988.069,988.448,988.31,989.931,990.034,991.138,990.552,990.862,989.828,990.345,991,984.069,982.034,983.931,982.931,982.552,982.966,982.276,981.345,984.241,971.69,971.966,971.724,971.345,971.793,971.241,972.586,972.414,971.793,973.276,972.793,972.724,973.793,972.759,973,973.138,972.793,973.483,974.345,972.931,980.414,982.621,981.31,979.483,973.655,974.069,975.138,975.069,975.069,983.517,982,982.828,977.276,977.103,976.897,970.759,962.828,963.138,963.931,963.69,963.345,963,963.172,963.586,962.517,963.483,963.345,964.448,964.103,961.517,963.138,963.345,960.931,967.31,966.483,966.414,965.276,966,971,972.31,971.69,976.966,975.276,974.345,982.103,990,990.414,989.172,989.31,989.724,985.241,985.103,985.31,986.241,985.483,985.552,983.552,984.207,985.931,984.655,984.862,989.793,988.724,987.483,985.517,986.931,985.655,985.207,985.517,983.793,984.31,985.862,985.931,985.172,984.931,985.379,986.552,984.414,985.034,987.31,986.69,986.034,987.379,986.793,986.345,986.862,988.483,987.034,986.966,987.552,987.276,987.621,990.483,992.483,992.172,992.621,992.828,992.621,992.448,992.379,992.276,991.862,991.724,991.966,991.586,991.207,993.483,992.828,993.172,994.621,993.897,991.966,993.207,971.77,938.251]

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=write"
    x-axis "Time, m" 0 --> 10
    y-axis "Operations" 67 --> 102
    line [82.447,85.788,90.172,90.172,90.172,90.172,86.793,86,87.069,86.724,83.31,83.31,83.31,83.31,83.31,83.31,83.31,83.241,83.207,83.207,82.517,82.517,82.517,82.517,82.517,82.517,82.517,85.759,82.414,82.345,82.345,82.345,82.31,78.931,78.931,82.31,83.103,85.345,82.276,85.69,85.69,85.69,85.69,85.69,85.69,82.345,85.759,85.759,85.759,86.448,86.448,86.448,86.414,86.448,85.655,85.897,84.345,86.414,86.448,86.483,86.483,86.552,86.517,86.517,86.483,83.069,83.103,86.517,86.517,86.517,86.517,84.759,84.759,84.793,88.034,87.034,87.069,86.759,86.724,86.793,86.828,86.897,86.897,87.655,84,85.586,86.862,86.828,86.793,86.793,86.759,86.793,86.759,83.414,86.828,86.828,86.828,86.828,86.828,83.862,85.345,85.345,85.31,85.414,86.414,86.379,86.69,86.724,86.655,86.621,83.241,83.207,83.241,86.655,86.621,86.621,86.621,83.241,83.276,83.276,86.655,86.69,90.069,90.069,89.034,86.724,86.724,86.724,89.69,89.966,89.966,89.966,89.931,89.966,89.966,88.966,86.586,85.828,85.828,88.103,84.828,84.897,84.931,81.552,81.552,81.552,84.931,84.897,84.897,84.931,81.655,81.655,81.655,82.69,81.586,81,80.931,80.931,80.621,78.207,78.207,78.207,74.759,74.759,75.759,78.138,78.897,77.483,76.586,79.897,79.828,79.793,81.793,79.828,79.759,79.759,76.379,76.379,76.345,79.621,79.621,79.621,79.621,83.034,80.345,80.448,80.448,80.759,83.172,83.172,83.207,83.241,83.276,83.276,83.276,83.276,84.69,86.655,86.621,83.241,83.276,84.655,86.621,86.69,83.345,86.69,86.724,86.724,86.724,86.724,86.724,86.31,85.966,89.31,88.759,87.828,86.586,86.552,83.138,83.172,86.552,85.586,85.931,83.172,83.172,83.207,83.276,83.276,86.655,86.552,85.069,83.241,83.31,86.69,86.621,86.552,86.621,86.586,83.31,83.31,83.724,84.034,80.552,81.103,82.034,83.276,83.31,86.724,83.345,83.345,84.276,83.931,86.69,86.69,86.655,86.586,86.586,86.586,86.655,84.862,86.724,86.655,86.621,86.724,86.103,85.517,85.276,88.103,88,87.207,87.241,90.069,90,90.069,89.586,89.138,89.069,91.793,91.621,91.483,90.759,90.897,90.138,90.103,90.034,90.103,90.138,86.724,90,89.931,89.931,86.517,83.414,83.759,84.276,84.517,85,85,85.759,85.621,86.034,86.034,84.655,83.552,84.034,84.138,84.759,82.586,81.724,82.483,82.655,83.103,83.207,83.103,83.034,83,86.414,86.069,85.828,85.724,89.207,92.103,90.966,89.931,89.897,86.483,86.586,86.621,86.759,86.931,86.966,88.276,86.448,86.414,86.379,86.379,88.69,89.724,89.69,89.379,88.724,86.276,86.483,86.483,86.552,86.552,86.897,87.172,87.276,86.586,84.172,85.552,86.655,86.724,90.103,86.759,86.69,83.31,83.31,83.31,83.31,86.724,86.724,86.724,86.724,86.759,83.552,83.552,83.586,84.517,86.897,86.862,86.862,86.793,86.793,83.414,80,80,80.586,79.793,80,79.793,79.793,79.793,83.138,83.31,86.655,86.655,83.276,83.31,83.31,83.31,83.31,83.31,83.103,86.414,83,80.897,80.724,80.828,79.655,79.621,79.724,79.724,79.69,79.724,79.724,79.759,83.172,83.034,83.207,83.207,83.172,82.828,79.759,79.759,79.724,81.931,81.966,81.621,80.345,79.793,79.724,79.931,78.207,81.517,83.345,82.138,78.621,79.793,79.828,79.724,79.655,79.655,79.621,79.621,79.621,79.621,79.621,79.586,78.241,78.207,76.621,79.586,79.621,79.655,80.828,80.759,79.759,80.966,79.69,79.793,79.793,81.379,81.483,81.724,79.793,83.138,79.759,79.759,79.759,79.828,83.241,86.655,86.655,86.655,83.31,83.31,83.31,84.655,84.724,86.655,86.655,86.655,86.655,86.655,86.655,88,87.655,86.621,86.621,86.621,86.621,86.621,83.207,83.138,83.207,86.586,86.586,86.586,86.586,86.586,86.586,83.345,83.345,86.69,86.69,86.69,86.69,86.69,86.69,86.724,84.034,83.379,83.379,83.379,83.345,83.759,83.207,83.172,83.172,83.172,83.172,86.586,90,86.621,86.655,86.655,86.655,86.655,86.655,86.586,86.414,85.241,84.69,84.655,83.103,79.69,79.69,79.69,79.586,78.897,79.552,79.552,79.552,79.586,79.586,83,83,83,80.483,80.448,77.069,77.069,80.448,80.414,80.414,80.414,80.414,80.414,77.138,80.483,78.276,78.828,78.862,80.414,83.828,80.414,80.103,79.828,83,80.448,80.448,80.448,80.448,80.448,80.448,80.448,77.517,79.586,79.31,82.621,82.724,80.32,76.957]

95th Percentile Latency

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=read"
    x-axis "Time, m" 0 --> 10
    y-axis "Latency, ms" 8 --> 17
    line [11.995,12.071,11.875,11.846,12.269,12.216,12.06,11.644,11.835,11.807,11.183,11.685,11.913,12.211,12.583,13.007,12.784,12.63,12.517,12.855,12.875,13.147,13.159,13.139,13.297,13.597,13.595,13.848,13.879,14.124,14.126,14.368,14.435,14.088,14.244,14.344,14.387,14.229,14.246,14.449,14.453,14.636,14.629,14.697,14.632,14.588,14.832,14.881,14.762,14.667,14.432,14.457,14.444,14.375,14.219,14.121,13.969,13.986,13.844,13.962,13.944,13.996,13.996,13.942,13.829,13.695,13.683,13.842,13.776,13.634,13.388,13.314,13.24,13.158,13.284,12.955,12.716,12.521,12.493,12.851,12.834,13.071,13.157,13.08,12.972,13.117,13.206,12.959,12.651,12.419,12.309,12.481,12.727,12.645,12.914,12.93,12.973,13.21,13.22,13.074,13.098,13.168,13.067,13.09,13.156,13.15,13.033,13.104,12.847,12.849,12.54,12.926,13.259,13.539,13.459,13.464,13.792,13.694,13.751,13.733,13.716,13.48,13.594,13.681,13.883,13.848,13.767,13.734,14.018,13.956,13.787,13.883,13.716,13.783,13.849,14.013,13.962,13.921,13.872,14.106,13.909,13.668,13.8,13.708,13.565,13.2,13.179,12.956,12.825,12.942,12.774,12.882,12.706,12.386,12.065,12,12.125,11.938,12.159,12.19,11.845,11.919,11.743,11.595,11.46,11.231,10.965,10.958,10.796,10.852,11.075,10.653,10.784,11.001,11.148,11.738,11.702,11.938,11.899,12.088,12.057,12.11,12.285,12.482,12.281,12.198,11.943,11.768,11.554,11.537,11.533,11.409,11.414,11.642,11.769,12,11.854,11.563,11.301,11.055,11.083,11.18,11.195,11.247,10.626,11.328,11.373,11.353,11.329,11.125,10.877,10.58,10.368,10.254,9.991,9.954,9.954,10.21,10.136,10.212,10.786,11.094,11.08,11.02,11.173,11.43,11.626,11.89,11.874,11.694,11.538,11.566,11.82,12.041,11.612,11.345,11.146,11.022,10.84,11.087,11.221,11.19,11.375,11.387,11.549,11.544,11.321,11.492,11.16,11.04,10.899,11.064,11.538,11.767,11.827,12.033,12.019,12.037,11.897,11.728,11.681,11.306,11.133,11.136,11.496,11.824,12.071,12.42,12.391,12.65,12.978,13.066,13.386,13.466,13.51,13.461,13.47,13.514,13.289,13.167,13.02,13.031,13.009,12.926,12.806,12.817,12.837,12.886,13.149,13.075,13.173,13.111,13.014,13.058,12.953,12.88,12.84,12.914,12.881,12.712,12.83,12.845,12.998,12.987,13.169,13.296,13.498,13.475,13.502,13.388,13.005,12.926,13.123,12.991,13.15,13.469,13.848,13.943,14.044,14.091,14.302,14.465,14.334,14.339,14.181,13.974,13.979,14.039,14.18,14.143,14.122,14.185,14.182,14.217,14.251,14.252,14.36,14.425,14.497,14.591,14.502,14.277,14.455,14.467,14.171,13.787,13.464,13.238,12.962,12.856,12.822,13.083,13.099,13.123,13.152,12.793,12.5,12.012,12.061,11.902,11.901,12.112,12.071,12.009,12.125,12.227,11.941,11.684,11.487,11.192,10.997,10.341,10.039,10.494,10.859,10.966,10.919,11.062,10.857,10.473,10.024,9.973,10.01,10.33,10.889,10.9,11.03,11.083,10.556,10.302,10.39,10.449,10.46,10.11,9.996,10.169,10.174,10.35,10.834,11.207,11.506,11.52,11.762,11.541,11.448,11.443,11.827,12.264,12.471,12.44,12.389,12.371,12.314,12.084,11.965,12.155,12.018,12.193,12.052,11.642,11.255,11.165,11.43,11.714,11.729,11.848,11.805,11.598,11.232,10.908,10.811,10.523,10.959,11.167,11.354,11.321,10.895,11.095,11.131,11.131,11.464,11.682,11.699,11.927,11.849,11.713,11.577,11.424,11.381,11.416,11.204,11.038,10.829,10.74,10.775,10.966,10.683,11.057,10.995,10.967,10.915,10.625,10.9,10.869,10.641,10.955,10.607,10.875,11.244,11.058,10.825,10.841,10.725,10.928,11.113,11.284,11.853,12.408,12.429,12.436,12.297,12.315,12.443,12.434,12.164,12.206,12.471,12.973,12.98,13.14,13.251,13.277,13.58,13.434,13.406,13.513,13.432,13.408,13.48,13.562,13.535,13.491,13.262,13.281,13.325,12.992,12.618,12.468,12.349,12.514,12.568,12.829,13.017,13.265,13.496,13.079,12.879,12.699,12.441,12.441,12.348,11.95,11.931,11.887,12.145,12.282,12.164,11.83,12.007,12.258,12.457,12.426,12.397,12.5,12.458,12.395,12.486,12.843,12.839,12.739,12.392,12.277,11.9,11.825,11.872,11.579,11.605,11.441,11.31,11.355,11.226,11.643,11.297,10.941,10.632,10.442,10.683,9.991,9.942,9.917,9.979,9.927,9.868,9.877,9.863,9.884,9.852,9.808,9.758,9.794,9.698,9.732,9.657,9.709,9.755]

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=write"
    x-axis "Time, m" 0 --> 10
    y-axis "Latency, ms" 15 --> 22
    line [17.736,17.621,17.607,17.553,17.77,17.798,17.861,17.658,17.712,17.638,17.225,17.276,17.44,17.534,17.696,17.995,17.694,17.696,17.655,17.914,17.767,18.074,18.198,18.211,18.289,18.434,18.517,18.518,18.6,18.813,18.87,19.017,19.017,19.007,19.076,19.058,19.04,18.976,19.034,19.007,19.06,19.16,19.19,19.19,19.184,19.223,19.239,19.248,19.172,19.104,18.989,19.029,18.999,18.961,18.907,18.824,18.816,18.787,18.752,18.79,18.748,18.799,18.798,18.804,18.767,18.824,18.847,18.854,18.877,18.841,18.721,18.709,18.739,18.71,18.718,18.627,18.544,18.505,18.59,18.659,18.566,18.722,18.767,18.752,18.798,18.809,18.844,18.721,18.644,18.536,18.486,18.485,18.542,18.587,18.606,18.62,18.621,18.647,18.667,18.662,18.676,18.758,18.728,18.774,18.76,18.745,18.723,18.661,18.664,18.717,18.634,18.739,18.846,18.856,18.856,18.828,18.944,18.991,19.064,19.054,18.998,18.874,18.813,18.769,18.801,18.825,18.866,18.834,18.887,18.849,18.739,18.71,18.612,18.644,18.648,18.699,18.746,18.746,18.717,18.807,18.734,18.654,18.667,18.677,18.627,18.456,18.371,18.199,18.192,18.285,18.366,18.48,18.56,18.492,18.443,18.397,18.552,18.582,18.712,18.758,18.722,18.692,18.703,18.732,18.681,18.568,18.426,18.474,18.4,18.333,18.312,18.258,18.299,18.389,18.412,18.611,18.693,18.786,18.852,18.853,18.904,18.965,19.016,19.004,18.989,18.999,18.906,18.845,18.768,18.877,18.919,18.92,18.968,19.044,19.078,19.145,19.107,19.03,19.032,19.08,19.056,19.019,19.015,19.082,19.042,19.133,19.099,19.1,19.143,19.101,19.043,19.009,18.969,18.906,18.77,18.73,18.793,18.885,18.865,18.963,19.055,19.152,19.151,19.185,19.227,19.29,19.336,19.421,19.38,19.39,19.412,19.458,19.495,19.506,19.424,19.4,19.341,19.292,19.304,19.325,19.321,19.337,19.4,19.44,19.43,19.381,19.373,19.374,19.345,19.333,19.291,19.315,19.357,19.354,19.37,19.427,19.416,19.425,19.402,19.418,19.386,19.309,19.23,19.2,19.275,19.355,19.393,19.404,19.347,19.406,19.427,19.403,19.442,19.474,19.515,19.522,19.508,19.494,19.403,19.314,19.277,19.252,19.387,19.384,19.379,19.363,19.355,19.413,19.473,19.439,19.475,19.534,19.588,19.61,19.593,19.592,19.616,19.7,19.75,19.752,19.767,19.736,19.753,19.768,19.747,19.793,19.792,19.823,19.897,19.875,19.833,19.713,19.674,19.608,19.648,19.716,19.732,19.699,19.725,19.72,19.728,19.708,19.69,19.721,19.678,19.659,19.659,19.632,19.694,19.679,19.752,19.76,19.734,19.762,19.747,19.765,19.777,19.724,19.747,19.773,19.804,19.832,19.836,19.836,19.772,19.712,19.664,19.63,19.59,19.57,19.616,19.631,19.598,19.599,19.551,19.51,19.468,19.395,19.4,19.278,19.275,19.283,19.195,19.159,19.114,19.106,19.071,19.004,18.978,18.821,18.712,18.599,18.458,18.642,18.792,18.874,18.952,18.988,18.92,18.876,18.791,18.743,18.749,18.855,18.932,18.929,18.902,19.009,19.029,19.031,19.036,19.143,19.16,19.155,19.138,19.119,19.16,19.234,19.276,19.34,19.412,19.451,19.533,19.475,19.475,19.474,19.582,19.7,19.668,19.643,19.646,19.659,19.607,19.587,19.614,19.645,19.567,19.534,19.494,19.463,19.419,19.436,19.47,19.518,19.562,19.539,19.497,19.492,19.492,19.411,19.315,19.084,19.057,19.057,19.058,18.987,18.838,18.864,18.885,18.825,18.934,19.031,18.994,19.013,19.065,19.086,19.071,19.044,19.095,19.109,19.08,19.153,19.152,19.1,19.119,19.128,19.152,19.146,19.212,19.25,19.338,19.357,19.368,19.308,19.243,19.279,19.29,19.365,19.48,19.384,19.308,19.27,19.185,19.155,19.101,19.096,19.276,19.278,19.224,19.191,19.078,19.018,19.063,19.038,19.011,19.012,19.104,19.242,19.231,19.21,19.258,19.264,19.46,19.51,19.568,19.564,19.528,19.525,19.576,19.606,19.609,19.65,19.64,19.718,19.762,19.62,19.642,19.636,19.644,19.632,19.647,19.711,19.716,19.708,19.713,19.695,19.631,19.613,19.603,19.623,19.602,19.465,19.467,19.387,19.466,19.539,19.494,19.504,19.572,19.659,19.702,19.7,19.681,19.729,19.733,19.688,19.678,19.688,19.696,19.69,19.62,19.664,19.671,19.649,19.591,19.518,19.536,19.501,19.472,19.478,19.528,19.502,19.496,19.41,19.296,19.273,19.245,19.172,19.121,19.148,19.138,19.069,18.949,18.966,18.937,19.004,18.966,18.928,18.904,18.965,18.845,18.807,18.735,18.801,18.868]

github-actions · 2025-04-03T16:40:55Z

🌋 Here are results of SLO test for sync-query:

Operation Success Rate

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=read"
    x-axis "Time, m" 0 --> 10
    y-axis "Success Rate, %" 60 --> 111
    line [100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,99.178,97.861,97.311,96.748,96.208,95.659,95.095,94.494,93.914,93.367,92.794,92.221,91.645,90.999,90.401,89.831,89.219,88.576,87.983,87.443,86.819,86.153,85.509,84.89,84.255,83.597,83.016,82.415,81.754,82.358,83.19,83.204,83.256,83.222,83.23,83.185,83.211,83.274,83.274,83.264,83.173,83.131,83.132,83.126,83.057,83.123,83.15,83.114,83.04,83.058,82.972,83.009,83.013,83.008,83.01,83.011,83.012,83.048,83.042,83.018,82.862,80.663,79.802,79.778,79.74,79.71,79.665,79.682,79.756,79.827,79.885,79.908,79.932,79.999,80.016,80.056,80.112,80.146,80.206,80.317,80.307,80.295,80.378,80.386,80.419,80.389,80.411,80.457,80.43,80.612,82.755,83.606,83.568,83.619,83.609,83.611,83.57,83.522,83.569,83.573,83.603,83.607,83.592,83.596,83.604,83.631,83.553,83.532,83.511,83.502,83.515,83.443,83.511,83.473,83.565,83.494,83.437,83.506,83.457,83.513,83.493,83.106,82.596,81.98,81.44,80.891,80.309,79.694,79.126,78.575,78.029,77.45,76.9,76.287,75.714,75.206,74.659,74.135,73.618,73.057,72.416,71.863,71.313,70.667,70.064,69.543,68.932,68.458,67.843,67.422,67.294,67.266,67.296,67.322,67.329,67.353,67.352,67.387,67.386,67.39,67.461,67.424,67.416,67.439,67.406,67.345,67.314,67.313,67.305,67.333,67.31,67.317,67.501,68.052,68.562,69.15,69.697,70.253,70.808,71.407,71.959,72.48,72.988,73.563,74.097,74.697,75.214,75.634,76.086,76.584,77.124,77.73,78.278,78.827,79.38,79.889,80.468,81.082,81.589,82.116,82.709,83.095,83.104,83.086,83.128,83.097,83.076,83.075,82.984,82.893,82.813,82.823,82.831,82.839,82.859,82.87,82.899,82.893,82.908,82.913,82.849,82.861,82.812,82.793,82.765,82.794,82.717,82.685,82.683,82.654,82.648,82.634,82.593,82.475,82.571,82.592,82.569,82.618,82.634,82.701,82.694,82.669,82.655,82.635,82.581,82.662,82.724,82.764,82.758,82.828,82.806,82.885,82.917,82.967,82.889,82.846,82.949,82.945,83.006,83.081,83.088,83.139,83.184,83.142,83.119,83.104,83.089,83.116,83.117,83.129,83.143,83.232,83.213,83.23,83.206,83.194,83.168,83.179,83.119,83.062,83.023,83.035,83.063,83.069,83.142,83.119,83.153,83.109,83.139,83.121,83.142,83.223,83.187,83.157,83.108,83.122,83.051,83.089,83.054,83.011,83.394,83.98,84.621,85.214,85.832,86.466,87.105,87.728,88.364,88.969,89.548,90.124,90.743,91.309,91.898,92.441,93.003,93.521,94.086,94.652,95.133,95.703,96.32,96.951,97.574,98.182,98.689,99.267,99.838,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100]

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=write"
    x-axis "	Time, m" 0 --> 10
    y-axis "Success Rate, %" 71 --> 111
    line [100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,99.92,99.881,99.881,99.881,99.881,99.881,99.886,99.881,99.881,99.881,99.881,99.881,99.883,99.88,99.88,99.881,99.881,99.881,99.881,99.881,99.881,99.885,99.885,99.881,99.881,99.881,99.881,99.881,99.881,99.962,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,99.007,98.011,97.89,97.069,96.029,95.209,94.476,93.575,93.123,92.582,91.864,91.017,90.239,89.325,89.057,88.362,87.49,86.793,86.13,85.881,85.028,84.317,83.774,83.849,83.758,83.128,82.302,81.508,80.722,80.695,80.729,80.628,80.644,80.876,80.958,80.793,80.57,80.463,80.284,80.168,80.059,80,79.917,79.792,80.017,80.314,80.223,80.237,80.008,80.057,80.05,80.438,81.025,81.804,82.409,83.112,83.72,84.291,85.175,86.148,86.884,87.639,88.103,88.753,89.556,90.551,91.316,92.19,92.543,93.191,93.951,94.678,95.478,95.986,96.545,97.297,98.091,99.006,99.763,99.847,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100]

Operations Per Second

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=read"
    x-axis "Time, m" 0 --> 10
    y-axis "Operations" 319 --> 786
    line [656.325,679.148,702.714,709.345,708.897,712.69,712.414,711.517,711.448,713.034,712.724,710.69,710.517,712.138,711.897,710.138,710.793,710.517,710.793,707.759,709.034,696.034,693.207,691.172,691.414,687.483,683.931,684.793,685.724,684.414,683.069,679,677.31,676.069,670.828,668.517,666.655,664.966,662.828,660.828,662.621,659.793,654.448,652.724,649.966,648.034,646.448,645.655,647.103,643.69,654.966,653.759,653.276,654.483,656.241,655.103,652.552,650.655,651.276,653.345,655.207,653.724,653.931,653.552,654.759,656.759,656.483,656.897,656.517,653.483,654.379,654.103,654.103,654.655,656.483,656.379,655.379,652.379,652.552,651.931,653.241,648.897,640.724,638.517,639.621,638.759,636.966,636.931,634.552,636.724,638.276,636.517,636.379,635.586,633.241,636.897,636.448,636.655,636.724,636.724,636.828,634.759,634.345,631.759,631.138,633.621,633.69,633.724,634.31,633.276,638.31,642.276,642.586,641.931,645.621,646.276,645.31,645.586,642.862,641.966,642.552,644.586,643.448,644.345,641.345,640.828,641.862,644.483,643.69,643.483,645.207,645.31,647.931,648.69,645.966,645.793,649.276,651,651.655,650.759,652.552,651.345,651.31,649.069,652.517,653.241,653.414,655.138,656,656.828,655.379,657.931,657.862,657.862,658.897,658.379,657.414,659.69,660.724,661.621,663.862,661.69,662.276,664,665.379,662.793,664.241,665.069,666.207,665.69,667.69,668.862,668.931,668.069,668.276,671.586,671.138,671.103,671.724,671.172,669.448,673.138,673.552,673.069,674.379,673.483,672.345,672.448,672.517,671.414,670.724,670.034,671.862,672.172,671.241,668.31,668.31,668.655,670.724,673.069,672.828,672.172,669.483,669.172,666.379,666.276,666.138,665.552,666.138,665.759,662.517,663.862,664.103,665.31,665.276,664.897,665.103,665.034,663.862,664.345,665,661.483,659.862,659.414,658.897,659.31,659.138,658.931,657.448,658,657.517,658.862,658.276,658.552,658.655,658.448,658.655,658.345,659.138,658.724,655.862,655.828,653.276,652.828,653.31,652.828,653.138,654.414,653.793,656.103,656.621,656.793,657.655,657.276,656.207,657.034,657.828,656.793,656.034,657.069,656,656.552,655.207,657.862,658.276,658.034,658.31,657.69,658.414,658.966,659.862,660.207,662.655,661.897,662.414,661.793,660.931,661.517,659.31,659.655,660.345,661.862,661.172,661.31,660.483,657.966,658.172,658.621,660.276,660.931,662.241,662.552,658.897,659.172,659.207,659.103,659.655,659.241,659.483,658.759,657.379,657.276,656.517,656.379,656.207,656.172,658.966,658.241,658.172,657.517,656,657,656.069,656.517,656.552,657.103,660.103,658.379,658,657.655,657.828,659.517,659.31,661.448,663,665.172,666.793,670.138,671.276,674.172,672.724,676.31,676.655,681.31,683.241,681.828,683.345,683.069,686.621,688.621,693.793,695.793,695.724,697.207,697.724,696.448,697.931,699.621,701.207,703.483,703.793,705.862,704.345,704.172,707,707,705.414,705.241,704.034,705,703.897,705.966,703.586,703.69,708.103,708.621,710.655,708.207,707.724,704.759,706.138,707.103,709.207,711.207,711.724,712.448,712.414,711.586,712.138,712.621,711.414,712.931,712.966,709.862,708.897,709.172,712.172,712.793,713.172,713.69,712.207,713.138,713.655,712.103,711.69,711.138,710.966,710.724,710.862,709.655,708.724,706.69,707.621,707.621,706.414,706.517,706.172,705.552,705.621,707.966,707.552,710.931,709.793,709.862,708.897,705.69,706.276,707.069,708.897,712.759,710.345,709.414,704.414,704.207,704.241,706,708.379,711.172,710.241,710.897,710.483,708.828,707.448,707.103,706.828,706,705.552,708.69,706.828,707.483,704.31,705.345,705,708.586,707.966,708.138,706.207,704.207,700.966,701.724,701.034,704.724,705.276,707.586,706.862,705.862,703.034,703.172,702.724,705.414,705.276,705.483,704.448,704.069,706.276,708.724,705.552,705.759,704.552,704.69,704.138,706.207,703.034,705.828,706.034,707.345,707.172,708.034,708.379,708.897,706.931,706.276,704.241,704.724,703.414,702.724,706.034,706.448,704.724,704.172,704.138,704.621,707.414,705.103,703.31,702.897,702.345,702.172,701.448,701.345,703.034,703.034,700.483,699.414,698.345,697.31,695.69,694.862,694.586,696.828,697.069,696.793,695.793,696,696.448,693.966,696.483,695.621,696.241,696.207,697.172,693.517,694.655,694.931,695.724,694.828,699.034,699.31,699.483,697.828,697.586,698.345,697.621,697.138,698.276,700.586,701.034,701.931,700.621,703.897,702.966,703.138,702.31,702.241,702.103,698.793,698.897,698.138,697.897,698.276,699.862,698.483,697.276,695.483,697.414,696.276,696.379,696.172,693.621,693.862,694.586,695.103,696.724,697.483,695.69,695.276,694.759,694,693.897,694.448,694.966,695.517,694.931,676.235,653.938,631.192,608.097,585.458,561.946,538.678,516.959,493.942,471.776,447.948,422.157,399.102,376.444,354.768]

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=write"
    x-axis "Time, m" 0 --> 10
    y-axis "Operations" 39 --> 104
    line [82.985,86.329,90.207,90.207,90.069,86.931,86.931,86.931,86.931,86.931,86.931,87.759,88.379,84.862,85.172,86.862,86.828,86.793,86.31,89.655,88.759,87.138,86.793,86.793,85.897,86.724,88.483,86.586,83.759,83.621,83.759,83.552,83.448,83.621,86.517,86.483,86.552,86.586,86.517,86.483,83.172,83.207,86.586,86.552,86.552,86.552,86.586,86.552,83.69,84.621,86.241,86.586,86.586,84.931,84.552,84.793,86.655,89.483,89.69,86.138,86.379,86.483,86.448,86.69,86.724,84.724,84.379,84.103,83.862,87.034,86.931,86.897,86.897,86.931,83.586,83.586,84.069,86.966,86.931,86.931,86.931,86.931,86.207,87.103,87.103,87.103,87.103,87.034,90.448,87.069,87.069,87.069,87.069,87.069,88.793,85.966,86.31,86.586,86.724,86.793,86.828,86.828,86.793,90.138,90.034,86.793,86.793,86.793,86.793,86.793,86.793,90.069,89.966,89.966,86.621,86.621,86.621,86.621,89.966,89.966,89.966,86.621,86.621,86.828,89.966,89.966,89.931,86.552,86.552,86.552,86.552,85.966,83.276,83.345,86.621,86.621,83.207,80.103,79.862,79.828,79.828,79.793,79.897,83.207,80.069,80,79.897,79.897,79.897,79.966,83.241,81.345,81.379,81,80.897,80.759,84.138,83.552,83.517,83.552,83.034,85.483,84.759,83.552,83.517,86.897,86.621,86.862,86.897,86.897,86.931,85.379,85.172,86.69,86.759,83.483,83.483,83.483,83.414,83.483,85,82.069,82.483,82.586,82.759,82.759,83.345,83.379,83.345,84.448,84.69,85.069,83.31,83.379,83.414,86.793,86.448,85.759,84.724,83.414,84.897,85.138,86.759,86.759,90.138,90.138,90.138,90.138,90.138,90.517,93.414,90.138,90.069,86.828,86.931,86.759,86.828,86.759,86.69,86.69,87.138,90,90.034,90,90,88.69,89.103,89.759,90.138,90.069,90.034,88.379,88.103,88.31,88.276,88.138,87.759,87.414,87.414,87.276,90.483,90.621,93.862,93.483,93.586,93.276,93.414,93.483,93.414,90,90.103,90.034,90.069,90.069,91.379,91.207,89.172,90.103,90.138,90.172,91.828,92.103,91.897,88.69,88.828,89.207,89.552,89.552,89.69,89.724,89.655,89.655,86.552,86.655,86.897,86.828,86.828,86.897,90.241,90.207,88.966,87,87,87.345,87.793,90.207,90.207,90.103,87.517,86.931,85.034,84.931,88.138,88.138,87.897,87.897,87.483,87.138,86.862,86.793,86.793,86.793,86.759,86.759,86.759,86.759,83.414,83.414,83.414,84.655,86.621,86.621,86.621,86.621,86.621,86.621,83.483,86.069,86.655,88.552,88.655,88.69,88.69,88.931,88.483,88.517,88.655,86.69,86.759,86.759,90.138,90.138,90.138,86.793,86.793,90.138,90.138,90.138,90.138,90.138,86.793,86.793,86.793,86.793,86.793,90.034,90.034,90.034,90.034,90.034,90.034,90.034,90.034,90.483,87.483,87.724,89.966,89.966,89.655,89.517,89.379,88.448,89.931,89.897,86.517,86.517,86.517,86.517,86.517,89.897,88.931,88.828,86.621,83.483,83.655,83.31,83.241,83.241,81.517,81.172,81.172,81.138,80.655,83.31,83.241,83.276,79.862,80.172,80.31,80.448,81.379,81.31,79.897,79.862,79.862,79.862,79.862,79.862,79.828,80.793,80.897,83.103,83,82.966,83.207,83.276,83.276,84.483,83.586,82,81.966,79.069,79.793,79.828,79.793,83.207,83.207,81.931,79.828,76.414,78.345,79.793,83.207,83.207,83.207,82.138,79.931,76.517,76.517,76.517,76.517,79.759,79.621,79.724,79.724,79.724,80.241,78.103,79.724,79.793,83.172,83.172,83.172,79.759,79.759,79.759,81.034,83.138,86.552,86.552,86.552,84.276,83.276,80.828,81.828,83.172,86.586,86.586,86.586,84.103,83.207,83.241,83.241,83.207,83.172,80.379,83.241,83.241,83.241,83.241,83.034,82.345,85.448,83.207,83.207,83.207,83.207,81.759,81.828,81.276,83.138,83.724,86.069,86,86.586,86.586,83.724,83.31,85.759,86.621,86.621,86.586,83.31,83.276,86.069,86.586,86.552,86.552,86.552,86.759,84.069,84.414,86.655,86.655,86.655,86.655,88.103,88.034,87.759,86.138,86.034,85.931,85.759,85.966,85.793,88.69,86.517,86.483,86.586,86.552,86.241,89.345,89.069,87.759,86.586,86.655,83.241,83.241,83.241,86.621,86.586,86.586,86.621,86.621,86.621,84.517,84.345,85.172,86.138,83.241,83.448,83.759,83.828,84,83.966,86.552,86.621,86.552,86.552,86.897,87.103,87.448,88.345,89.069,88.897,90,90,90,90,90,90,89.966,88.897,86.621,88.724,88.897,88.897,89.966,89.966,90,90,90,90,87.187,83.838,80.489,77.138,73.786,70.432,67.076,63.718,60.781,57.879,54.622,53.643,50.281,46.916,43.546]

95th Percentile Latency

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=read"
    x-axis "Time, m" 0 --> 10
    y-axis "Latency, ms" 34 --> 46
    line [38.466,38.555,38.521,38.315,38.355,38.086,38.112,38.165,38.185,38.142,38.113,38.13,38.252,38.062,38.157,38.218,38.216,38.205,38.236,38.383,38.27,38.347,38.415,38.51,38.496,38.598,38.761,38.725,38.67,38.784,38.837,39.067,39.209,39.31,39.598,39.692,39.711,39.785,39.851,40.023,39.952,40.154,40.407,40.472,40.619,40.728,40.838,40.929,40.917,41.084,40.957,41.032,41.06,41.016,40.988,41.056,41.139,41.248,41.211,41.103,40.98,41.06,41.061,41.092,41.085,40.992,40.956,40.938,40.871,40.944,40.848,40.891,40.875,40.859,40.706,40.721,40.696,40.789,40.732,40.85,40.731,40.887,40.824,40.865,40.823,40.935,40.966,40.973,41.069,40.985,40.913,40.937,40.892,40.87,40.958,40.802,40.815,40.889,40.908,40.86,40.85,40.967,40.987,41.145,41.13,40.992,41.028,40.987,40.932,41.033,40.875,41.188,41.224,41.244,41.06,41.117,41.158,41.18,41.301,41.291,41.282,41.198,41.288,41.319,41.467,41.411,41.325,41.246,41.34,41.343,41.246,41.258,41.091,41.112,41.283,41.223,41.137,41.035,41.025,41.102,40.968,41.034,41.114,41.234,41.099,41.099,41.168,41.156,41.212,41.215,41.293,41.198,41.201,41.221,41.298,41.387,41.5,41.416,41.37,41.338,41.236,41.436,41.427,41.356,41.359,41.49,41.48,41.487,41.462,41.585,41.513,41.412,41.399,41.448,41.445,41.234,41.285,41.263,41.312,41.36,41.393,41.264,41.24,41.266,41.224,41.214,41.25,41.313,41.353,41.417,41.402,41.388,41.386,41.392,41.38,41.554,41.46,41.409,41.225,41.152,41.159,41.135,41.198,41.201,41.282,41.27,41.205,41.144,41.122,41.14,41.229,41.184,41.178,41.061,41.058,41.033,40.985,40.953,40.98,40.951,40.921,40.956,41.013,41.037,40.971,40.946,40.937,40.996,41.055,41.098,41.153,41.099,41.089,41.143,41.094,41.174,41.157,41.171,41.135,41.195,41.357,41.291,41.404,41.405,41.398,41.459,41.473,41.402,41.37,41.287,41.364,41.344,41.325,41.402,41.448,41.449,41.41,41.4,41.34,41.309,41.301,41.306,41.347,41.271,41.198,41.18,41.126,41.147,41.088,40.961,40.938,40.957,40.874,40.881,40.826,40.811,40.921,40.956,41.014,40.971,40.912,40.848,40.89,40.894,40.867,40.937,40.977,40.992,40.927,40.954,40.865,40.808,41.016,41.069,41.106,41.19,41.17,41.174,41.169,41.197,41.217,41.212,41.245,41.216,41.261,41.268,41.151,41.173,41.126,41.145,41.149,41.043,41.091,41.089,41.077,41.021,40.858,40.953,40.99,41.071,41.068,40.923,40.844,40.828,40.671,40.577,40.477,40.417,40.396,40.283,40.436,40.37,40.374,40.122,39.985,40.114,40.087,40.115,40.057,40.048,39.843,39.818,39.883,39.838,39.76,39.853,39.772,39.63,39.523,39.433,39.464,39.481,39.423,39.532,39.383,39.448,39.511,39.571,39.605,39.502,39.555,39.53,39.643,39.597,39.385,39.349,39.315,39.339,39.435,39.602,39.457,39.33,39.258,39.157,39.22,39.175,39.262,39.321,39.298,39.244,39.289,39.258,39.189,39.408,39.373,39.31,39.063,38.993,38.902,38.834,38.783,38.783,38.808,38.741,38.76,38.789,38.819,38.779,38.708,38.774,38.886,39.009,39.015,38.96,39.014,39.004,38.988,39.023,39.058,38.916,38.976,38.761,38.732,38.838,38.875,39.095,39.128,39.079,39.025,38.911,39.118,39.123,39.423,39.413,39.37,39.34,39.208,39.029,39.086,38.963,38.959,39.052,39.07,39.106,39.171,39.223,39.197,39.07,39.136,39.069,39.371,39.39,39.338,39.204,39.161,39.189,39.337,39.472,39.658,39.541,39.627,39.441,39.516,39.383,39.333,39.355,39.604,39.582,39.671,39.542,39.579,39.532,39.508,39.439,39.353,39.302,39.418,39.407,39.427,39.404,39.451,39.429,39.598,39.528,39.466,39.425,39.265,39.125,39.218,39.158,39.284,39.216,39.359,39.386,39.46,39.431,39.286,39.281,39.44,39.417,39.482,39.513,39.374,39.424,39.572,39.613,39.66,39.674,39.628,39.608,39.423,39.461,39.569,39.561,39.605,39.777,39.889,39.843,39.866,39.722,39.749,39.725,39.756,39.772,39.783,39.946,39.794,39.753,39.786,39.789,39.752,39.916,39.891,39.736,39.636,39.614,39.402,39.397,39.392,39.541,39.507,39.441,39.543,39.557,39.532,39.371,39.34,39.354,39.391,39.221,39.294,39.227,39.288,39.345,39.349,39.519,39.475,39.502,39.551,39.557,39.525,39.555,39.675,39.827,39.793,39.878,39.902,39.89,39.974,39.981,39.995,39.947,39.796,39.712,39.823,39.892,39.879,39.986,40.027,39.942,39.974,39.91,39.927,39.881,39.847,39.86,39.842,39.777,39.775,39.752,39.714,39.692,39.568,39.578,39.772,39.736,39.7,39.6]

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=write"
    x-axis "Time, m" 0 --> 10
    y-axis "Latency, ms" 33 --> 48
    line [37.748,37.529,37.362,37.609,37.629,37.713,37.521,37.855,37.773,37.731,37.654,37.896,38.064,38.015,37.969,37.843,38.05,38.055,37.924,37.883,37.931,38.045,38.619,38.871,39.065,39.844,39.916,39.801,39.805,39.758,39.989,40.341,40.71,40.768,40.924,41.039,41.086,41.288,41.295,41.549,41.437,41.714,41.557,41.663,41.95,41.969,42.078,42.154,42.317,42.435,42.546,42.35,42.334,42.306,41.964,41.828,42.059,42.067,42.152,42.231,42.175,42.131,42.269,42.279,42.243,42.215,42.18,42.34,42.177,42.297,42.143,42.343,42.375,42.146,42.224,42.325,42.279,42.288,42.275,42.259,42.143,42.226,42.233,42.355,42.364,42.138,42.217,42.1,42.05,42.111,42.003,41.93,41.683,41.702,41.757,41.851,41.649,41.699,41.535,41.458,41.339,41.219,41.288,41.335,41.208,41.275,41.209,41.073,41.027,41.371,41.214,41.532,41.519,41.611,41.659,41.639,41.741,41.741,41.55,41.406,41.385,41.534,41.639,41.759,41.631,41.55,41.431,41.434,41.572,41.703,41.723,41.643,41.601,41.623,41.643,41.384,41.455,41.405,41.049,41.182,40.84,40.844,40.956,40.981,40.879,40.96,41.039,41.215,41.77,41.786,41.82,41.899,41.835,41.837,42.112,42.298,42.28,42.357,42.308,42.432,42.692,42.7,42.835,42.905,43.18,43.146,43.17,43.294,43.319,43.347,43.479,43.488,43.519,43.478,43.485,43.515,43.555,43.323,43.275,43.344,43.244,43.27,43.317,43.122,43.136,43.047,42.977,42.959,42.82,42.682,42.849,42.85,42.797,42.643,42.706,42.735,42.624,42.559,42.527,42.313,42.223,42.038,41.986,41.968,41.892,41.765,41.623,41.604,41.4,41.2,41.214,41.218,41.466,41.364,41.613,41.542,41.554,41.542,41.588,41.173,41.046,41.11,41.066,40.794,40.661,40.641,40.62,40.569,40.819,40.645,40.852,40.781,40.672,40.696,40.746,40.807,40.915,41.084,41.324,41.338,41.336,41.202,41.182,41.332,41.381,41.583,41.589,41.372,41.398,41.342,41.362,41.581,41.802,41.89,42.016,41.979,42.124,41.854,41.953,42.066,42.234,42.239,42.372,42.444,42.546,42.394,42.36,42.345,42.298,42.345,42.301,42.367,42.103,42.122,41.864,42.007,42.283,42.415,42.363,42.301,42.148,42.113,42.008,41.881,41.835,41.782,41.85,41.879,41.85,41.718,41.745,41.795,41.918,42.045,42.239,42.322,42.393,42.427,42.368,42.409,42.376,42.376,42.711,42.709,42.678,42.662,42.676,42.659,42.765,42.79,42.84,42.76,42.808,42.728,42.695,42.644,42.567,42.445,42.507,42.457,42.243,42.1,41.884,41.674,41.428,41.215,41.114,41.15,41.098,41.143,41.257,40.769,40.9,40.803,40.57,40.494,40.35,40.074,40.099,39.787,39.904,39.766,40.248,40.118,40.092,40.112,39.931,39.743,39.689,39.798,39.743,39.605,39.716,39.827,39.85,39.93,39.751,39.694,39.562,39.463,39.679,39.234,39.142,39.053,39.107,39.327,39.388,39.171,39.139,39.184,39.056,38.657,38.741,38.639,38.543,38.518,38.49,38.731,38.608,38.391,38.274,38.239,38.109,38.391,38.05,37.924,38,37.783,37.451,37.197,37.374,37.293,37.606,37.612,37.522,37.787,38.308,38.553,38.558,38.907,38.782,38.653,38.667,38.745,38.89,38.986,38.926,39.07,39.345,39.491,39.495,39.561,39.19,39.289,39.495,39.554,39.585,39.658,39.589,39.698,39.945,39.907,39.914,40.254,40.059,39.904,39.769,39.754,39.49,39.624,39.49,39.444,39.528,39.481,39.317,39.112,39.075,38.959,38.981,38.681,38.646,38.926,39.094,39.116,39.252,39.449,39.563,39.655,39.703,39.757,40.097,40.18,39.845,39.921,39.911,40.094,40.066,40.204,40.066,40.316,40.261,40.114,40.422,40.639,40.669,40.722,40.712,40.812,40.984,41.032,41.126,40.968,40.992,40.891,40.866,40.71,40.495,40.322,40.087,39.866,39.689,39.614,39.439,39.268,38.945,38.879,38.783,38.873,38.752,38.875,38.808,38.213,37.98,38.025,38.058,37.986,37.834,37.834,37.873,37.561,37.747,37.57,37.819,37.739,37.976,37.976,38.154,38.381,38.033,38.142,38.341,38.775,39.028,39.432,39.393,39.541,39.571,39.747,39.707,39.739,39.804,39.825,39.856,39.791,39.929,40.001,40.025,39.941,39.913,39.674,39.65,39.563,39.588,39.47,39.645,39.67,39.629,39.674,39.585,39.496,39.279,39.174,38.862,39.043,39.216,39.187,39.237,39.279,39.312,39.331,39.172,38.956,39.073,39.102,38.712,38.738,39.012,39.111,39.368,39.461,39.273,39.277,39.256,39.323,39.518,39.531,39.563,39.549,39.549,39.605,39.544,39.669,39.578,39.324,39.371,39.244,39.279,39.353,39.549,39.719,39.942,39.822,39.638,40.058,40.057,39.811,39.795,39.777]

Copilot

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

Files not reviewed (1)

test-requirements.txt: Language not supported

Comments suppressed due to low confidence (1)

ydb/_topic_writer/topic_writer_asyncio.py:88

Consider catching Exception instead of BaseException to ensure that system-critical exceptions are not inadvertently suppressed.

except BaseException:

Copilot · 2025-04-04T09:59:56Z

ydb/topic.py

+            try:
+                logger.warning("Topic client was not closed properly. Consider using method close().")
+                self.close()
+            except BaseException:


Catching BaseException may unintentionally swallow critical exceptions like KeyboardInterrupt; consider catching Exception instead.

Suggested change

except BaseException:

except Exception:

Copilot · 2025-04-04T09:59:56Z

ydb/_topic_writer/topic_writer_sync.py

+            try:
+                logger.warning("Topic writer was not closed properly. Consider using method close().")
+                self.close(flush=False)
+            except BaseException:


Catching BaseException here can hide severe exceptions; consider catching Exception instead to avoid suppression of critical errors.

Suggested change

except BaseException:

except Exception:

Copilot · 2025-04-04T09:59:56Z

ydb/_topic_reader/topic_reader_sync.py

+            try:
+                logger.warning("Topic reader was not closed properly. Consider using method close().")
+                self.close(flush=False)
+            except BaseException:


Catching BaseException can mask unexpected issues; consider catching Exception instead to maintain clearer exception handling.

Suggested change

except BaseException:

except Exception:

Copilot · 2025-04-04T09:59:56Z

ydb/_topic_reader/topic_reader_asyncio.py

+                logger.warning("Topic reader was not closed properly. Consider using method close().")
+                task = self._loop.create_task(self.close(flush=False))
+                topic_common.wrap_set_name_for_asyncio_task(task, task_name="close reader")
+            except BaseException:


Catching BaseException here might hide critical system exceptions; switching to Exception is recommended for more precise error handling.

Suggested change

except BaseException:

except Exception:

vgvoleg requested a review from Copilot April 3, 2025 16:22

Copilot AI reviewed Apr 3, 2025

View reviewed changes

ydb/_topic_writer/topic_writer_sync.py Outdated Show resolved Hide resolved

ydb/_topic_reader/topic_reader_sync.py Outdated Show resolved Hide resolved

vgvoleg force-pushed the return_destructors branch 5 times, most recently from 7dc42fa to 7f4fa4f Compare April 4, 2025 09:42

Return topic desctuctors

16a20a4

vgvoleg force-pushed the return_destructors branch from 7f4fa4f to 16a20a4 Compare April 4, 2025 09:56

vgvoleg requested a review from Copilot April 4, 2025 09:57

Copilot AI reviewed Apr 4, 2025

View reviewed changes

vgvoleg merged commit 1336a9b into main Apr 4, 2025
41 of 42 checks passed

vgvoleg deleted the return_destructors branch April 4, 2025 10:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Return topic desctuctors #576

Return topic desctuctors #576

vgvoleg commented Apr 3, 2025 •

edited

Loading

Copilot AI left a comment

github-actions bot commented Apr 3, 2025 •

edited

Loading

github-actions bot commented Apr 3, 2025 •

edited

Loading

Copilot AI left a comment

Copilot AI Apr 4, 2025

Copilot AI Apr 4, 2025

Copilot AI Apr 4, 2025

Copilot AI Apr 4, 2025

Return topic desctuctors #576

Return topic desctuctors #576

Conversation

vgvoleg commented Apr 3, 2025 • edited Loading

Pull request type

What is the current behavior?

What is the new behavior?

Other information

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

github-actions bot commented Apr 3, 2025 • edited Loading

Operation Success Rate

Operations Per Second

95th Percentile Latency

github-actions bot commented Apr 3, 2025 • edited Loading

Operation Success Rate

Operations Per Second

95th Percentile Latency

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot AI Apr 4, 2025

Choose a reason for hiding this comment

Copilot AI Apr 4, 2025

Choose a reason for hiding this comment

Copilot AI Apr 4, 2025

Choose a reason for hiding this comment

Copilot AI Apr 4, 2025

Choose a reason for hiding this comment

vgvoleg commented Apr 3, 2025 •

edited

Loading

github-actions bot commented Apr 3, 2025 •

edited

Loading

github-actions bot commented Apr 3, 2025 •

edited

Loading