- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: brianc/node-postgres
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: yocontra/node-postgres
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 13 commits
- 8 files changed
- 3 contributors
Commits on Nov 20, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 7edfdf7 - Browse repository at this point
Copy the full SHA 7edfdf7View commit details -
Ensure callbacks are executed for all queued queries after connection…
…-level errors Separates socket errors from error messages, sends socket errors to all queries in the queue, marks clients as unusable after socket errors. This is not very pleasant but should maintain backwards compatibility…?
Configuration menu - View commit details
-
Copy full SHA for 6cba93d - Browse repository at this point
Copy the full SHA 6cba93dView commit details -
Always call
handleError
asynchronouslyThis doesn’t match the original behaviour of the type errors, but it’s correct.
Configuration menu - View commit details
-
Copy full SHA for 7b6b7a1 - Browse repository at this point
Copy the full SHA 7b6b7a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdf5a4a - Browse repository at this point
Copy the full SHA fdf5a4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57bd144 - Browse repository at this point
Copy the full SHA 57bd144View commit details
Commits on Feb 12, 2018
-
Handle SSL negotiation errors more robustly
This commit adds some finer grained detail to handling the postmaster's response to SSL negotiation packets, by accounting for the possibility of an 'E' byte being sent back, and emitting an appropriate error. In the naive case, the postmaster will respond with either 'S' (proceed with an SSL connection) or 'N' (SSL is not supported). However, the current if statement doesn't account for an 'E' byte being returned by the postmaster, where an error is encountered (perhaps unable to fork due to being out of memory). By adding this case, we can prevent confusing error messages when SSL is enforced and the postmaster returns an error after successful SSL connections. This also brings the connection handling further in line with libpq, where 'E' is handled similarly as of this commit: postgres/postgres@a49fbaa Given that there are no longer pre-7.0 databases out in the wild, I believe this is a safe change to make, and should not break backwards compatibility (unless matching on error message content). * Replace if statement with switch, to catch 'S', 'E' and 'N' bytes returned by the postmaster * Return an Error for non 'S' or 'N' cases * Expand and restructure unit tests for SSL negotiation packets
Configuration menu - View commit details
-
Copy full SHA for b75adc6 - Browse repository at this point
Copy the full SHA b75adc6View commit details
Commits on Feb 14, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f1f3eb5 - Browse repository at this point
Copy the full SHA f1f3eb5View commit details
Commits on Feb 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for fcfacbd - Browse repository at this point
Copy the full SHA fcfacbdView commit details
Commits on Feb 22, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 66d0581 - Browse repository at this point
Copy the full SHA 66d0581View commit details
Commits on Apr 2, 2018
-
Configuration menu - View commit details
-
Copy full SHA for eb77592 - Browse repository at this point
Copy the full SHA eb77592View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26f95f3 - Browse repository at this point
Copy the full SHA 26f95f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03eed3e - Browse repository at this point
Copy the full SHA 03eed3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91a3871 - Browse repository at this point
Copy the full SHA 91a3871View commit details
There are no files selected for viewing