Skip to content

Create PigeonHoleSort.java #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

dhruvsisd
Copy link
Contributor

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding.

Description

Please describe what changes you have made.

For Example:

  • Added a file(s) named '...' that implements '...'.

  • Changed the algorithm for performance/readablity/bugs.

  • Added documentation to the algorithm

Related Issue

This project only accepts pull requests related to open issues.

If suggesting a new feature or change, please discuss it in an issue first.

If fixing a bug, there should be an issue describing it with steps to reproduce.

Please link to the issue here:

How Has This Been Tested? (Optional)

Please describe in detail how you tested your changes.
You can skip this if you have not added any tests.

Screenshots (Optional)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (change which fixes an issue with the algorithm)

  • New Algorithm (non-breaking change which adds functionality)

  • Documentation

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.

  • My change requires a change to the documentation.

  • I have updated the documentation accordingly.

  • I have read the CONTRIBUTING document.

Copy link
Member

@tstreamDOTh tstreamDOTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the right dir structure

sort.pigeonhole_sort(arr,arr.length);
for(int i=0 ; i<arr.length ; i++)
System.out.print(arr[i] + " ");
} }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dhruvsisd,
Please add comments and again you might have missed resubmitting your version of code (please see this https://www.geeksforgeeks.org/pigeonhole-sort/)
Please apply similar formatting rules through out the file.

@dhruvsisd dhruvsisd closed this Oct 29, 2018
@dhruvsisd dhruvsisd deleted the patch-11 branch October 29, 2018 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants