Fix: passes api_base, api_key, litellm_params_dict to custom_llm embedding methods #11450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
stefan--
pushed a commit
to stefan--/litellm
that referenced
this pull request
Jun 12, 2025
…dding methods (BerriAI#11450) * fix: passing litellm_params_dict instead of litellm_params which is a list of strings * updated custom llm embedding params and litellm_params_dict --------- Co-authored-by: Ganesh Jagadeesan <cjagadeesan@dataminr.com>
X4tar
pushed a commit
to X4tar/litellm
that referenced
this pull request
Jun 17, 2025
…dding methods (BerriAI#11450) * fix: passing litellm_params_dict instead of litellm_params which is a list of strings * updated custom llm embedding params and litellm_params_dict --------- Co-authored-by: Ganesh Jagadeesan <cjagadeesan@dataminr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes essential parameters to CustomLLM Embedding methods
api_base,api_key, andtimeoutwere missing and have been addedlitellm_params_dict(the key value mapping) is passed instead oflitellm_params(list of strings of only keys)Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
Changes